MD Extensions: No feedback after packing an extension |
||||||||||||||
Issue descriptionWhat steps will reproduce the problem? 1. Enable md extensions and go to chrome://extensions 2. Pack an unpacked extension What is the expected result? Expect feedback about what packing did. What happens instead of that? Nothing - we show no feedback. In the old UI, we indicated that the browser had done something: created the .crx (and possibly .pem) file, gave some advice, etc. That's all missing in the MD page. :( Attached screenshots of the old and new UIs. jawag@, dpapad@: This might be a blocker. WDYT?
,
Dec 14 2017
,
Dec 14 2017
bettes@, any guidance here? Are you okay just popping up a second dialog/updating the current dialog with the same text as the old page?
,
Dec 15 2017
,
Dec 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ee474bca8a99b11e5afa2bd90fc34ae9cfc36b7 commit 5ee474bca8a99b11e5afa2bd90fc34ae9cfc36b7 Author: Scott Chen <scottchen@chromium.org> Date: Sat Dec 16 01:12:27 2017 MD Extensions: pack-dialog success message Bug: 795012 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifab4bd719569504821dc18db8ac785fadfaa71b3 Reviewed-on: https://chromium-review.googlesource.com/828461 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#524547} [modify] https://crrev.com/5ee474bca8a99b11e5afa2bd90fc34ae9cfc36b7/chrome/browser/resources/md_extensions/pack_dialog.html [modify] https://crrev.com/5ee474bca8a99b11e5afa2bd90fc34ae9cfc36b7/chrome/browser/resources/md_extensions/pack_dialog.js [modify] https://crrev.com/5ee474bca8a99b11e5afa2bd90fc34ae9cfc36b7/chrome/browser/resources/md_extensions/pack_dialog_alert.html [modify] https://crrev.com/5ee474bca8a99b11e5afa2bd90fc34ae9cfc36b7/chrome/browser/resources/md_extensions/pack_dialog_alert.js [modify] https://crrev.com/5ee474bca8a99b11e5afa2bd90fc34ae9cfc36b7/chrome/test/data/webui/extensions/extension_pack_dialog_test.js
,
Dec 16 2017
,
Dec 16 2017
,
Dec 17 2017
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 18 2017
As discussed in meeting, Extensions MD launch is behind a flag. Change has been tested and verified in Canary. Approving merge to M64 branch:3282
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f012d7f0b78802bbe06dae8a0f16f37c6c6172a7 commit f012d7f0b78802bbe06dae8a0f16f37c6c6172a7 Author: Scott Chen <scottchen@chromium.org> Date: Tue Dec 19 01:08:31 2017 MD Extensions: pack-dialog success message Bug: 795012 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifab4bd719569504821dc18db8ac785fadfaa71b3 Reviewed-on: https://chromium-review.googlesource.com/828461 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#524547}(cherry picked from commit 5ee474bca8a99b11e5afa2bd90fc34ae9cfc36b7) Reviewed-on: https://chromium-review.googlesource.com/833488 Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#285} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/f012d7f0b78802bbe06dae8a0f16f37c6c6172a7/chrome/browser/resources/md_extensions/pack_dialog.html [modify] https://crrev.com/f012d7f0b78802bbe06dae8a0f16f37c6c6172a7/chrome/browser/resources/md_extensions/pack_dialog.js [modify] https://crrev.com/f012d7f0b78802bbe06dae8a0f16f37c6c6172a7/chrome/browser/resources/md_extensions/pack_dialog_alert.html [modify] https://crrev.com/f012d7f0b78802bbe06dae8a0f16f37c6c6172a7/chrome/browser/resources/md_extensions/pack_dialog_alert.js [modify] https://crrev.com/f012d7f0b78802bbe06dae8a0f16f37c6c6172a7/chrome/test/data/webui/extensions/extension_pack_dialog_test.js |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by dpa...@chromium.org
, Dec 14 2017