New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 794982 link

Starred by 2 users
Status: Fixed
Owner:
█ ethannicholas@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
dtu@chromium.org
█ kraynov@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

15.1%-29.9% regression in smoothness.tough_animation_cases at 523465:523585

Project Member Reported by kraynov@chromium.org, Dec 14 2017 
See the link to graphs below.
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Dec 14 2017 

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=794982

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=bfd5dbd01c3892110bc462630f3b72d8a0286f637704970f8d992a5ffb6ca6af


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Dec 14 2017 

馃搷 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/17c0b0ea040000

Comment 3 by sullivan@chromium.org, Jan 22 2018

Cc: dtu@chromium.org
+dtu the output from the pinpoint job in #2 looks pretty crazy.

Kicking another bisect.
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Jan 22 2018 

馃搷 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/13cab3c8840000

Comment 5 by dtu@chromium.org, Jan 22 2018 

Comment #3: looks like https://github.com/catapult-project/catapult/issues/4040
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Jan 22 2018

Cc: ethannicholas@google.com robertph...@google.com keishi@chromium.org bore...@google.com palmer@chromium.org rsesek@chromium.org aleventhal@chromium.org thanhdle@chromium.org est...@chromium.org jdonnelly@chromium.org ryansturm@chromium.org rmis...@google.com jsb...@chromium.org mtklein@chromium.org csmartdalton@google.com angle-deps-roller@chromium.org jorgelo@chromium.org ellyjo...@chromium.org fmalita@chromium.org tobiasjs@chromium.org tsepez@chromium.org bsalo...@google.com tbansal@chromium.org
Owner: tsepez@chromium.org
Status: Assigned (was: Untriaged)
馃搷 Found significant differences after each of 11 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/13cab3c8840000

Omnibox: provide "n of m" position info with screen reader search suggestions
By aleventhal@chromium.org 路 Tue Dec 12 19:14:42 2017
chromium @ 5126c5ebd3e5a72b9e136e6ef6eef5685458c449

Prefer fullscreen clears on Qualcomm/GL
By csmartdalton@google.com 路 Tue Dec 12 15:21:09 2017 +0000
skia @ 344e9037e1befdee76691a1239a47829e6af4ea5

converted vertex shaders to device coords
By ethannicholas@google.com 路 Tue Dec 12 15:24:09 2017 +0000
skia @ e7e81c15c144b8133f696d0744ed9f7e8d06e936

Roll skia/third_party/externals/angle2/ 629a64498..feb2c63b7 (1 commit)
By angle-deps-roller@chromium.org 路 Tue Dec 12 15:30:09 2017 +0000
skia @ eb27cab65294b9aa03ba56f8422264445fedd660

Use new bookmaker flag to status.json
By rmistry@google.com 路 Tue Dec 12 15:36:29 2017 +0000
skia @ 578d4517569f8686b0d7145d6cc8824a1e209ce5

drop to scalar mode in some armv7 debug builds
By mtklein@chromium.org 路 Tue Dec 12 15:56:19 2017 +0000
skia @ 03696ce21ccb84243370ecbf499cc47549854dbd

Changed from map to array in mojom for Previews modes and flags values.
By thanhdle@chromium.org 路 Tue Dec 12 19:28:35 2017
chromium @ a60988132fe6e6ef530e283aed978232cccd85d9

<b><input type=file webkitdirectory>: Launch picker on Enter keyup</b>
By jsbell@chromium.org 路 Tue Dec 12 19:28:54 2017
chromium @ 745e1b4545d51a2ad620d590682ca6eadd95f36c

crash_keys: Convert keys in //android_webview to the new API.
By rsesek@chromium.org 路 Tue Dec 12 19:30:02 2017
chromium @ 236e058375ef3b2d8ca7b26f1391c48c7a5d0379

Adding MCC/MNC to Data_reduction_proxy ClientConfig
By ryansturm@chromium.org 路 Tue Dec 12 19:34:40 2017
chromium @ 63576d29e15e56eee6e2c50364c4e5a92d5b74df

[linux] O_EXCL requirement in brokered open call too restrictive.
By tsepez@chromium.org 路 Tue Dec 12 20:05:37 2017
chromium @ 79d229fc55b604c88295b810ee8faf586e1933d7

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Comment 7 by csmartdalton@google.com, Jan 23 2018 

> Prefer fullscreen clears on Qualcomm/GL
> By csmartdalton@google.com 路 Tue Dec 12 15:21:09 2017 +0000
> skia @ 344e9037e1befdee76691a1239a47829e6af4ea5

This change should have zero effect on a chromium-rel-mac-retina bot. It only affects Qualcomm devices.

Comment 8 by aleventhal@chromium.org, Jan 23 2018 

> Omnibox: provide "n of m" position info with screen reader search suggestions
> By aleventhal@chromium.org 路 Tue Dec 12 19:14:42 2017
> chromium @ 5126c5ebd3e5a72b9e136e6ef6eef5685458c449
This change only affects screen reader output -- does not affect what is visually displayed in any way.

Comment 9 by thanhdle@chromium.org, Jan 23 2018 

> Changed from map to array in mojom for Previews modes and flags values.
> By thanhdle@chromium.org 路 Tue Dec 12 19:28:35 2017
> chromium @ a60988132fe6e6ef530e283aed978232cccd85d9

This only changes the data type of a mojo message. It does not affect what is visually displayed.

Comment 10 by mtklein@chromium.org, Jan 23 2018

Owner: ethannicholas@chromium.org
If you look at https://pinpoint-dot-chromeperf.appspot.com/job/13cab3c8840000, it's pretty clear the regression is Ethan's https://skia.googlesource.com/skia/+/e7e81c15c144b8133f696d0744ed9f7e8d06e936.

I think everyone else can -CC themselves...

Comment 11 by thanhdle@chromium.org, Jan 23 2018

Cc: -thanhdle@chromium.org

Comment 12 by rsesek@chromium.org, Jan 23 2018

Cc: -rsesek@chromium.org

Comment 13 by aleventhal@chromium.org, Jan 23 2018

Cc: -aleventhal@chromium.org

Comment 14 by jorgelo@chromium.org, Jan 23 2018

Cc: -jorgelo@chromium.org

Comment 15 by ethannicholas@google.com, Jan 23 2018 

Working on a revert.

Comment 16 by ethannicholas@chromium.org, Jan 23 2018

Cc: mmenke@chromium.org tedc...@chromium.org ethannicholas@chromium.org rdsmith@chromium.org bsazonov@chromium.org
 Issue 794952  has been merged into this issue.

Comment 17 by mmenke@chromium.org, Jan 23 2018

Cc: -mmenke@chromium.org

Comment 18 by ethannicholas@chromium.org, Jan 23 2018

Cc: yawano@chromium.org e...@chromium.org altimin@chromium.org skia-deps-roller@chromium.org mek@chromium.org phulce@chromium.org zea@chromium.org sammiequon@google.com scottmg@chromium.org yangguo@chromium.org edchin@chromium.org delph...@chromium.org bunge...@chromium.org dschuyler@chromium.org alexilin@chromium.org martiniss@chromium.org kojii@chromium.org bauerb@chromium.org art-sn...@yandex-team.ru hajimehoshi@chromium.org jbudorick@chromium.org schenney@chromium.org bmeu...@chromium.org e...@chromium.org oetu...@nvidia.com mthiesse@chromium.org fgor...@chromium.org torne@chromium.org ashleymarie@chromium.org pdr@chromium.org eladalon@chromium.org kjlubick@google.com steve...@chromium.org asweintraub@google.com osh...@chromium.org yzshen@chromium.org liaoyuke@chromium.org brat...@opera.com dsinclair@chromium.org panicker@chromium.org jaebaek@chromium.org a...@chromium.org jvanverth@google.com catapult-deps-roller@chromium.org jonr...@chromium.org guidou@chromium.org ynovikov@chromium.org jmad...@chromium.org japhet@chromium.org mahmadi@chromium.org eugene...@chromium.org mustaq@chromium.org awdf@chromium.org vmp...@chromium.org yosin@chromium.org haraken@chromium.org xiy...@chromium.org rhalavati@chromium.org dpranke@chromium.org rnep...@chromium.org sdefresne@chromium.org dskiba@chromium.org jbroman@chromium.org yfried...@chromium.org yukishiino@chromium.org pastarmovj@chromium.org brettw@chromium.org dpa...@chromium.org sky@chromium.org nparker@chromium.org chrishtr@chromium.org cwallez@chromium.org achuith@chromium.org jie.a.c...@intel.com p...@chromium.org junov@chromium.org dmu...@chromium.org kouhei@chromium.org dtrainor@chromium.org kbr@chromium.org xiaohuic@google.com v8-autoroll@chromium.org twelling...@chromium.org sadrul@chromium.org hirosh...@chromium.org jamescook@chromium.org est...@chromium.org peria@chromium.org chaopeng@chromium.org gogerald@google.com isherman@chromium.org drott@chromium.org crouleau@chromium.org mvanouwerkerk@google.com lizeb@chromium.org johnchen@chromium.org kinuko@chromium.org timvolodine@google.com geoffl...@chromium.org egdaniel@google.com mmoroz@chromium.org x...@chromium.org brianosman@google.com bcwh...@chromium.org jam@chromium.org s...@chromium.org finnur@chromium.org sunxd@chromium.org huangml@chromium.org agrieve@chromium.org boliu@chromium.org piman@chromium.org marq@chromium.org nedngu...@google.com mark@chromium.org smcgruer@chromium.org roc...@chromium.org asvitk...@chromium.org qin...@chromium.org xunji...@chromium.org peter@chromium.org xingliu@chromium.org charliea@chromium.org cm.san...@samsung.com thestig@chromium.org awhalley@chromium.org zakerinasab@chromium.org mdjones@chromium.org danakj@chromium.org rouslan@chromium.org benjhayden@chromium.org ymalik@google.com twellington@google.com mef@chromium.org
 Issue 781814  has been merged into this issue.

Comment 19 by altimin@chromium.org, Jan 23 2018

Cc: -altimin@chromium.org

Comment 20 by dtu@chromium.org, Jan 23 2018

Cc: -ynovikov@chromium.org -brianosman@google.com -pastarmovj@chromium.org -bore...@google.com -yukishiino@chromium.org -danakj@chromium.org -oetu...@nvidia.com -marq@chromium.org -panicker@chromium.org -pdr@chromium.org -x...@chromium.org -a...@chromium.org -kbr@chromium.org -junov@chromium.org -xunji...@chromium.org -guidou@chromium.org -cwallez@chromium.org -jam@chromium.org -bcwh...@chromium.org -jie.a.c...@intel.com -torne@chromium.org -japhet@chromium.org -agrieve@chromium.org -smcgruer@chromium.org -rmis...@google.com -bmeu...@chromium.org -geoffl...@chromium.org -mef@chromium.org -xiy...@chromium.org -kinuko@chromium.org -mahmadi@chromium.org -qin...@chromium.org -twelling...@chromium.org -chaopeng@chromium.org -tobiasjs@chromium.org -bsazonov@chromium.org -rouslan@chromium.org -yangguo@chromium.org -bunge...@chromium.org -kouhei@chromium.org -isherman@chromium.org -robertph...@google.com -timvolodine@google.com -art-sn...@yandex-team.ru -brat...@opera.com -vmp...@chromium.org -asweintraub@google.com -sadrul@chromium.org -sammiequon@google.com -jdonnelly@chromium.org -tedc...@chromium.org -kojii@chromium.org -roc...@chromium.org -tbansal@chromium.org -fgor...@chromium.org -finnur@chromium.org -mtklein@chromium.org -benjhayden@chromium.org -boliu@chromium.org -awdf@chromium.org -fmalita@chromium.org -peria@chromium.org -est...@chromium.org -yzshen@chromium.org -thestig@chromium.org -liaoyuke@chromium.org -egdaniel@google.com -jsb...@chromium.org -eugene...@chromium.org -catapult-deps-roller@chromium.org -sunxd@chromium.org -e...@chromium.org -mmoroz@chromium.org -piman@chromium.org -yosin@chromium.org -keishi@chromium.org -jbroman@chromium.org -mdjones@chromium.org -mvanouwerkerk@google.com -mustaq@chromium.org -charliea@chromium.org -hajimehoshi@chromium.org -rhalavati@chromium.org -yfried...@chromium.org -angle-deps-roller@chromium.org -bauerb@chromium.org -alexilin@chromium.org -eladalon@chromium.org -twellington@google.com -ryansturm@chromium.org -ellyjo...@chromium.org -delph...@chromium.org -rdsmith@chromium.org -p...@chromium.org -schenney@chromium.org -s...@chromium.org -dpranke@chromium.org -jonr...@chromium.org -jaebaek@chromium.org -nparker@chromium.org -gogerald@google.com -zea@chromium.org -martiniss@chromium.org -yawano@chromium.org -v8-autoroll@chromium.org -bsalo...@google.com -phulce@chromium.org -zakerinasab@chromium.org -edchin@chromium.org -haraken@chromium.org -tsepez@chromium.org -mek@chromium.org -jamescook@chromium.org -sky@chromium.org -dpa...@chromium.org -hirosh...@chromium.org -nedngu...@google.com -kjlubick@google.com -xiaohuic@google.com -dmu...@chromium.org -est...@chromium.org -xingliu@chromium.org -peter@chromium.org -dschuyler@chromium.org -ymalik@google.com -dtrainor@chromium.org -dskiba@chromium.org -asvitk...@chromium.org -rnep...@chromium.org -crouleau@chromium.org -cm.san...@samsung.com -e...@chromium.org -osh...@chromium.org -csmartdalton@google.com -steve...@chromium.org -sdefresne@chromium.org -jvanverth@google.com -skia-deps-roller@chromium.org -ethannicholas@chromium.org -mthiesse@chromium.org -mark@chromium.org -palmer@chromium.org -dsinclair@chromium.org -ethannicholas@google.com -johnchen@chromium.org -jbudorick@chromium.org -achuith@chromium.org -huangml@chromium.org -awhalley@chromium.org -scottmg@chromium.org -lizeb@chromium.org -chrishtr@chromium.org -brettw@chromium.org -ashleymarie@chromium.org -jmad...@chromium.org -drott@chromium.org

Comment 21 by ethannicholas@chromium.org, Jan 29 2018

Status: Fixed (was: Assigned)
My revert has been rolled into Chrome.
►

Sign in to add a comment