New issue
Advanced search Search tips

Issue 794961 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 30
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

BrowserTests-Viz: Metabug

Project Member Reported by jonr...@chromium.org, Dec 14 2017

Issue description

We need to get coverage of browser_tests with --enable-viz

This is the metabug to track getting that coverage first on FYI bots, then on the main waterfall.

All failing tests will have separate bugs filed, and will have them attached to this one.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e360d9b0a4640a7392335282398dc58346a98e3

commit 3e360d9b0a4640a7392335282398dc58346a98e3
Author: Jonathan <jonross@chromium.org>
Date: Thu Dec 14 18:52:48 2017

Add Viz Browser Tests to the Mojo Windows FYI bot

We want to begin getting coverage of browser_tests with --enable_viz.
To start we would like to run them on a Windows FYI bot to find flakes.

I'll be triaging the failures found so far, and updating the filter
later on with the associated bugs.

TEST: viz_browser_tests
BUG:  794961 
Change-Id: I554af1c3d308da1b7fd0496c08efa24e17bd6799
Reviewed-on: https://chromium-review.googlesource.com/822295
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524130}
[modify] https://crrev.com/3e360d9b0a4640a7392335282398dc58346a98e3/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/3e360d9b0a4640a7392335282398dc58346a98e3/testing/buildbot/filters/BUILD.gn
[add] https://crrev.com/3e360d9b0a4640a7392335282398dc58346a98e3/testing/buildbot/filters/viz.browser_tests.filter
[modify] https://crrev.com/3e360d9b0a4640a7392335282398dc58346a98e3/testing/buildbot/test_suites.pyl

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94ef1e1bd544561b6540515a13c7c3056fd6977e

commit 94ef1e1bd544561b6540515a13c7c3056fd6977e
Author: Jonathan <jonross@chromium.org>
Date: Fri Dec 15 17:21:25 2017

Disable new viz_browser_test failures

After landing viz_browser_test on the Windows FYI bot even more failures have
turned up. I'm disabling them until we triage/fix them.

TEST=viz_browser_test
TBR=kylechar@chromium.org

Bug:  794961 
Change-Id: I0d80fe1404174e1b94260389877a5c1d6d19333f
Reviewed-on: https://chromium-review.googlesource.com/829616
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524402}
[modify] https://crrev.com/94ef1e1bd544561b6540515a13c7c3056fd6977e/testing/buildbot/filters/viz.browser_tests.filter

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73b075715c4ffee6ca4f97f91a0aa4ff87c64f47

commit 73b075715c4ffee6ca4f97f91a0aa4ff87c64f47
Author: Jonathan <jonross@chromium.org>
Date: Mon Dec 18 16:29:34 2017

Disable Flaking Viz Browser Tests

More tests are flaking in viz_browser_tests disabling until we triage.

TBR=kylechar@chromium.org

Bug:  794961 
Change-Id: I9eba78c0017a492eaed54826e0aa75f2354ee600
Reviewed-on: https://chromium-review.googlesource.com/832667
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524724}
[modify] https://crrev.com/73b075715c4ffee6ca4f97f91a0aa4ff87c64f47/testing/buildbot/filters/viz.browser_tests.filter

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7f4ebe7c290ad6680fa75dd690fbc75900c0524

commit a7f4ebe7c290ad6680fa75dd690fbc75900c0524
Author: Jonathan <jonross@chromium.org>
Date: Tue Dec 19 15:50:29 2017

Update viz_browser_tests filter

We added viz_browser_tests to more configs, which found more flakes. Updating
the filter accrodingly

TBR=kylechar@chromium.org

Bug:  794961 
Change-Id: I4701c370d839b106ffce9ec3a8a3a3eb3802a561
Reviewed-on: https://chromium-review.googlesource.com/833161
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525041}
[modify] https://crrev.com/a7f4ebe7c290ad6680fa75dd690fbc75900c0524/testing/buildbot/filters/viz.browser_tests.filter

Blockedon: 730660
Blockedon: 754864
Blockedon: 715640
Blockedon: 796336
Blockedon: 796344
Blockedon: 796575
Blockedon: 796594
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/173f931e350e06701e2ed636765796b809781a33

commit 173f931e350e06701e2ed636765796b809781a33
Author: Jonathan <jonross@chromium.org>
Date: Wed Dec 20 18:49:18 2017

Ogranize and Update viz_browser_tests filter

Update viz_browser_tests filter file with new failures. Also sort the file
based on the failures seen, with bugs listed.

TBR=kylechar@chromium.org

Bug:  794961 
Change-Id: I716da7172d3cd1a51efe5432d267d640fec15af7
Reviewed-on: https://chromium-review.googlesource.com/836929
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525385}
[modify] https://crrev.com/173f931e350e06701e2ed636765796b809781a33/testing/buildbot/filters/viz.browser_tests.filter

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1fd78e6c8909478c8c613ce7e6bc1bf0252f79b

commit e1fd78e6c8909478c8c613ce7e6bc1bf0252f79b
Author: Jonathan <jonross@chromium.org>
Date: Thu Dec 21 23:36:53 2017

Update viz_browser_tests filter

More failures have been found on the FYI bots. Updating the filter.

TBR=kylechar@chromium.org

Bug:  794961 
Change-Id: I3df225a40db04bbeac705ce490e55e395e0bd1da
Reviewed-on: https://chromium-review.googlesource.com/841287
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525854}
[modify] https://crrev.com/e1fd78e6c8909478c8c613ce7e6bc1bf0252f79b/testing/buildbot/filters/viz.browser_tests.filter

Blockedon: 797801
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f72d90102a67e89d7c14791169296497deafc592

commit f72d90102a67e89d7c14791169296497deafc592
Author: Jonathan <jonross@chromium.org>
Date: Wed Jan 03 03:26:11 2018

Update viz_browser_tests filter for new failures

Updating the filter file for new failures that have been found.

TBR=kylechar@chromium.org

Bug:  794961 
Change-Id: Idd96cb7029e2c16038cb3e1d43dd3a4f2573c244
Reviewed-on: https://chromium-review.googlesource.com/847422
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526609}
[modify] https://crrev.com/f72d90102a67e89d7c14791169296497deafc592/testing/buildbot/filters/viz.browser_tests.filter

Blockedon: 803148
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42a8cc332042ea13ea9a39d40514c4c49ebd49f3

commit 42a8cc332042ea13ea9a39d40514c4c49ebd49f3
Author: Jonathan <jonross@chromium.org>
Date: Wed Jan 17 19:02:36 2018

Update viz_browser_tests filter

The crashes during software rendering should be fixed.
This removes them from the filter.

TBR=kylechar@chromium.org

Bug:  794961 
Change-Id: I15dd91fbc3002804c3149a398c537e9f9381eea6
Reviewed-on: https://chromium-review.googlesource.com/870730
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529834}
[modify] https://crrev.com/42a8cc332042ea13ea9a39d40514c4c49ebd49f3/testing/buildbot/filters/viz.browser_tests.filter

Blockedon: 810389
Blockedon: 817787
Blockedon: 818205
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdeb953c246a5827e737c38017b2f6788b8cb52f

commit fdeb953c246a5827e737c38017b2f6788b8cb52f
Author: jonross <jonross@chromium.org>
Date: Fri Mar 02 16:31:29 2018

Filter out new viz_browser_tests failures

Two new tests are failing on viz_browser_tests, this filters them out. They've
been triaged to appropriate bugs

TBR=kylechar@chromium.org

Bug:  794961 
Change-Id: I4693c03eac9e8f895b8d6a517cf83bba3066585e
Reviewed-on: https://chromium-review.googlesource.com/946512
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540532}
[modify] https://crrev.com/fdeb953c246a5827e737c38017b2f6788b8cb52f/testing/buildbot/filters/viz.browser_tests.filter

Blockedon: 812012
Blockedon: 820449
Blockedon: 821029
Project Member

Comment 25 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fe4215acdfa5a1e3015822fb9bff649f18dca87

commit 4fe4215acdfa5a1e3015822fb9bff649f18dca87
Author: jonross <jonross@chromium.org>
Date: Tue Mar 13 15:57:22 2018

Update viz_browser_tests filter for flaky timeouts

There are a series of tests currently flaking on Windows with timeouts, and no
errors. This change disables them via the Viz filter.

TBR=kylechar@chromium.org
TEST=viz_browser_tests

Bug:  794961 
Change-Id: I4f2bfabc461f78cd9d187b610472c396d3c91a0b
Reviewed-on: https://chromium-review.googlesource.com/960576
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542814}
[modify] https://crrev.com/4fe4215acdfa5a1e3015822fb9bff649f18dca87/testing/buildbot/filters/viz.browser_tests.filter

SW compositing (730660) should work well enough to not be blocking this anymore, tho it's not quite complete in the details.
Blockedon: -730660
I'm removing  issue 730660  from blocking this per danajk@'s comments in #26.
If any SW compositing related bugs show up I'll file them separately.

Thanks for all the work in getting that working!!
Project Member

Comment 28 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4fea67f0c47c68dc73e9e5f41978199d3f479db

commit b4fea67f0c47c68dc73e9e5f41978199d3f479db
Author: jonross <jonross@chromium.org>
Date: Thu May 17 00:09:54 2018

Reenable some Viz tests

A series of tests in viz_browser_tests and viz_content_browsertests have been
fixed, but no re-enabled.

This re-enables them.

TBR=kylechar@chromium.org
TEST=viz_browser_tests, viz_content_browsertests

Bug: 	 794961 
Change-Id: Ife0401cc891696a549aa180cbc0cf0034bc5bc5c
Reviewed-on: https://chromium-review.googlesource.com/1062812
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559351}
[modify] https://crrev.com/b4fea67f0c47c68dc73e9e5f41978199d3f479db/testing/buildbot/filters/viz.browser_tests.filter
[modify] https://crrev.com/b4fea67f0c47c68dc73e9e5f41978199d3f479db/testing/buildbot/filters/viz.content_browsertests.filter

Blockedon: 851631
Blockedon: 854798
Blockedon: -812012
Blockedon: -715640
Project Member

Comment 33 by bugdroid1@chromium.org, Jul 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e824b103a95858d43105b761095b3649fb3d240

commit 9e824b103a95858d43105b761095b3649fb3d240
Author: jonross <jonross@chromium.org>
Date: Fri Jul 27 12:09:49 2018

Remove Viz Content BrowserTests Filter

While work on Android is on going, the remaining Viz failures on other platforms
have been resolved. The filter file is no longer needed.

This change removes it.

TEST=viz_content_browsertests

Bug:  794961 
Change-Id: I46f8a7094aa10f72cf383607a8b7a68a19141fc8
Reviewed-on: https://chromium-review.googlesource.com/1150684
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578606}
[modify] https://crrev.com/9e824b103a95858d43105b761095b3649fb3d240/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/9e824b103a95858d43105b761095b3649fb3d240/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/9e824b103a95858d43105b761095b3649fb3d240/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/9e824b103a95858d43105b761095b3649fb3d240/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/9e824b103a95858d43105b761095b3649fb3d240/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/9e824b103a95858d43105b761095b3649fb3d240/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/9e824b103a95858d43105b761095b3649fb3d240/testing/buildbot/chromium.win.json
[modify] https://crrev.com/9e824b103a95858d43105b761095b3649fb3d240/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/b5e688dcc4bffc28d177f53d4c2a17cafac3bc28/testing/buildbot/filters/viz.content_browsertests.filter
[modify] https://crrev.com/9e824b103a95858d43105b761095b3649fb3d240/testing/buildbot/test_suites.pyl

Project Member

Comment 34 by bugdroid1@chromium.org, Jul 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c211b845b642942b363eeb63e673e39e5edb64b0

commit c211b845b642942b363eeb63e673e39e5edb64b0
Author: jonross <jonross@chromium.org>
Date: Mon Jul 30 20:02:44 2018

Remove Viz BrowserTests filter

We no longer need the filter for viz_browser_tests, so I'm deleting it.

TEST=viz_browser_tests

Bug:  794961 
Change-Id: Ib14550096d4a4f479303375a613a2959e74eb6f8
Reviewed-on: https://chromium-review.googlesource.com/1154890
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579134}
[modify] https://crrev.com/c211b845b642942b363eeb63e673e39e5edb64b0/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/c211b845b642942b363eeb63e673e39e5edb64b0/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/c211b845b642942b363eeb63e673e39e5edb64b0/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/c211b845b642942b363eeb63e673e39e5edb64b0/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/c211b845b642942b363eeb63e673e39e5edb64b0/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/c211b845b642942b363eeb63e673e39e5edb64b0/testing/buildbot/chromium.win.json
[modify] https://crrev.com/c211b845b642942b363eeb63e673e39e5edb64b0/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/8aefbd89b8fe26a736055fb5393047f32dcba83a/testing/buildbot/filters/viz.browser_tests.filter
[modify] https://crrev.com/c211b845b642942b363eeb63e673e39e5edb64b0/testing/buildbot/test_suites.pyl

Status: Fixed (was: Started)
Tests are up an running, both on FYI, and mostly on CQ. There are separate issues for each for any platforms which need expanded CQ coverage.

There is one remaining failure on Chrome OS, being tracked separately. Closing this out.

Sign in to add a comment