Issue metadata
Sign in to add a comment
|
NVDA reads "Window" and current tab title when navigating to toolbar/omnibox |
||||||||||||||||||||||
Issue descriptionSteps: 1. Launch Chrome with a page loaded, 2. Launch NVDA 3. Navigate to content 4. Press Ctrl+L What happens: NVDA begins reading "Window" and then the tab title. Expected: This is not read, as it is superfluous text. The user already knows they are in a window and it is not necessary to read the current document's title unless it changes. Note: Mick Curran says it's because we expose a ROLE_SYSTEM_WINDOW where this is usually reserved for MSAA/oleacc to represent actual HWNDs. He suggested we expose it like Firefox does. Firefox uses ROLE_SYSTEM_APPLICATION.
,
Dec 14 2017
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51332db43f73f7e9ef8d17cc00c10067a7a5c558 commit 51332db43f73f7e9ef8d17cc00c10067a7a5c558 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Thu Dec 14 17:38:40 2017 Do not expose ROLE_SYSTEM_WINDOW for our root object Do not return ROLE_SYSTEM_WINDOW ourselves as that is a special MSAA system role used to indicate a real native window object. It is automatically created by oleacc.dll as a parent of the root of our hierarchy, matching the HWND. For AX_ROLE_WINDOW, we should expose something similar to what Firefox exposes, namely ROLE_SYSTEM_APPLICATION. This helps NVDA not read superfluous text when the user navigates to the toolbar or location bar. Bug: 794931 Change-Id: I123f07cb477304da1f016d65ea8c2b23b7a92ef4 Reviewed-on: https://chromium-review.googlesource.com/826866 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#524102} [modify] https://crrev.com/51332db43f73f7e9ef8d17cc00c10067a7a5c558/ui/accessibility/platform/ax_platform_node_win.cc [modify] https://crrev.com/51332db43f73f7e9ef8d17cc00c10067a7a5c558/ui/views/accessibility/native_view_accessibility_win_unittest.cc
,
Dec 14 2017
,
Jan 9 2018
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7a61e40b89efd01a34d2692076abb84003ea760 commit f7a61e40b89efd01a34d2692076abb84003ea760 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Wed Jan 24 16:19:38 2018 Use best role for root accessible object Instead of using ROLE_SYSTEM_WINDOW or ROLE_SYSTEM_APPLICATION use ROLE_SYSTEM_PANE, an option that NVDA team suggested we try. This addresses the original issue ( crbug.com/794931 ) and the regression as well ( crbug.com/804049 ). Original issue was that NVDA would say "Window" and the window title when the user navigated to the location bar. Regression was the users could turn on forms mode in the location bar, as if it was content. Bug: 804049 , 794931 Change-Id: I95753cc1b4aa1ffc5e02902bdf309fcc8ccbff98 Reviewed-on: https://chromium-review.googlesource.com/881287 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#531545} [modify] https://crrev.com/f7a61e40b89efd01a34d2692076abb84003ea760/ui/accessibility/platform/ax_platform_node_win.cc [modify] https://crrev.com/f7a61e40b89efd01a34d2692076abb84003ea760/ui/views/accessibility/native_view_accessibility_win_unittest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aleventhal@chromium.org
, Dec 14 2017