Issue metadata
Sign in to add a comment
|
gn check: add support for include_dirs |
||||||||||||||||||||||
Issue descriptionFeature description: gn check assumes all include paths are relative to the source root. This is the case for most of Chromium code, however some parts of the tree (e.g. third_party) may use paths relative to some other point in the tree. Therefore gn check should search for include files in directories listed in the target's include_dirs list, same as the compiler does. Eng owner: brettw
,
Jan 11 2018
,
Jan 11 2018
,
Jan 11 2018
,
Jan 11 2018
The proposed CL appears to be https://chromium-review.googlesource.com/c/chromium/src/+/827014 .
,
Jan 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f14ea14de1ea4ffe82aaa9c01425e41f3625797 commit 2f14ea14de1ea4ffe82aaa9c01425e41f3625797 Author: Marcin Simonides <msimonides@opera.com> Date: Tue Jan 23 20:30:03 2018 Add support for include_dirs to gn check. With this change "gn check" no longer assumes all #include paths are relative to the source root. Instead it searches for the includes by checking each of the directories listed in include_dirs for the target. A number of new issues have been discovered. The trivial ones have been fixed, the larger and more complex ones have been reported and the related parts of the project have been excluded from the default gn check run. BUG= 794926 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I39c17a7ac47dc024dd374c8891ce4911809195cb Reviewed-on: https://chromium-review.googlesource.com/827014 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: David Reveman <reveman@chromium.org> Reviewed-by: Yuzhu Shen <yzshen@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Brett Wilson <brettw@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#531334} [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/.gn [add] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/build/BUILD.gn [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/build/buildflag_header.gni [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/cc/tiles/gpu_image_decode_cache.cc [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/chrome/app/BUILD.gn [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/components/omnibox/browser/BUILD.gn [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/components/toolbar/BUILD.gn [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/mojo/public/cpp/bindings/BUILD.gn [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/mojo/public/tools/bindings/mojom.gni [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/net/BUILD.gn [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/net/http/transport_security_state.cc [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/skia/BUILD.gn [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/third_party/WebKit/Source/platform/BUILD.gn [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/tools/gn/command_check.cc [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/tools/gn/header_checker.cc [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/tools/gn/header_checker.h [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/tools/gn/header_checker_unittest.cc [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/ui/gfx/geometry/mojo/BUILD.gn [modify] https://crrev.com/2f14ea14de1ea4ffe82aaa9c01425e41f3625797/url/mojo/BUILD.gn
,
Jan 24 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dpranke@chromium.org
, Dec 15 2017