New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794924 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in v8::internal::Invoke

Project Member Reported by ClusterFuzz, Dec 14 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6067463774273536

Job Type: linux_asan_chrome_mp
Crash Type: UNKNOWN WRITE
Crash Address: 0x000600000007
Crash State:
  v8::internal::Invoke
  v8::internal::Execution::Call
  v8::Script::Run
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=473072:473106

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6067463774273536

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 14 2017

Components: Blink>Bindings Blink>JavaScript
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Dec 14 2017

Labels: Test-Predator-Auto-Owner
Owner: nainar@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/f24a21c25dd45feb95fdf9bece7a589ab1126532 (Add class level comments to LayoutTreeBuilder).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 14 2017

Labels: M-63
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 14 2017

Labels: Pri-1

Comment 5 by cthomp@chromium.org, Dec 14 2017

Labels: OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows

Comment 6 by nainar@chromium.org, Dec 14 2017

Labels: Test-Predator-Wrong-CLs
Owner: ----
Status: Available (was: Assigned)

Comment 7 by cthomp@chromium.org, Dec 15 2017

Cc: mstarzinger@chromium.org
@mstartzinger: Since clusterfuzz failed to find the right culprit CL, could you take a look when you have a chance and find a good owner for this?
Project Member

Comment 8 by ClusterFuzz, Dec 15 2017

ClusterFuzz has detected this issue as fixed in range 524079:524080.

Detailed report: https://clusterfuzz.com/testcase?key=6067463774273536

Job Type: linux_asan_chrome_mp
Crash Type: UNKNOWN WRITE
Crash Address: 0x000600000007
Crash State:
  v8::internal::Invoke
  v8::internal::Execution::Call
  v8::Script::Run
  
Sanitizer: address (ASAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=473072:473106
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=524079:524080

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6067463774273536

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Comment 9 by cthomp@chromium.org, Dec 19 2017

Status: Untriaged (was: Available)
Marking this untriaged so the V8 sheriffs will see it in their queue. Can we confirm that this is fixed?
Cc: -mstarzinger@chromium.org
Owner: mstarzinger@chromium.org
Status: Fixed (was: Untriaged)
A bisect in standalone d8 confirms that this was introduced on Apr 11 (d98dfd8b9b68635c3b974e1d91be414304dec35c), and fixed on Dec 15 (4a7eec590c81a2f953ea5526d9c8731ac4042efb) by mstarzinger.
Project Member

Comment 11 by sheriffbot@chromium.org, Dec 19 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 12 by sheriffbot@chromium.org, Dec 21 2017

Labels: Merge-Request-64
Project Member

Comment 13 by sheriffbot@chromium.org, Dec 21 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Can you please indicate actually which CL needs to be merged for this? Merge-Request-64 was added by sherrifbot, but unclear which merge is actually needed.
https://chromium.googlesource.com/v8/v8/+/4a7eec590c81a2f953ea5526d9c8731ac4042efb is the CL in question, and yes, would be good to take this in 64.
Seems like a fairly large and critical change. Mstarzinger@ can you please comment for how this looks in Canary and if this well tested and safe merge overall? This has been in Canary for over 2 weeks now.
Cc: jarin@chromium.org
Labels: -Merge-Review-64 Merge-Approved-64
As mstarzinger@ is OOO, can you please merge this jarin@?
Please merge the approved cl(s) to M64 release branch 3282 as soon as possible.
Labels: -Merge-Approved-64 merge-merged-6.4
Has already been merged (see  issue 794394  and  issue 786723 ), thanks Jaro.
Labels: Release-0-M64
Cc: pelizzi@google.com
Project Member

Comment 22 by sheriffbot@chromium.org, Mar 27 2018

Labels: -M-63 M-65
Project Member

Comment 23 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment