New issue
Advanced search Search tips

Issue 794921 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in sk_sp<SkTextBlob>::get

Project Member Reported by ClusterFuzz, Dec 14 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6018924067160064

Fuzzer: libFuzzer_paint_op_buffer_eq_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000008
Crash State:
  sk_sp<SkTextBlob>::get
  ()
  paint_op_buffer_eq_fuzzer.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=523883:523911

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6018924067160064

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Dec 14 2017

Components: Internals>Compositing Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Dec 14 2017

Labels: Test-Predator-Auto-Owner
Owner: vmp...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/7273cfe05dcb33f6abb7626457b5b6d36cbea31c (oop: Use TransferCache for PaintTypeface serialization and transport.).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 3 by vmp...@chromium.org, Dec 14 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af62bb3aab9dd4292ae34750b4e6ca60dd0f032f

commit af62bb3aab9dd4292ae34750b4e6ca60dd0f032f
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Thu Dec 14 19:58:40 2017

oop: Fix nullptr dereference in a fuzz test case.

This patch does two things:
- Binds the test context to the thread, avoiding a dcheck
- Ensures to mark the reader as invalid if we couldn't read textblob
  data

R=ericrk@chromium.org

Bug:  794921 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I1cdf8a0c5571587b0d3a66f1a25d99ed5e3daed9
Reviewed-on: https://chromium-review.googlesource.com/827506
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524152}
[modify] https://crrev.com/af62bb3aab9dd4292ae34750b4e6ca60dd0f032f/cc/paint/paint_op_buffer_fuzzer.cc
[modify] https://crrev.com/af62bb3aab9dd4292ae34750b4e6ca60dd0f032f/cc/paint/paint_op_reader.cc

Comment 5 by vmp...@chromium.org, Dec 14 2017

Status: Fixed (was: Started)
Project Member

Comment 6 by ClusterFuzz, Dec 15 2017

ClusterFuzz has detected this issue as fixed in range 524141:524160.

Detailed report: https://clusterfuzz.com/testcase?key=6018924067160064

Fuzzer: libFuzzer_paint_op_buffer_eq_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000008
Crash State:
  sk_sp<SkTextBlob>::get
  ()
  paint_op_buffer_eq_fuzzer.cc
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=523883:523911
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=524141:524160

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6018924067160064

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Dec 15 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6018924067160064 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment