Avoid mutation of FLAG_runtime_stats flag |
|
Issue descriptionCurrently the tracing category observer mutates the global FLAG_runtime_stats flag: https://cs.chromium.org/chromium/src/v8/src/tracing/tracing-category-observer.cc?rcl=111e990462823c9faeee06b67c0dcf05749d4da8&l=40 This not thread-safe and breaks if multiple V8 isolates run in the same process and use tracing. We should make the flag per isolate.
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/6fad0eca0fc4eb56fbb5dd9ab9bb68704da2a65a commit 6fad0eca0fc4eb56fbb5dd9ab9bb68704da2a65a Author: Michael Achenbach <machenbach@chromium.org> Date: Thu Dec 14 14:24:06 2017 [test] Skip flaky test under tsan NOTRY=true TBR=ulan@chromium.org Bug: chromium:794911 Change-Id: Ib7be4b44f796153d3972afc878a8ec4911327576 Reviewed-on: https://chromium-review.googlesource.com/827067 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50111} [modify] https://crrev.com/6fad0eca0fc4eb56fbb5dd9ab9bb68704da2a65a/test/cctest/cctest.status
,
Dec 19 2017
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/42ac7fe04bc675fd5d3a620d82e7208d19099e16 commit 42ac7fe04bc675fd5d3a620d82e7208d19099e16 Author: Ulan Degenbaev <ulan@chromium.org> Date: Tue Dec 19 19:01:50 2017 [runtime] Make access to FLAG_runtime_stats atomic. Background tasks read this flag, which creates a data race. This patch works around the data races by making the access to the flag atomic. The actual fix will be to not mutate the flag. Bug: chromium:794911 Change-Id: Idcf03b7a1037e876036918418ce989b420784428 Reviewed-on: https://chromium-review.googlesource.com/834508 Reviewed-by: Fadi Meawad <fmeawad@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#50215} [modify] https://crrev.com/42ac7fe04bc675fd5d3a620d82e7208d19099e16/src/counters-inl.h [modify] https://crrev.com/42ac7fe04bc675fd5d3a620d82e7208d19099e16/src/heap/gc-tracer.cc [modify] https://crrev.com/42ac7fe04bc675fd5d3a620d82e7208d19099e16/src/tracing/tracing-category-observer.cc [modify] https://crrev.com/42ac7fe04bc675fd5d3a620d82e7208d19099e16/test/unittests/counters-unittest.cc |
|
►
Sign in to add a comment |
|
Comment 1 by u...@chromium.org
, Dec 14 2017