Issue metadata
Sign in to add a comment
|
Regression:X/0 is not clearly visible on extension Tic Tac Toe
Reported by
pranjali...@etouch.net,
Dec 14 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version:63.0.3239.108 (Official Build) d2626860fae283daee484943e6820af18fc73fd9-refs/branch-heads/3239@{#676} OS:Mac(10.12.6,10.13.2) Test URL:https://chrome.google.com/webstore/detail/tic-tac-toe/jjdpdpackpoaaccjmnkmgloibjgpklmm?utm_source=chrome-ntp-icon Steps to reproduce: 1.Launch Chrome and go to above URL and install extension. 2.Click on extension icon on omnibox ,play game and observe. Actual Result:X/0 is not clearly visible on extension tic tac toe Expected Result:X/0 should be clearly visible on extension tic tac toe This is a regression issue, broken in M-62 series, Using the per-revision bisect providing the bisect results, Good bUild: 62.0.3173.0 Bad Build: 62.0.3174.0 You are probably looking for a change made after 491019 (known good), but no later than 491020 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/5365b5a15d07b4987fb9ba18af670865f45b9eec..91148fff3d12c015f99d739070a826dcb78437ec Suspect:https://chromium.googlesource.com/chromium/src/+/5365b5a15d07b4987fb9ba18af670865f45b9eec csharrison@:Kindly help to reassign, if your changes are not related to this issue.
,
Dec 15 2017
ccing robertphillips@, jvanverth@ as there are few changes related to blur and draw in the CL: https://chromium.googlesource.com/chromium/src/+log/5365b5a15d07b4987fb9ba18af670865f45b9eec..91148fff3d12c015f99d739070a826dcb78437ec https://skia.googlesource.com/skia.git/+/49f58a3825ca7f7745d7f311baa2b65c5eb46c02 https://skia.googlesource.com/skia.git/+/1af03d4396a9567e3ca127830676eb4fd5a76266 robertphillips@, jvanverth@ could you please check and help.
,
Dec 15 2017
robertphillips@ is on vacation. However, I don't see how this is related to either of our changes. Rob's change only adds asserts. My change fixes SkPicture bounds for shadows, which Chrome doesn't use. I disabled GPU rasterization and accelerated Canvas and it still happens, so I don't think it's in the Skia GPU code. I reverted the only other change that looks related, by ccameron@, and the bug still happens. It doesn't look to me like the issue was introduced in this roll.
,
Dec 15 2017
I don't think this is an extensions issue (we don't do anything special with the DOM color in popups). Maybe Blink>Paint is the right label here?
,
Dec 18 2017
Mac only, so I suspect HighDPI something.
,
Jan 16 2018
Verified Mac only. How do we debug an extension? Changing the component to get an answer. The issue is the background color/blending on the squares. On Mac they come out much darker compared to other platforms. I'll re-run the bisect.
,
Jan 16 2018
The issue is that the disabled button is using theme provided transparency so its background no longer obscrues the table background.
,
Jan 16 2018
https://chromium.googlesource.com/chromium/src/+/16d7a50a904b8507aad24235aedfea55dfdeedcc This was a deliberate change, so WontFix. For background, the extension has a table with a blue water background image. Each table entry, for a cell in the 3x3 tic-tac-toe board, is a button that gets disabled when the user or computer selects that board position. The disabled button colors were changed to better match the OS, which now results in the extension drawing a letter using a bluish-grey font color against a blue-ish grey background. Fixing this would require reverting the color changes to the button form, which is a no-go. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by csharrison@chromium.org
, Dec 14 2017Owner: ----
Status: Untriaged (was: Assigned)