New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794886 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug
M65



Sign in to add a comment

When dragging a multi-selection of bookmarks (in the manager) to a position higher, the order of the selected bookmarks reverses

Reported by smith.ma...@gmail.com, Dec 14 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36

Steps to reproduce the problem:
1. Open the Bookmark manager (Ctrl + Shift + O)
2. Be in a folder with 3 or more bookmarks
3. Select more than 1 bookmark
4. With the mouse, drag the selection to a higher position
5. Dropping the selection moves the selected bookmarks, but they are now in reverse order

What is the expected behavior?
The bookmarks should stay in the same order regardless of how the selection is moved.

What went wrong?
I moved a selection of bookmarks to a lower position without any odd behaviour, but when I moved another selection to a higher position the order of the bookmarks within the selection reversed.

Did this work before? Yes 62

Chrome version: 63.0.3239.84  Channel: stable
OS Version: 6.3
Flash Version:
 
Labels: Needs-Triage-M63 Needs-Bisect
Able to reproduce this issue on reported chrome version 63.0.3239.84 and latest Canary 65.0.3293.0 with steps mentioned in Comment#0

As this issue is seen from introduction of Material Design on Bookmarks from M62, Hence considering this issue as Non-Regression and marking it as Untriaged

Could someone from UI>Browser>Bookmarks take a look at this isue

Thanks!
Cc: viswatej...@techmahindra.com sc00335...@techmahindra.com
Components: -UI UI>Browser>Bookmarks
Labels: -Needs-Bisect -Type-Bug-Regression Triaged-ET M65 OS-Linux OS-Mac Type-Bug
Status: Untriaged (was: Unconfirmed)
Status: Archived (was: Untriaged)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Comment 6 Deleted

 Issue 884114  has been merged into this issue.
Components: UI>Browser>WebUI
Labels: Proj-MaterialDesign-WebUI
Status: Untriaged (was: Archived)
Cc: calamity@chromium.org
Components: -UI>Browser>WebUI
Cc: jbanavatu@chromium.org
Labels: Hotlist-DesktopUIChecked
Status: WontFix (was: Untriaged)
**UI Mass Triage**

We were unable to reproduce this bug. If this bug still reproduces for you, 
please reopen or file a new issue.

Thanks!

Labels: Hotlist-GoodFirstBug
Status: Available (was: WontFix)
This still repros
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49e85eeff6bf48202ffc276e820e0be795bcf5da

commit 49e85eeff6bf48202ffc276e820e0be795bcf5da
Author: Maggie Cai <mxcai@chromium.org>
Date: Mon Dec 03 06:10:17 2018

Fix an ordering issue with dragging multiple selected bookmarks.

When dragging a multi-selection of bookmarks in the manager, the order
of the selected bookmarks became the order of the selection instead of
their original displaying order.

This CL updates the order of dragged nodes to the displaying order.

BUG= 794886 

Change-Id: I4ab3ead0454874eee9e7dc49522156aba27f10d4
Reviewed-on: https://chromium-review.googlesource.com/c/1349130
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613009}
[modify] https://crrev.com/49e85eeff6bf48202ffc276e820e0be795bcf5da/chrome/browser/resources/md_bookmarks/dnd_manager.js
[modify] https://crrev.com/49e85eeff6bf48202ffc276e820e0be795bcf5da/chrome/browser/resources/md_bookmarks/list.js

Cc: phanindra.mandapaka@chromium.org
Labels: TE-Verified-M73 TE-Verified-73.0.3630.0
Able to reproduce this issue on Mac 10.14.0, Windows 10 and Ubuntu 17.10 on the reported version 63.0.3239.84 and the issue is fixed on the latest M-73 build 73.0.3630.0.

1. Launched Chrome 
2. Created bookmark folder and added five bookmarks to the folder
3. Selected and dragged and dropped to higher position
As we have observed that the bookmarks stay in the same order.

Hence adding TE verified labels as the issue is working as expected.

Thanks..!
794886.mp4
1000 KB View Download
Owner: mxcai@chromium.org
Status: Verified (was: Available)

Sign in to add a comment