Remove the argument limit for optimizable functions
Reported by
manjian2...@gmail.com,
Dec 14 2017
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36 Steps to reproduce the problem: 1. Open https://testdrive-archive.azurewebsites.net/Performance/FishIETank/Default.html 2. Open chrome://tracing 3. Click Record 4. Select v8.runtime and v8.runtime_stats 5. Click Record 6. Will find plenty of Builtin_HandleApiCall in the v8.callFunction children. What is the expected behavior? No Builtin_HandleApiCall involved. What went wrong? class CallApiCallbackStub : public PlatformCodeStub { public: static const int kArgBits = 3; static const int kArgMax = (1 << kArgBits) - 1; Make kArgsMax equals to 7.But drawImage call in Default.html:308 has 9 arguments. Did this work before? N/A Chrome version: 63.0.3239.84 Channel: stable OS Version: Flash Version:
,
Dec 15 2017
Unable to reproduce this issue on reported version 63.0.3239.84 using Ubuntu 14.04 with steps mentioned below. 1. Launched chrome and navigated to https://testdrive-archive.azurewebsites.net/Performance/FishIETank/Default.html 2. Navigated to chrome://tracing, Clicked record and selected v8.runtime and v8.runtime_stats and recorded trace 3. Did not observe any Builtin_HandleApiCall in both chrome://tracing and also on saved trace file. Attaching trace file for reference. @Reporter: Please let us know if we miss anything from steps, also check the attached file and let us know where to see Builtin_HandleApiCall. This would help in further triaging of the issue. Thanks!
,
Dec 15 2017
Okay. I forget to add one step.See the new steps. 1. Open https://testdrive-archive.azurewebsites.net/Performance/FishIETank/Default.html 2. Open chrome://tracing 3. Click Record 4. Select v8.runtime and v8.runtime_stats 5. Click Record 6. Click back the test drive tab. 7. Will find plenty of Builtin_HandleApiCall in the v8.callFunction children.
,
Dec 15 2017
Like this
,
Dec 15 2017
Thank you for providing more feedback. Adding requester "sc00335628@techmahindra.com" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 28 2017
Unable to reproduce this issue as we are seeing V8.execute only and unable to see V8.Builtin_HandleApiCall after recording the trace. @Reporter: If possible please attach the trace log here. Also could you please guide us with a video to reproduce the issue. And also could you please let us know on which flavour of Linux you are seeing this issue. This would help in debugging of issue further.
,
Dec 28 2017
I think you may forget to select v8.runtime and v8.runtime_stats column. 1. Open https://testdrive-archive.azurewebsites.net/Performance/FishIETank/Default.html 2. Open chrome://tracing 3. Click Record 4. Select "Javascript and rendering" 5. Click "Edit categories" 6. Select v8.runtime and v8.runtime_stats 7. Click Record 8. Click back the test drive tab. 9. Will find plenty of Builtin_HandleApiCall in the v8.callFunction children
,
Dec 28 2017
Thank you for providing more feedback. Adding requester "sc00335628@techmahindra.com" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 2 2018
,
Jan 3 2018
Thanks for the report and the suggestion. Bumping the kArgBits to 7 makes total sense.
,
Jan 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/ca16cc23377ce0cdc32973a713a62ef03f806c1b commit ca16cc23377ce0cdc32973a713a62ef03f806c1b Author: Benedikt Meurer <bmeurer@chromium.org> Date: Wed Jan 03 09:29:02 2018 [turbofan] Bump CallApiCallbackStub::kArgBits to 7. This allows TurboFan to inline API function calls with more than 7 parameters. It's now possible to inline API function calls with up to 127 parameters, which should be sufficiently large. Bug: chromium:794865 Change-Id: I974fed740cd3506d0b8d75ed922227364c51a1fb Reviewed-on: https://chromium-review.googlesource.com/848712 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50335} [modify] https://crrev.com/ca16cc23377ce0cdc32973a713a62ef03f806c1b/src/code-stubs.h
,
Jan 3 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dtapu...@chromium.org
, Dec 14 2017