New issue
Advanced search Search tips

Issue 794864 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

PasswordManagerBrowserTestBase.HttpMigratedCredentialAutofilled randomly failed

Project Member Reported by brat...@opera.com, Dec 14 2017

Issue description

This is mostly to track a randomly failed testcase.

In https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_asan_rel_ng/510892

PasswordManagerBrowserTestBase.HttpMigratedCredentialAutofilled failed

The test and console output:

LogDog : chromium/bb/tryserver.chromium.linux/linux_chromium_asan_rel_ng/510892/+/recipes/steps/browser_tests__with_patch_/0/logs/PasswordManagerBrowserTestBase.HttpMigratedCredentialAutofilled/0
Sign in
WRAP
[ RUN      ] PasswordManagerBrowserTestBase.HttpMigratedCredentialAutofilled
Xlib:  extension "RANDR" missing on display ":99".
[3255:3255:1213/144356.231973:ERROR:settings_provider_gsettings.cc(38)] Unable to create a gsettings client - setting button layout to default
[3255:3347:1213/144356.603599:ERROR:bus.cc(394)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[3255:3255:1213/144356.667074:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[3341:3341:1213/144356.787347:WARNING:gpu_info.cc(104)] No active GPU found, returning primary GPU.
[3255:3326:1213/144357.323191:WARNING:simple_synchronous_entry.cc(1170)] Could not open platform files for entry.
[3255:3255:1213/144357.977422:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.977589:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.977705:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.977810:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.977903:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.977988:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.978080:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.978162:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.978274:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.978357:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.978428:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.978510:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.978595:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.978683:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.978761:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.978873:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.978958:ERROR:test_password_store.cc(203)] Not implemented reached in virtual std::vector<InteractionsStats> password_manager::TestPasswordStore::GetSiteStatsImpl(const GURL &)
[3255:3255:1213/144357.982576:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.982687:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.982813:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.982965:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.983162:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.983363:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.983565:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.983738:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.983918:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.984070:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.984223:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.984427:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.984558:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.984689:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.984864:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.985022:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.985183:ERROR:test_password_store.cc(143)] Not implemented reached in virtual std::vector<std::unique_ptr<autofill::PasswordForm> > password_manager::TestPasswordStore::FillLoginsForSameOrganizationName(const std::string &)
[3255:3255:1213/144357.991237:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144357.992822:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144357.994050:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144357.996973:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144357.998551:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144357.999716:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.001648:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.002875:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.004467:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.005644:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.006821:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.008379:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "new-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.010028:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "new-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.011252:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.012413:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "new-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.013629:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "new-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.014763:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.015904:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "new-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.017083:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "new-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.018266:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "new-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.019404:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.024399:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "new-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3255:1213/144358.025832:INFO:CONSOLE(0)] "[DOM] Input elements should have autocomplete attributes (suggested: "current-password"): (More info: https://goo.gl/9p2vKq) %o", source: https://127.0.0.1:48588/password/password_form.html (0)
[3255:3383:1213/144358.545613:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico
../../chrome/browser/password_manager/password_manager_test_base.cc:610: Failure
Expected equality of these values:
  expected_value
    Which is: "12345"
  return_value
    Which is: ""
element_id = password_field

 

Comment 1 by kolos@chromium.org, Jan 9 2018

Cc: jdoerrie@chromium.org
Owner: vasi...@chromium.org
Status: Assigned (was: Untriaged)
adding folks you worked with this test.

Comment 2 by dvadym@chromium.org, Jan 10 2018

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: dvadym@chromium.org
I'm working on fixing flakiness related to field gatekeepers (that's a case here), so I'll fix this bug. I need this to land my CL https://chromium-review.googlesource.com/c/chromium/src/+/850394
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c699a46e57eacade17fd21b6ac9489a2d35f0f50

commit c699a46e57eacade17fd21b6ac9489a2d35f0f50
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Wed Jan 10 16:42:04 2018

Fix flakiness in PasswordManagerBrowserTestBase.

Password Manager doesn't reveal password till user gesture to JavaScript.
In PasswordManagerBrowserTestBase JS scripts are used for checking values
of password fields. So as result there is a race condition between
executing js for checking password values and PasswordManager which reveals
password after user gesture simulation. It leads to flakiness. This CL
fixes that by introducing waiting for password values in that places
where it was not done before (in many other places it was implemented
earlier).

Bug:  794864 ,  799924 
Change-Id: I664472e17a04b8dd421522aa948c058892bd0ac5
Reviewed-on: https://chromium-review.googlesource.com/859960
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528340}
[modify] https://crrev.com/c699a46e57eacade17fd21b6ac9489a2d35f0f50/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/c699a46e57eacade17fd21b6ac9489a2d35f0f50/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/c699a46e57eacade17fd21b6ac9489a2d35f0f50/chrome/browser/password_manager/password_manager_test_base.h

Comment 4 by dvadym@chromium.org, Jan 12 2018

Status: Fixed (was: Assigned)

Sign in to add a comment