New issue
Advanced search Search tips

Issue 794837 link

Starred by 1 user
Status: Fixed
Owner:
nhiroki@chromium.org
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Move modules/fetch to core/fetch or core/loader/fetch

Project Member Reported by nhiroki@chromium.org, Dec 14 2017 
How about moving modules/fetch to core/fetch or core/loader/fetch for making it available from core/? IMHO, fetch is a primitive mechanism and should be widely available in Blink.

For example, core/workers/WorkletOptions.idl needs "enum RequestCredentials" defined in modules/fetch/Request.idl, but it's not feasible because of core-modules boundary. As a stopgap, I copied "enum RequestCredentials" to WorkletOptions.idl. This wouldn't be good in terms of code hygiene...

Comment 1 by yhirano@chromium.org, Dec 14 2017 

It depends on modules/credentialmanager and public/platform/modules/serviceworker.

Comment 2 by nhiroki@chromium.org, Dec 14 2017 

Does it still depend on modules/credentialmanager? I saw it in modules/fetch/DEPS but didn't find explicit "#include" in the directory. I guess some enum for credentials was used before and mojofication removed it...?
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f5a3229b924e46218480570fc7b2dcf27b01ee2

commit 4f5a3229b924e46218480570fc7b2dcf27b01ee2
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Dec 14 06:56:57 2017

Fetch: Remove dependency on modules/credentialmanager

Bug:  794837 
Change-Id: I429e94757e3d486b32c1ec204ed027f18f0ae1e5
Reviewed-on: https://chromium-review.googlesource.com/826830
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524015}
[modify] https://crrev.com/4f5a3229b924e46218480570fc7b2dcf27b01ee2/third_party/WebKit/Source/modules/fetch/DEPS

Comment 4 by yhirano@chromium.org, Dec 15 2017

Owner: nhiroki@chromium.org
Status: Assigned (was: Untriaged)
We talked internally, and the conclusion was there was no problem.

Comment 5 by nhiroki@chromium.org, Dec 19 2017

Cc: nhiroki@chromium.org
Owner: ----
Status: Available (was: Assigned)
Summary: Move modules/fetch to core/fetch or core/loader/fetch (was: PROPOSAL: Move modules/fetch to core/fetch or core/loader/fetch)
yhirano@: Thank you for building a consensus.

Let me release this issue because I'll be on leave mostly 2018Q1.
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a16ddefeb951d87636d8efd4bff0a546093a9ef4

commit a16ddefeb951d87636d8efd4bff0a546093a9ef4
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Thu Dec 21 06:16:28 2017

WATCHLISTS: Fix references that point to nonexistent core/fetch directory

Bug:  794837 
Change-Id: I2d507f5ab4b20570cd05546cbb83527ed2372db9
Reviewed-on: https://chromium-review.googlesource.com/838920
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525630}
[modify] https://crrev.com/a16ddefeb951d87636d8efd4bff0a546093a9ef4/WATCHLISTS
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03e051c3c41edbdc77c61a3827d35934a86e5c68

commit 03e051c3c41edbdc77c61a3827d35934a86e5c68
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Fri Dec 22 12:09:18 2017

Fetch: Move modules/fetch to core/fetch (1)

This CL moves a part of files in modules/fetch to core/fetch.

Fetch is a primitive mechanism and should be available in core/. See the issue
for a use case.

Bug:  794837 
Change-Id: I1b08dbbaf50513760b698d4542e774c0e906134b
Reviewed-on: https://chromium-review.googlesource.com/841903
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525976}
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/core_idl_files.gni
[add] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/BUILD.gn
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/BlobBytesConsumer.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/BlobBytesConsumer.h
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/BlobBytesConsumerTest.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/Body.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/Body.h
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/Body.idl
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/BodyStreamBuffer.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/BodyStreamBuffer.h
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/BodyStreamBufferTest.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/BytesConsumer.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/BytesConsumer.h
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/BytesConsumerForDataConsumerHandle.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/BytesConsumerForDataConsumerHandle.h
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/BytesConsumerForDataConsumerHandleTest.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/BytesConsumerTest.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/BytesConsumerTestUtil.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/BytesConsumerTestUtil.h
[add] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/DEPS
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/DataConsumerHandleTestUtil.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/DataConsumerHandleTestUtil.h
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/FetchDataLoader.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/FetchDataLoader.h
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/FetchDataLoaderTest.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/FormDataBytesConsumer.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/FormDataBytesConsumer.h
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/FormDataBytesConsumerTest.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/MultipartParser.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/MultipartParser.h
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/MultipartParserTest.cpp
[add] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/OWNERS
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/ReadableStreamBytesConsumer.cpp
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/ReadableStreamBytesConsumer.h
[rename] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/core/fetch/ReadableStreamBytesConsumerTest.cpp
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/fetch/BUILD.gn
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/fetch/Request.cpp
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/fetch/Request.h
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/fetch/RequestInit.cpp
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/fetch/Response.cpp
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/fetch/Response.h
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
[modify] https://crrev.com/03e051c3c41edbdc77c61a3827d35934a86e5c68/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/686dd85ea6f2b2246798356efd2df3bd6fddf7a2

commit 686dd85ea6f2b2246798356efd2df3bd6fddf7a2
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Fri Dec 22 22:38:40 2017

Fetch: Move modules/fetch to core/fetch (2)

This CL moves a part of files in modules/fetch to core/fetch.

Fetch is a primitive mechanism and should be available in core/. See the issue
for a use case.

Previous CLs:
(1) https://chromium-review.googlesource.com/c/chromium/src/+/841903

Bug:  794837 
Change-Id: Ice42e2a201b9c6833232c94daa049550ce29e3ac
Reviewed-on: https://chromium-review.googlesource.com/842383
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526077}
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/bindings/modules/v8/generated.gni
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/core/fetch/BUILD.gn
[rename] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/core/fetch/FetchHeaderList.cpp
[rename] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/core/fetch/FetchHeaderList.h
[rename] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/core/fetch/FetchHeaderListTest.cpp
[rename] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/core/fetch/Headers.cpp
[rename] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/core/fetch/Headers.h
[rename] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/core/fetch/Headers.idl
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/modules/fetch/BUILD.gn
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/modules/fetch/Request.h
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/modules/fetch/RequestInit.cpp
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/modules/fetch/RequestInit.h
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/modules/fetch/Response.h
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/686dd85ea6f2b2246798356efd2df3bd6fddf7a2/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp

Comment 9 by nhiroki@chromium.org, Dec 23 2017

Cc: -nhiroki@chromium.org
Owner: nhiroki@chromium.org
Status: Started (was: Available)
REG C#5:

> Let me release this issue because I'll be on leave mostly 2018Q1.

Maybe I can finish this work before the leave :)
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7eb8641796c8137febde0f75fd39526a4c95778

commit b7eb8641796c8137febde0f75fd39526a4c95778
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Sat Dec 23 02:35:17 2017

Fetch: Move modules/fetch to core/fetch (3)

This CL moves a part of files in modules/fetch to core/fetch.

Fetch is a primitive mechanism and should be available in core/. See the issue
for a use case.

Diffs other than simple move:
- This CL adds CORE_EXPORT to FetchManager so that GlobalFetch under
  modules/fetch can access it.
- This CL removes core/workers/RequestCredentials.idl in favor of enum
  RequestCredentials defined in Request.idl.

Previous CLs:
(1) https://chromium-review.googlesource.com/c/chromium/src/+/841903
(2) https://chromium-review.googlesource.com/c/chromium/src/+/842383

Bug:  794837 
Change-Id: I8e0bc98f473ffad6febc35e6403c02aaee647597
Reviewed-on: https://chromium-review.googlesource.com/842602
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526132}
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/bindings/modules/v8/generated.gni
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/BUILD.gn
[add] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/FetchManager.cpp
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/FetchManager.h
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/FetchRequestData.cpp
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/FetchRequestData.h
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/FetchResponseData.cpp
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/FetchResponseData.h
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/FetchResponseDataTest.cpp
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/Request.cpp
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/Request.h
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/Request.idl
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/RequestInit.cpp
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/RequestInit.h
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/RequestTest.cpp
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/Response.cpp
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/Response.h
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/Response.idl
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/ResponseInit.idl
[rename] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/ResponseTest.cpp
[delete] https://crrev.com/4cadeca003cbfa3071ec8cbb817c16355878ad9a/third_party/WebKit/Source/core/workers/RequestCredentials.idl
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFetch.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManagerTest.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledFetch.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/fetch/BUILD.gn
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/fetch/GlobalFetch.h
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/fetch/testing/InternalsFetch.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/fetch/testing/WorkerInternalsFetch.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
[modify] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cffad5c58e09bbe20c2aba3c8653364a49f516a

commit 0cffad5c58e09bbe20c2aba3c8653364a49f516a
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Sat Dec 23 03:48:23 2017

Revert "Fetch: Move modules/fetch to core/fetch (3)"

This reverts commit b7eb8641796c8137febde0f75fd39526a4c95778.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 526132 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2I3ZWI4NjQxNzk2YzgxMzdmZWJkZTBmNzVmZDM5NTI2YTRjOTU3NzgM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Linux%20x64/55539

Original change's description:
> Fetch: Move modules/fetch to core/fetch (3)
> 
> This CL moves a part of files in modules/fetch to core/fetch.
> 
> Fetch is a primitive mechanism and should be available in core/. See the issue
> for a use case.
> 
> Diffs other than simple move:
> - This CL adds CORE_EXPORT to FetchManager so that GlobalFetch under
>   modules/fetch can access it.
> - This CL removes core/workers/RequestCredentials.idl in favor of enum
>   RequestCredentials defined in Request.idl.
> 
> Previous CLs:
> (1) https://chromium-review.googlesource.com/c/chromium/src/+/841903
> (2) https://chromium-review.googlesource.com/c/chromium/src/+/842383
> 
> Bug:  794837 
> Change-Id: I8e0bc98f473ffad6febc35e6403c02aaee647597
> Reviewed-on: https://chromium-review.googlesource.com/842602
> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#526132}

Change-Id: Ifa77a4acaf5c8803c8e087567516bd55db5394ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  794837 
Reviewed-on: https://chromium-review.googlesource.com/843716
Cr-Commit-Position: refs/heads/master@{#526133}
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/bindings/modules/v8/generated.gni
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/core/fetch/BUILD.gn
[delete] https://crrev.com/b7eb8641796c8137febde0f75fd39526a4c95778/third_party/WebKit/Source/core/fetch/FetchManager.cpp
[add] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/core/workers/RequestCredentials.idl
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFetch.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManagerTest.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledFetch.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/BUILD.gn
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/FetchManager.h
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/FetchRequestData.cpp
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/FetchRequestData.h
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/FetchResponseData.h
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/GlobalFetch.h
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/Request.cpp
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/Request.h
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/Request.idl
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/RequestInit.cpp
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/RequestInit.h
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/RequestTest.cpp
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/Response.cpp
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/Response.h
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/Response.idl
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/ResponseInit.idl
[rename] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/testing/InternalsFetch.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/fetch/testing/WorkerInternalsFetch.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
[modify] https://crrev.com/0cffad5c58e09bbe20c2aba3c8653364a49f516a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp
Project Member

Comment 12 by bugdroid1@chromium.org, Dec 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f2e516e8065218bfa63a15e296f7cd669f9abf0

commit 1f2e516e8065218bfa63a15e296f7cd669f9abf0
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Sat Dec 23 14:24:36 2017

(Retry) Fetch: Move modules/fetch to core/fetch (3)

The original CL was reverted by the following CL because of compile failures:
https://chromium-review.googlesource.com/c/chromium/src/+/843716

To fix the failures, this CL removes an unnecessary file under modules/fetch
(FetchManager.cpp) and fixes header include path in CacheTest.cpp in addition to
the original CL.

===== Original CL description =====

This CL moves a part of files in modules/fetch to core/fetch.

Fetch is a primitive mechanism and should be available in core/. See the issue
for a use case.

Diffs other than simple move:
- This CL adds CORE_EXPORT to FetchManager so that GlobalFetch under
  modules/fetch can access it.
- This CL removes core/workers/RequestCredentials.idl in favor of enum
  RequestCredentials defined in Request.idl.

Previous CLs:
(1) https://chromium-review.googlesource.com/c/chromium/src/+/841903
(2) https://chromium-review.googlesource.com/c/chromium/src/+/842383

Bug:  794837 
Change-Id: I4924de7e127eb47f04ec81a104a70139c8fd1c10
Reviewed-on: https://chromium-review.googlesource.com/843994
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526149}
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/bindings/modules/v8/generated.gni
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/bindings/modules/v8/wasm/WasmResponseExtensions.cpp
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/BUILD.gn
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/FetchManager.cpp
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/FetchManager.h
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/FetchRequestData.cpp
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/FetchRequestData.h
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/FetchResponseData.cpp
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/FetchResponseData.h
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/FetchResponseDataTest.cpp
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/Request.cpp
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/Request.h
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/Request.idl
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/RequestInit.cpp
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/RequestInit.h
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/RequestTest.cpp
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/Response.cpp
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/Response.h
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/Response.idl
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/ResponseInit.idl
[rename] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/core/fetch/ResponseTest.cpp
[delete] https://crrev.com/a33645421b4cc782e897b35568c921aed4232526/third_party/WebKit/Source/core/workers/RequestCredentials.idl
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFailEvent.cpp
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchFetch.cpp
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManager.cpp
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchManagerTest.cpp
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchSettledFetch.cpp
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchedEvent.cpp
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/fetch/BUILD.gn
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/fetch/GlobalFetch.h
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/fetch/testing/InternalsFetch.cpp
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/fetch/testing/WorkerInternalsFetch.cpp
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
[modify] https://crrev.com/1f2e516e8065218bfa63a15e296f7cd669f9abf0/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72af339043d6c0f552bcd163c9efe5d624fb88f7

commit 72af339043d6c0f552bcd163c9efe5d624fb88f7
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Mon Dec 25 07:25:32 2017

Worker: Implement Request::ParseCredentialsMode() for removing duplicate code

This CL implements Request::ParseCredentialsMode() in order to remove duplicate
code among Request, DedicatedWorkerMessagingProxy and Worklet.

Bug:  794837 
Change-Id: Ib20e4699e62b1bb0e536810c98fa8d803ae3d870
Reviewed-on: https://chromium-review.googlesource.com/844039
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526170}
[modify] https://crrev.com/72af339043d6c0f552bcd163c9efe5d624fb88f7/third_party/WebKit/Source/core/fetch/Request.cpp
[modify] https://crrev.com/72af339043d6c0f552bcd163c9efe5d624fb88f7/third_party/WebKit/Source/core/fetch/Request.h
[modify] https://crrev.com/72af339043d6c0f552bcd163c9efe5d624fb88f7/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.cpp
[modify] https://crrev.com/72af339043d6c0f552bcd163c9efe5d624fb88f7/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxy.h
[modify] https://crrev.com/72af339043d6c0f552bcd163c9efe5d624fb88f7/third_party/WebKit/Source/core/workers/Worklet.cpp
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bee3ecf18f743a81d9fa1ffd76859152250e8da7

commit bee3ecf18f743a81d9fa1ffd76859152250e8da7
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Mon Dec 25 12:35:53 2017

Fetch: Move modules/fetch to core/fetch (4)

This final CL moves the remaining files in modules/fetch to core/fetch, and
removes core/fetch directory.

Background of these changes: Fetch is a primitive mechanism and should be
available in core/. See the issue for a use case.

Previous CLs:
(1) https://chromium-review.googlesource.com/c/chromium/src/+/841903
(2) https://chromium-review.googlesource.com/c/chromium/src/+/842383
(3) https://chromium-review.googlesource.com/c/chromium/src/+/843994

Bug:  794837 
Change-Id: I3424d3adc1ea6cd62af859eb57c345da4e794b44
Reviewed-on: https://chromium-review.googlesource.com/844034
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526174}
[modify] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/core/fetch/BUILD.gn
[rename] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/core/fetch/GlobalFetch.cpp
[rename] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/core/fetch/GlobalFetch.h
[rename] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/core/fetch/WindowFetch.idl
[rename] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/core/fetch/WorkerFetch.idl
[rename] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/core/fetch/testing/InternalsFetch.cpp
[rename] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/core/fetch/testing/InternalsFetch.h
[rename] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/core/fetch/testing/InternalsFetch.idl
[rename] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/core/fetch/testing/WorkerInternalsFetch.cpp
[rename] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/core/fetch/testing/WorkerInternalsFetch.h
[rename] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/core/fetch/testing/WorkerInternalsFetch.idl
[modify] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
[modify] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/modules/cachestorage/Cache.h
[modify] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/modules/cachestorage/CacheStorage.h
[modify] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp
[modify] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/modules/exported/WebTestingSupport.cpp
[delete] https://crrev.com/aae98a6e14795d2bbe7fe1ccca9c1f27c2ab9a6a/third_party/WebKit/Source/modules/fetch/BUILD.gn
[delete] https://crrev.com/aae98a6e14795d2bbe7fe1ccca9c1f27c2ab9a6a/third_party/WebKit/Source/modules/fetch/DEPS
[delete] https://crrev.com/aae98a6e14795d2bbe7fe1ccca9c1f27c2ab9a6a/third_party/WebKit/Source/modules/fetch/OWNERS
[modify] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/bee3ecf18f743a81d9fa1ffd76859152250e8da7/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp

Comment 15 by nhiroki@chromium.org, Dec 25 2017

Labels: M-65
Status: Fixed (was: Started)
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77e2d4514db44c29542d771628628bc8c1f396c0

commit 77e2d4514db44c29542d771628628bc8c1f396c0
Author: Yutaka Hirano <yhirano@chromium.org>
Date: Wed Jan 10 04:47:07 2018

Remove modules/fetch references from DEPS files

The directory is now moved to core/fetch and the references are no
longer needed.

Bug:  794837 
Change-Id: I097ed1194ef5ba53d50f00cfac6a374d86ac402d
Reviewed-on: https://chromium-review.googlesource.com/858776
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528239}
[modify] https://crrev.com/77e2d4514db44c29542d771628628bc8c1f396c0/third_party/WebKit/Source/modules/cachestorage/DEPS
[modify] https://crrev.com/77e2d4514db44c29542d771628628bc8c1f396c0/third_party/WebKit/Source/modules/serviceworkers/DEPS
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7398547f8e9033ba72786ddf1e1ce6ad8340790

commit a7398547f8e9033ba72786ddf1e1ce6ad8340790
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Jan 10 06:27:58 2018

Fix typos in READMEs for fetching/loading.

Bug:  794837 
Change-Id: I6c711ccc0595f2672ef5980f6e122b3f16004860
Reviewed-on: https://chromium-review.googlesource.com/858987
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528250}
[modify] https://crrev.com/a7398547f8e9033ba72786ddf1e1ce6ad8340790/third_party/WebKit/Source/core/loader/README.md
[modify] https://crrev.com/a7398547f8e9033ba72786ddf1e1ce6ad8340790/third_party/WebKit/Source/platform/loader/fetch/README.md
►

Sign in to add a comment