New issue
Advanced search Search tips

Issue 794836 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 796969
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

ScreenCaptureNotificationUICocoaTest.ShortTitle flaky in unit_tests on mac_chromium_rel_ng

Project Member Reported by kbr@chromium.org, Dec 14 2017

Issue description

Seen to fail here:

https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_rel_ng/612072
https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_rel_ng/612011
https://ci.chromium.org/buildbot/tryserver.chromium.mac/mac_chromium_rel_ng/611939

When it fails, it fails all 3 retries within the test executable:

[ RUN      ] ScreenCaptureNotificationUICocoaTest.ShortTitle
../../chrome/browser/ui/cocoa/screen_capture_notification_ui_cocoa_unittest.mm:89: Failure
Expected equality of these values:
  460
  NSWidth([[controller() window] frame])
    Which is: 461
[  FAILED  ] ScreenCaptureNotificationUICocoaTest.ShortTitle (11 ms)


Marking P1 since this is causing unnecessary retries on the commit queue. It's blocking CLs that make build changes, causing the entire mac_chromium_rel_ng run to be redone.

Not sure which component is correct for this. Appreciate help re-categorizing.

 

Comment 1 by awdf@chromium.org, Jan 8 2018

Mergedinto: 796969
Status: Duplicate (was: Untriaged)
This was already fixed by adding some tolerance to the value being checked in  Issue 796969 

Sign in to add a comment