New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794827 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 765864
Owner:
Last visit > 30 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Stop importing chromite's third_party infra_libs from outside chromite

Project Member Reported by pprabhu@chromium.org, Dec 14 2017

Issue description

All these imports are bad: http://shortn/_fwKm4njUgB

This is especially bad becauese the chromite/third_party path is setup by magic when something from chromite is imported. This means that in all of the cases above, the import order of modules is significant.
 
Wrap infra_libs.ts_mon.FieldTypes into metrics.FieldTypes so that external users can use it from there. That's the only reason I know we're imported this module.
 

Comment 1 by jkop@chromium.org, Dec 15 2017

Owner: jkop@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by jkop@chromium.org, Dec 15 2017

Potential dup of crbug.com/765864

Comment 3 by jkop@chromium.org, Dec 15 2017

Mergedinto: 765864
Status: Duplicate (was: Assigned)

Sign in to add a comment