MacViews: Button label font weight should be NORMAL on all macOS versions |
|||||||||
Issue descriptionChrome Version : 64.0.3278.0 OS Version: OS X 10.12.6 Per the thread at https://groups.google.com/a/google.com/d/msg/chrome-harmony/iycfk6mI6U8/OaAClDh5CgAJ When LCD font smoothing is enabled on Mac (which is the default), the system font renders kinda bold-looking. Particularly when drawing white text on a dark background. To the extent that MEDIUM (the closest we can get to NORMAL) looks too bold. macOS 10.9 and macOS 10.11 don't ship with a MEDIUM weight system font so are already using NORMAL. Decision: just make it NORMAL weight everywhere.
,
Dec 20 2017
Removing the bold from the non-default buttons seems to have a bigger than expected impact too. The contrast ratio is only just below the requirement, at 4.4: http://leaverou.github.io/contrast-ratio/#rgb%28120%2C%20120%2C%20120%29-on-white But since the font doesn't occupy many pixels, most of them get a font that is lighter than #787878 Also the result when that LCD font-smoothing checkbox is unchecked is awful. I don't think we can land that CL.
,
Dec 20 2017
actually those two screengrabs are with a bold font. (and the one without font smoothing still looks bad)
,
Mar 26 2018
MacViews triage: this reproduces for me. Assigning to spqchan@ for M-69 fix.
,
Mar 26 2018
Note I'm not sure what action should be taken here. I think we are still happy with how things are shipping, but might want a mac-specific tweak once things settle down. It might involve detecting the `font smoothing` setting and acting on that as well as (how we do currently) on macOS-version. Fixing the bug as written will make the button font too scratchy (and low-contrast) for users without font-smoothing enabled.
,
Mar 27 2018
,
May 29 2018
,
May 30 2018
macviews triage: lgrey@, over to you :)
,
May 30 2018
bettes@ what's your take on c#5?
,
Jul 12
,
Jul 12
,
Jul 31
bettes: Making it NORMAL for all macOS versions lgtm.
,
Aug 1
Note that macOS 10.14 Mojave has dropped support for subpixel AA, so the premise that "the system font renders kinda bold-looking" will no longer hold true there. (i.e. since filing this bug, this new info suggests that we may actually want MEDIUM again). |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by tapted@chromium.org
, Dec 15 2017