New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 794794 link

Starred by 2 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Dec 2017
Cc:
rdevlin....@chromium.org
bettes@chromium.org
█ dschuyler@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocking:
issue 780164


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

[MD Extensions] Size taken by an extension is not shown.

Project Member Reported by dpa...@chromium.org, Dec 14 2017 
Splitting this as a separate bug from  issue 794286  (some original discussion happened there).

Probably the way to go is to add a new chrome.developerPrivate API method to get the size for a specific extension and call that when a details page is shown in the UI.
cws_link.png
32.8 KB View Download

Comment 1 by dpa...@chromium.org, Dec 14 2017

Labels: -Pri-2 Pri-1

Comment 2 by dpa...@chromium.org, Dec 14 2017

Cc: dschuyler@chromium.org rdevlin....@chromium.org bettes@chromium.org
Owner: dpa...@chromium.org
Status: Started (was: Available)
I 'll take a shot at this. Thinking of putting the size info on its own section after "Version", see screenshot.
display_size.png
37.3 KB View Download

Comment 3 by dpa...@chromium.org, Dec 14 2017 

FYI, CL candidate is at https://chromium-review.googlesource.com/c/chromium/src/+/827590. Still needs a few tweaks, but it seems to work.

Comment 4 by dpa...@chromium.org, Dec 14 2017

Blocking: 780164
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b07445b4b12bd014c053022a5e18b867bf50f3f8

commit b07445b4b12bd014c053022a5e18b867bf50f3f8
Author: dpapad <dpapad@chromium.org>
Date: Sat Dec 16 01:42:38 2017

MD Extensions: Display extension size in details view.

Bug:  794794 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I021ce4292149c6d86302d7b3285f062decff4fd1
Reviewed-on: https://chromium-review.googlesource.com/827590
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524559}
[modify] https://crrev.com/b07445b4b12bd014c053022a5e18b867bf50f3f8/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[modify] https://crrev.com/b07445b4b12bd014c053022a5e18b867bf50f3f8/chrome/browser/extensions/api/developer_private/developer_private_api.h
[modify] https://crrev.com/b07445b4b12bd014c053022a5e18b867bf50f3f8/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/b07445b4b12bd014c053022a5e18b867bf50f3f8/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/b07445b4b12bd014c053022a5e18b867bf50f3f8/chrome/browser/resources/md_extensions/item.js
[modify] https://crrev.com/b07445b4b12bd014c053022a5e18b867bf50f3f8/chrome/browser/resources/md_extensions/service.js
[modify] https://crrev.com/b07445b4b12bd014c053022a5e18b867bf50f3f8/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/b07445b4b12bd014c053022a5e18b867bf50f3f8/chrome/common/extensions/api/developer_private.idl
[modify] https://crrev.com/b07445b4b12bd014c053022a5e18b867bf50f3f8/chrome/test/data/webui/extensions/extension_test_util.js
[modify] https://crrev.com/b07445b4b12bd014c053022a5e18b867bf50f3f8/chrome/test/data/webui/extensions/test_service.js
[modify] https://crrev.com/b07445b4b12bd014c053022a5e18b867bf50f3f8/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/b07445b4b12bd014c053022a5e18b867bf50f3f8/third_party/closure_compiler/externs/developer_private.js
[modify] https://crrev.com/b07445b4b12bd014c053022a5e18b867bf50f3f8/tools/metrics/histograms/enums.xml

Comment 6 by dpa...@chromium.org, Dec 16 2017

Labels: Merge-Request-64
Status: Fixed (was: Started)
Project Member

Comment 7 by sheriffbot@chromium.org, Dec 17 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by abdulsyed@chromium.org, Dec 18 2017 

This seems like a fairly large change? and seems just like just landed in Canary over the weekend. Can you please confirm if it's safe, well tested and verified?

Comment 9 by dpa...@chromium.org, Dec 18 2017 

> Can you please confirm if it's safe?

Yes, should be fairly safe. This change adds a new getExtensionSize() method in chrome.developerPrivate API, which is only used by the new MD Extensions UI. So it is unlikely it could cause any issues unrelated to MD Extensions.

> Well tested and verified

The change is tested manually and verified. See attached screenshot.
verified.png
124 KB View Download

Comment 10 by abdulsyed@chromium.org, Dec 18 2017

Labels: -Merge-Review-64 Merge-Approved-64
As discussed in meeting, Extensions MD launch is behind a flag. Change has been tested and verified in Canary. Approving merge to M64 branch:3282
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 19 2017

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b01db31796c90b58a31ae7d25f3e9ea3d40e55b

commit 8b01db31796c90b58a31ae7d25f3e9ea3d40e55b
Author: dpapad <dpapad@chromium.org>
Date: Tue Dec 19 00:58:31 2017

[M64 merge] MD Extensions: Display extension size in details view.

TBR=dpapad@chromium.org

(cherry picked from commit b07445b4b12bd014c053022a5e18b867bf50f3f8)

Bug:  794794 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I021ce4292149c6d86302d7b3285f062decff4fd1
Reviewed-on: https://chromium-review.googlesource.com/827590
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#524559}
Reviewed-on: https://chromium-review.googlesource.com/833098
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#284}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/8b01db31796c90b58a31ae7d25f3e9ea3d40e55b/chrome/browser/extensions/api/developer_private/developer_private_api.cc
[modify] https://crrev.com/8b01db31796c90b58a31ae7d25f3e9ea3d40e55b/chrome/browser/extensions/api/developer_private/developer_private_api.h
[modify] https://crrev.com/8b01db31796c90b58a31ae7d25f3e9ea3d40e55b/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/8b01db31796c90b58a31ae7d25f3e9ea3d40e55b/chrome/browser/resources/md_extensions/detail_view.js
[modify] https://crrev.com/8b01db31796c90b58a31ae7d25f3e9ea3d40e55b/chrome/browser/resources/md_extensions/item.js
[modify] https://crrev.com/8b01db31796c90b58a31ae7d25f3e9ea3d40e55b/chrome/browser/resources/md_extensions/service.js
[modify] https://crrev.com/8b01db31796c90b58a31ae7d25f3e9ea3d40e55b/chrome/browser/ui/webui/extensions/extensions_ui.cc
[modify] https://crrev.com/8b01db31796c90b58a31ae7d25f3e9ea3d40e55b/chrome/common/extensions/api/developer_private.idl
[modify] https://crrev.com/8b01db31796c90b58a31ae7d25f3e9ea3d40e55b/chrome/test/data/webui/extensions/extension_test_util.js
[modify] https://crrev.com/8b01db31796c90b58a31ae7d25f3e9ea3d40e55b/chrome/test/data/webui/extensions/test_service.js
[modify] https://crrev.com/8b01db31796c90b58a31ae7d25f3e9ea3d40e55b/extensions/browser/extension_function_histogram_value.h
[modify] https://crrev.com/8b01db31796c90b58a31ae7d25f3e9ea3d40e55b/third_party/closure_compiler/externs/developer_private.js
[modify] https://crrev.com/8b01db31796c90b58a31ae7d25f3e9ea3d40e55b/tools/metrics/histograms/enums.xml
►

Sign in to add a comment