New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794783 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task



Sign in to add a comment

Consolidate and clean up how tests are run on bots in the chromium recipe

Project Member Reported by dpranke@chromium.org, Dec 14 2017

Issue description

We have too many different ways to configure what tests are built and run on 
the bots, and they are run in too many different ways.

Specifically, I'm referring to the ways we specify what to build (via the JSON files, gn_isolate_map.pyl, and GN targets directly), and what args to use when running the
tasks (via command lines in gn_isolate_map.pyl, or in the JSON files, or in 
generated wrappers in the build).

Ideally we'd have a single way of configuring what is run, and a single API that we use for communicating between the recipe and the test runner(s).

We've drafted https://bit.ly/chromium-test-runner-api to talk more about this; it uses the IsolatedScriptTest and Android/Fuchsia "bin/_run" wrapper approach as the basic model.
 
Owner: dpranke@chromium.org
Status: Started (was: Untriaged)
Labels: -Pri-1 -Type-Bug Pri-2 Type-Task
Owner: ----
Status: Available (was: Started)
We don't have an ETA for this, so downgrading it to P2. Also, unassigning myself, as I don't expect to do everything here.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cb6aa788b5700afccb241ba7acdd1aa13b5d5de

commit 8cb6aa788b5700afccb241ba7acdd1aa13b5d5de
Author: Dirk Pranke <dpranke@chromium.org>
Date: Sat Dec 16 02:31:33 2017

Add initial support for `mb run --swarmed`.

This adds the initial support to MB to be able to build and run
a binary under swarming easily. It builds on the existing code
in MB for building and isolating targets, and just adds uploading
the isolate, triggering the task, waiting for and collecting the
results.
e
The end goal is that it should be this easy to reproduce a failure
in a bot config:

    $ fetch chromium && python src\tools\mb\mb.py run --swarmed \
        --master tryserver.chromium.win \
        --builder win-msvc-rel \
        out\Release base_unittests

Adding this gives us a starting framework that we can build on
for the bit.ly/chromium-test-runner-api cleanup work.

R=jbudorick@chromium.org, maruel@chromium.org
BUG=794783

Change-Id: I160706b1a563bceb36b8465857d32692a3ca004d
Reviewed-on: https://chromium-review.googlesource.com/825925
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524568}
[modify] https://crrev.com/8cb6aa788b5700afccb241ba7acdd1aa13b5d5de/tools/mb/docs/user_guide.md
[modify] https://crrev.com/8cb6aa788b5700afccb241ba7acdd1aa13b5d5de/tools/mb/mb.py
[modify] https://crrev.com/8cb6aa788b5700afccb241ba7acdd1aa13b5d5de/tools/mb/mb_unittest.py

Project Member

Comment 4 by sheriffbot@chromium.org, Dec 17

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: martiniss@chromium.org
Status: Assigned (was: Untriaged)
I'd like to make some progress on this. 

Sign in to add a comment