Modal Views dialogs and modal WebUI dialogs interact poorly during oobe/login |
|||||
Issue descriptionA specific repro from issue 791955 illustrates this problem: 1. Connect to a secure wifi network from the system tray and enter an incorrect password. The 'Join WiFi network' dialog should appear as well as a notification. 2. While the 'Join WiFi network' dialog is still visible, click on the notification. Observe: The network settings dialog appears over the 'Join WiFi network' dialog but does not have focus and can not be interacted with, moved, or closed. This repro has been "fixed" by preventing System WebUI dialogs (SystemWebDialogDelegate) from being opened while the network config dialog is open, however it is still potentially possible for some other combination of modal dialogs to exhibit this behavior. At this point fixing this is not urgent, but it might be nice to do so at some point.
,
Dec 18 2017
stevenjb@ is this specific to oobe or can happen after sign in?
,
Dec 19 2017
It happens in the login screen, but not after sign in (I had to jump through some hoops to test that, let me know if you want instructions).
,
Dec 19 2017
Issue 795700 has been merged into this issue.
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5ecb6ba426ad733bd1a2aa681df00c4c703f40be commit 5ecb6ba426ad733bd1a2aa681df00c4c703f40be Author: Mitsuru Oshima <oshima@chromium.org> Date: Thu Dec 21 03:54:57 2017 Make SystemWebDialog in login/lock state modal. Bug: 794776 Test: covered by unit test Change-Id: Icf59f6c8fb71d8e3459a2fa26d0027f2238b022b Reviewed-on: https://chromium-review.googlesource.com/833528 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#525592} [add] https://crrev.com/5ecb6ba426ad733bd1a2aa681df00c4c703f40be/chrome/browser/ui/webui/chromeos/system_web_dialog_browsertest.cc [modify] https://crrev.com/5ecb6ba426ad733bd1a2aa681df00c4c703f40be/chrome/browser/ui/webui/chromeos/system_web_dialog_delegate.cc [modify] https://crrev.com/5ecb6ba426ad733bd1a2aa681df00c4c703f40be/chrome/browser/ui/webui/chromeos/system_web_dialog_delegate.h [modify] https://crrev.com/5ecb6ba426ad733bd1a2aa681df00c4c703f40be/chrome/test/BUILD.gn
,
Dec 21 2017
,
Jul 30
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by steve...@chromium.org
, Dec 14 2017