New issue
Advanced search Search tips

Issue 794771 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 2
Type: Bug



Sign in to add a comment

AppWindowApiTest event tests are flaky on Linux (headless) and also Mac 10.10

Project Member Reported by steve...@chromium.org, Dec 14 2017

Issue description

linux_chromium_rel_ng runs browser_tests with HEADLESS=1.

This causes 'minimize', 'maximize', and 'restore' events to be unreliable.

Repro:

HEADLESS=1 out/Linux/browser_tests --brave-new-test-launcher --test-launcher-bot-mode --cfi-diag=0 --gtest_filter=AppWindowApiTest.*

Temporary solution: disable these tests.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eefdc769289d2fe0de931f6626c94aa34d0292bd

commit eefdc769289d2fe0de931f6626c94aa34d0292bd
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Dec 14 17:54:38 2017

AppWindowApiTest.Properties: Elim flakiness

This test was assuming that calling minimize() and maximize() followed
by restore() without waiting for onMinimized or onMaximized would
trigger onRestored. This is not the case on Mash, and is also a likely
cause of flake on other platforms.

Bug:  232330 , 678687 ,794771
Change-Id: I2a6a0f1e0b527583add555ed5ab8bfdc3a073df6
Reviewed-on: https://chromium-review.googlesource.com/821310
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524110}
[modify] https://crrev.com/eefdc769289d2fe0de931f6626c94aa34d0292bd/chrome/test/data/extensions/platform_apps/windows_api_properties/main.js
[modify] https://crrev.com/eefdc769289d2fe0de931f6626c94aa34d0292bd/extensions/browser/api/app_window/app_window_apitest.cc
[modify] https://crrev.com/eefdc769289d2fe0de931f6626c94aa34d0292bd/testing/buildbot/filters/mojo.fyi.mash.browser_tests.filter

Cc: qyearsley@google.com
 Issue 795923  has been merged into this issue.
Today this test appears to time out sometimes Mac10.10:

Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=AppWindowApiTest.OnMinimizedEvent&testType=browser_tests

Example failed build today: https://ci.chromium.org/buildbot/chromium.mac/Mac10.10%20Tests/27251

Log excerpt:

Additional test environment:
    CHROME_DEVEL_SANDBOX=/opt/chromium/chrome_sandbox
    CHROME_HEADLESS=1
    LANG=en_US.UTF-8
Command: ./browser_tests --brave-new-test-launcher --test-launcher-bot-mode --cfi-diag=0 --test-launcher-summary-output=/b/s/w/ioi2fowV/output.json

...
Still waiting for the following processes to finish:
	./browser_tests --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=AppWindowApiTest.OnMinimizedEvent --single_process --test-launcher-bot-mode --test-launcher-output=/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.MNMhAe/results9oytHQ/test_results.xml --test-launcher-summary-output=/b/s/w/ioi2fowV/output.json --user-data-dir=/var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.MNMhAe/d2kkIEB
[ RUN      ] AppWindowApiTest.OnMinimizedEvent
[9139:5891:1218/131446.268295:WARNING:notification_platform_bridge_mac.mm(533)] AlertNotificationService: XPC connection invalidated.
[13:14:46.336] vtDecompressionDuctCreate signalled err=-8973 (err) (Could not select and open decoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTDecompressionSession.c line 1181
<<<< VTVideoEncoderSelection >>>> VTSelectAndCreateVideoEncoderInstanceInternal: no video encoder found for 'avc1'

[13:14:46.397] VTSelectAndCreateVideoEncoderInstanceInternal signalled err=-12908 (err) (Video encoder not available) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTVideoEncoderSelection.c line 1245
[13:14:46.397] VTCompressionSessionCreate signalled err=-12908 (err) (Could not select and open encoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTCompressionSession.c line 946
BrowserTestBase received signal: Terminated: 15. Backtrace:
...
18  browser_tests                       0x00000001055986a5 base::RunLoop::Run() + 53
19  browser_tests                       0x0000000105ba6285 content::RunThisRunLoop(base::RunLoop*) + 53
20  browser_tests                       0x0000000109f1e330 extensions::ResultCatcher::GetNextResult() + 96
21  browser_tests                       0x0000000103515036 ExtensionApiTest::RunExtensionTestImpl(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*, int) + 646
22  browser_tests                       0x00000001035150fd ExtensionApiTest::RunExtensionTestWithArg(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, char const*) + 45
23  browser_tests                       0x0000000103a7729c extensions::AppWindowApiTest_OnMinimizedEvent_Test::RunTestOnMainThread() + 124
24  browser_tests                       0x0000000105b5912e content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 334
25  browser_tests                       0x000000010567c152 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4162
26  browser_tests                       0x000000010567b00e ChromeBrowserMainParts::PreMainMessageLoopRun() + 62
27  browser_tests                       0x00000001042ebe73 content::BrowserMainLoop::PreMainMessageLoopRun() + 67
28  browser_tests                       0x00000001046a8ed7 content::StartupTaskRunner::RunAllTasksNow() + 39
29  browser_tests                       0x00000001042ea457 content::BrowserMainLoop::CreateStartupTasks() + 583
30  browser_tests                       0x00000001042ee87a content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 618
31  browser_tests                       0x00000001042e8624 content::BrowserMain(content::MainFunctionParams const&) + 180
32  browser_tests                       0x000000010552b5ef content::ContentMainRunnerImpl::Run() + 383
33  browser_tests                       0x000000010729c328 service_manager::Main(service_manager::MainParams const&) + 2344
34  browser_tests                       0x000000010552aad4 content::ContentMain(content::ContentMainParams const&) + 68
35  browser_tests                       0x0000000105b58df6 content::BrowserTestBase::SetUp() + 2438
36  browser_tests                       0x0000000105604ba8 InProcessBrowserTest::SetUp() + 392
37  browser_tests                       0x0000000103ae77c1 testing::Test::Run() + 97
38  browser_tests                       0x0000000103ae8330 testing::TestInfo::Run() + 288
39  browser_tests                       0x0000000103ae8897 testing::TestCase::Run() + 263
40  browser_tests                       0x0000000103aeeba7 testing::internal::UnitTestImpl::RunAllTests() + 903
41  browser_tests                       0x0000000103aee7f3 testing::UnitTest::Run() + 163
42  browser_tests                       0x000000010561dd37 base::TestSuite::Run() + 167
43  browser_tests                       0x000000010553d785 ChromeTestSuiteRunner::RunTestSuite(int, char**) + 37
44  browser_tests                       0x0000000105ba07f3 content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 387
45  browser_tests                       0x000000010553db97 LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) + 135
46  browser_tests                       0x000000010553d6fe main + 94
47  libdyld.dylib                       0x00007fff850715c9 start + 1
48  ???                                 0x000000000000000a 0x0 + 10
[813/815] AppWindowApiTest.OnMinimizedEvent (TIMED OUT)
Labels: OS-Mac
Summary: AppWindowApiTest event tests are flaky on Linux (headless) and also Mac 10.10 (was: AppWindowApiTest event tests are flaky on Linux (headless))
Looks like there are other reasons why this times out on Mac 10.10, I will re-disable this test there in addition to Linux.

See also issue 660582 for Mac 10.10, i.e. it may be failing there for other reasons.

Thanks Steven!
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fa86162b04b928bb59fe26b01f8a0b1fe84d05d

commit 7fa86162b04b928bb59fe26b01f8a0b1fe84d05d
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Dec 18 23:17:38 2017

AppWindowApiTest: Disable some tests on Mac 10.10 again

Some AppWindowApiTest flakiness was addressed however Mac 10.1
flakiness seems to remain, so re-disabling the tests.

Bug: 794771
Change-Id: Icfa4e9293e815090eb277ed1c7031b9ee6f6e5a5

Fisabling a flakey test:

TBR: benwells@chromium.org
Change-Id: Icfa4e9293e815090eb277ed1c7031b9ee6f6e5a5
Reviewed-on: https://chromium-review.googlesource.com/833372
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524852}
[modify] https://crrev.com/7fa86162b04b928bb59fe26b01f8a0b1fe84d05d/extensions/browser/api/app_window/app_window_apitest.cc

Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment