Make test_runner.py handle --test-launcher-filter-file argument |
|||
Issue descriptionCurrently src/build/android/test_runner.py takes the command line argument --gtest-filter-file to run a subset of tests: https://cs.chromium.org/chromium/src/build/android/test_runner.py?q=gtest-filter-file&sq=package:chromium&l=365 It should be upgraded to accept --test-launcher-filter-file for the same argument, too. This will make the Android tests behave the same as on other platforms that don't use this wrapper script.
,
Dec 14 2017
We have a few test launcher compatibility options up in https://cs.chromium.org/chromium/src/build/android/test_runner.py?rcl=407c3fcf555e8df54e8236531847720a0c3cbbed&l=64; I'm not sure how we wound up w/o this one.
,
Dec 14 2017
Studying the code, not sure either – will put up a CL trying to unify these once Issue 794749 is fixed.
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb29325c1aedbb530110644fd38430a905af1b96 commit bb29325c1aedbb530110644fd38430a905af1b96 Author: Kenneth Russell <kbr@chromium.org> Date: Thu Dec 14 21:13:34 2017 Use test-launcher-filter-file instead of gtest-filter-file. Studying the code in src/build/android/test_runner.py and related files (like test_instance_factory and gtest_test_instance), there were no dependencies on this specific argument's name. Change to use the standard one so that Android works the same as the other platforms. BUG= 794767 Change-Id: I22f3eea9cb9d1029b778b1d4a878d0e74dc6449c Reviewed-on: https://chromium-review.googlesource.com/826490 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524177} [modify] https://crrev.com/bb29325c1aedbb530110644fd38430a905af1b96/build/android/test_runner.py [modify] https://crrev.com/bb29325c1aedbb530110644fd38430a905af1b96/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/bb29325c1aedbb530110644fd38430a905af1b96/testing/buildbot/filters/README.md [modify] https://crrev.com/bb29325c1aedbb530110644fd38430a905af1b96/testing/buildbot/test_suite_exceptions.pyl
,
Dec 14 2017
Calling this fixed. Removal of support for --gtest-filter-file can proceed separately, or land under this bug too.
,
Dec 14 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by kbr@chromium.org
, Dec 14 2017