New issue
Advanced search Search tips

Issue 794766 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Opening a data URI link in new tab context menu works.

Project Member Reported by michaelsamuel@google.com, Dec 14 2017

Issue description

Chrome Version: 63.0.3239.90
OS: Linux

What steps will reproduce the problem?
(1) Create a website with a link to a data:text/html URL
(2) Right click the link, click Open in New Tab

What is the expected result?
This should be blocked (like a regular click or middle click)

What happens instead?
It opens the data URI in a new tab

 

Comment 1 by mmenke@chromium.org, Dec 14 2017

Components: UI>Browser>Navigation
Maybe a regression due to PlzNavigate shipping?

Comment 2 by creis@chromium.org, Dec 14 2017

Cc: -mea...@chromium.org lukasza@chromium.org creis@chromium.org
Labels: OS-Chrome OS-Mac OS-Windows
Owner: mea...@chromium.org
I don't think this case ever was prevented, and it still repros with --disable-browser-side-navigation.  The context menu has similarities to copying the link and pasting it into a new tab, plus it's treated like a browser-initiated navigation.  This means it's not that surprising from an implementation perspective that it works.

That's in contrast to control+click (etc), which are correctly blocked.

Mustafa, if you want to fix this, maybe it's a validation step for the URL in RenderViewContextMenu?

Comment 3 by mea...@chromium.org, Dec 15 2017

> The context menu has similarities to copying the link and pasting it into a new tab, plus it's treated like a browser-initiated navigation

AFAIR, this was the main idea behind allowing this. But I can't seem to get the same behavior for other non-web navigable URLs such as chrome://settings. Right click + opening a chrome:// URL results in about:blank. 

Charlie, was our assumption incorrect? Or is there some special handling for chrome: URLs? Shouldn't they also be navigable via right click menu?

Comment 4 by creis@chromium.org, Dec 15 2017

I think chrome:// URLs are intentionally filtered out.
Status: Assigned (was: Untriaged)

Sign in to add a comment