[MD Extensions] "Extensions options" button should be disabled when extension disabled. |
|||
Issue descriptionRepro steps (see screencast): 1) Install https://chrome.google.com/webstore/detail/akimgimeeoiognljlfchpbkpfbmeapkh 2) Disable it from chrome://extensions/?id=akimgimeeoiognljlfchpbkpfbmeapkh 3) Click "Extension options". URL changes, but the options UI does not show up. 4) Re-enable it, and click "Extension options". The options UI does not show up At step 3: In the non-MD UI, the link to open options is hidden when an extension is disabled. Also note, that at step 4, it seems that the C++ side has entered some bad state, because even after re-enabling the extension, the custom options UI does not show up.
,
Dec 14 2017
FYI, fix candidate at https://chromium-review.googlesource.com/c/chromium/src/+/826484.
,
Dec 14 2017
,
Dec 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d438ad2d55fd78ccb60509621f499421d4c8e7f0 commit d438ad2d55fd78ccb60509621f499421d4c8e7f0 Author: dpapad <dpapad@chromium.org> Date: Sat Dec 16 01:13:45 2017 MD Extensions: Disable "Extension options" button when extension is disabled. Convert the "Extension options" row to a cr-link-row and leverage the existing styling for the disabled case. Bug: 794756 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7139e20a17d5e0ac5c85f0e1da7a5ad3bd2ab3d9 Reviewed-on: https://chromium-review.googlesource.com/826484 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#524548} [modify] https://crrev.com/d438ad2d55fd78ccb60509621f499421d4c8e7f0/chrome/browser/resources/md_extensions/detail_view.html [modify] https://crrev.com/d438ad2d55fd78ccb60509621f499421d4c8e7f0/chrome/browser/resources/md_extensions/detail_view.js [modify] https://crrev.com/d438ad2d55fd78ccb60509621f499421d4c8e7f0/chrome/test/data/webui/extensions/extension_detail_view_test.js
,
Dec 16 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dpa...@chromium.org
, Dec 14 2017Status: Started (was: Available)