New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794730 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Moblab does not build due to missing dependency sys-process/criu[selinux=]

Project Member Reported by haddowk@chromium.org, Dec 13 2017

Issue description

INFO    : Checking package dependencies are correct: virtual/target-os virtual/target-os-dev virtual/target-os-factory virtual/target-os-factory-shim virtual/target-os-test chromeos-base/autotest-all

These are the packages that would be merged, in order:

Calculating dependencies  . ... done!

emerge: there are no ebuilds to satisfy "sys-process/criu[selinux=]" for /build/guado_moblab/.
(dependency required by "app-emulation/lxc-2.0.8" [ebuild])
(dependency required by "chromeos-base/chromeos-bsp-moblab-0.0.5-r73::moblab[lxc]" [ebuild])
(dependency required by "virtual/chromeos-bsp-3.5-r1::guado_moblab" [ebuild])
(dependency required by "virtual/target-chromium-os-1-r83::chromiumos" [ebuild])
(dependency required by "virtual/target-os-3.5-r1::mobbase-private" [ebuild])
(dependency required by "virtual/target-os" [argument])
ERROR   : emerge detected broken ebuilds. See error message above.

 

This CL changed the version of lxc container bit the dependency was not added.

https://chromium-review.googlesource.com/#/c/chromiumos/overlays/portage-stable/+/784271/

That package is restricted to test only:

https://packages.gentoo.org/packages/sys-process/criu

So I do not believe it will be possible to add the package to moblab.

Plan of action is have a USE flag that will remove the dependency on sys-process/criu for moblab
Components: Infra>Client>ChromeOS
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a99f835fb28b037c613178e0cf8f215b040de6da

commit a99f835fb28b037c613178e0cf8f215b040de6da
Author: Keith Haddow <haddowk@chromium.org>
Date: Sat Apr 07 02:50:43 2018

[cros-kernel2] Add config fragment to support the criu module.

Extra kernel flags are required to support criu which is
a dependency on the newer lxc versions.

BUG= chromium:794730 
TEST=build guado and fizz moblab with new flags

Change-Id: I5b554916e8c4ead4680aaa2d1c178cd5fe0c303d
Reviewed-on: https://chromium-review.googlesource.com/998616
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/a99f835fb28b037c613178e0cf8f215b040de6da/eclass/cros-kernel2.eclass

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 24 2018

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b2e6005e164f1529b1d49509b34e63dae1b6a7ff

commit b2e6005e164f1529b1d49509b34e63dae1b6a7ff
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Apr 24 04:48:16 2018

CHROMIUM: config: Backport CONFIG_SECURITY_CHROMIUMOS_NO_SYMLINK_MOUNT

In kernel v4.4 you can switch off the no symlink mount check, we
need to switch this off for lxc to work on moblab, which uses the
3.14 kernel.

BUG= chromium:794730 
TEST=built and tested locally on moblab.

Change-Id: I1ece162f5b4ed236428061c4f400f400f940dc14
Signed-off-by: Keith Haddow <haddowk@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1017004
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/b2e6005e164f1529b1d49509b34e63dae1b6a7ff/chromeos/config/base.config

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0a0c7deaab80989dcb9b5ab5d23f0c128a101871

commit 0a0c7deaab80989dcb9b5ab5d23f0c128a101871
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Apr 24 04:48:14 2018

CHROMIUM: LSM: Backport CONFIG_SECURITY_CHROMIUMOS_NO_SYMLINK_MOUNT

In kernel v4.4 you can switch off the no symlink mount check, we
need to switch this off for lxc to work on moblab, which uses the
3.14 kernel.

CQ-DEPEND=CL:1017004
BUG= chromium:794730 
TEST=built and tested locally on moblab.

Change-Id: I3d1e980aaaf05578255737a1ebc1f4f7b391fe8f
Signed-off-by: Keith Haddow <haddowk@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1017006
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/0a0c7deaab80989dcb9b5ab5d23f0c128a101871/security/chromiumos/lsm.c
[modify] https://crrev.com/0a0c7deaab80989dcb9b5ab5d23f0c128a101871/security/chromiumos/Kconfig

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e9a3a93ffd4afe180de382babf9dcb8a3b90d387

commit e9a3a93ffd4afe180de382babf9dcb8a3b90d387
Author: Keith Haddow <haddowk@chromium.org>
Date: Wed Apr 25 21:40:52 2018

init: Update cgroups mount to work on moblab.

To be compatible with Android cgroups mounts cpuset with
noprefix.

On moblab we use lxc containers and the lxc code needs
prefixes on the cpuset cgroup mounts.

Attempts were made to re-mount, or create links but
nothing else worked.  Open to other suggestions.

BUG= chromium:794730 
TEST=build and tested on moblab

Change-Id: I46c2267b8fca24f1f6843aa65f2e5319e65e597f
Reviewed-on: https://chromium-review.googlesource.com/1017010
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e9a3a93ffd4afe180de382babf9dcb8a3b90d387/init/upstart/cgroups.conf

Project Member

Comment 7 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/00ca61719378bb172feafce2363c9e0d49ed0a06

commit 00ca61719378bb172feafce2363c9e0d49ed0a06
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri May 04 22:45:28 2018

sys-process/criu: upgraded package to upstream

Upgraded sys-process/criu to version 3.7 on amd64

This is based on the Gentoo upstream package with
the following edits:

* Compiler changes as per crbug/839665
* Injected library path to Makefile.packages

TEST=emerge-fizz-moblab sys-process/criu[selinux=]
BUG= chromium:794730 

Change-Id: I936da7e1417dc55071530068dcb32760fd6794cb
Reviewed-on: https://chromium-review.googlesource.com/1041156
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[add] https://crrev.com/00ca61719378bb172feafce2363c9e0d49ed0a06/sys-process/criu/files/2.2/criu-2.2-makefile.patch
[add] https://crrev.com/00ca61719378bb172feafce2363c9e0d49ed0a06/sys-process/criu/files/2.0/criu-2.0-sysroot.patch
[add] https://crrev.com/00ca61719378bb172feafce2363c9e0d49ed0a06/sys-process/criu/criu-3.7.ebuild
[add] https://crrev.com/00ca61719378bb172feafce2363c9e0d49ed0a06/sys-process/criu/files/2.4/criu-2.4-makefile.patch
[add] https://crrev.com/00ca61719378bb172feafce2363c9e0d49ed0a06/sys-process/criu/files/2.0/criu-2.0-automagic-libbsd.patch
[add] https://crrev.com/00ca61719378bb172feafce2363c9e0d49ed0a06/sys-process/criu/criu-3.7-r1.ebuild
[add] https://crrev.com/00ca61719378bb172feafce2363c9e0d49ed0a06/sys-process/criu/files/2.3/criu-2.3-no-git.patch
[add] https://crrev.com/00ca61719378bb172feafce2363c9e0d49ed0a06/sys-process/criu/files/2.2/criu-2.2-no-git.patch
[add] https://crrev.com/00ca61719378bb172feafce2363c9e0d49ed0a06/sys-process/criu/files/2.3/criu-2.3-aarch64.patch
[add] https://crrev.com/00ca61719378bb172feafce2363c9e0d49ed0a06/sys-process/criu/files/2.9/criu-2.9-makefile.patch
[add] https://crrev.com/00ca61719378bb172feafce2363c9e0d49ed0a06/sys-process/criu/files/criu-2.8-automagic-libbsd.patch
[add] https://crrev.com/00ca61719378bb172feafce2363c9e0d49ed0a06/sys-process/criu/files/2.2/criu-2.2-flags.patch
[add] https://crrev.com/00ca61719378bb172feafce2363c9e0d49ed0a06/sys-process/criu/Manifest
[add] https://crrev.com/00ca61719378bb172feafce2363c9e0d49ed0a06/sys-process/criu/metadata.xml
[add] https://crrev.com/00ca61719378bb172feafce2363c9e0d49ed0a06/sys-process/criu/files/2.5/criu-2.5-automagic-libbsd.patch

Project Member

Comment 8 by bugdroid1@chromium.org, May 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/697cf5bcd8e87b99a9c215ed59f864adbda9ac52

commit 697cf5bcd8e87b99a9c215ed59f864adbda9ac52
Author: Keith Haddow <haddowk@chromium.org>
Date: Thu May 10 22:10:12 2018

cros-kernel2: Add flags to support latest lxc containers.

OverlayFS was required to get lxc snapshotting to work.

Other flags are checked by the latest gentoo ebuild.

TEST=built and tested on guado and fizz moblab.
BUG= chromium:794730 

Change-Id: I47eedac3cc74b13460c9c1f19d8ba99dcd996e15
Reviewed-on: https://chromium-review.googlesource.com/1038126
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/697cf5bcd8e87b99a9c215ed59f864adbda9ac52/sys-kernel/chromeos-kernel-3_8/chromeos-kernel-3_8-9999.ebuild
[modify] https://crrev.com/697cf5bcd8e87b99a9c215ed59f864adbda9ac52/sys-kernel/chromeos-kernel-4_4/chromeos-kernel-4_4-9999.ebuild
[modify] https://crrev.com/697cf5bcd8e87b99a9c215ed59f864adbda9ac52/sys-kernel/chromeos-kernel-3_18/chromeos-kernel-3_18-9999.ebuild
[modify] https://crrev.com/697cf5bcd8e87b99a9c215ed59f864adbda9ac52/sys-kernel/chromeos-kernel-4_14/chromeos-kernel-4_14-9999.ebuild
[modify] https://crrev.com/697cf5bcd8e87b99a9c215ed59f864adbda9ac52/eclass/cros-kernel2.eclass
[modify] https://crrev.com/697cf5bcd8e87b99a9c215ed59f864adbda9ac52/sys-kernel/chromeos-kernel-3_14/chromeos-kernel-3_14-9999.ebuild
[modify] https://crrev.com/697cf5bcd8e87b99a9c215ed59f864adbda9ac52/sys-kernel/chromeos-kernel-3_10/chromeos-kernel-3_10-9999.ebuild

Project Member

Comment 9 by bugdroid1@chromium.org, May 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/729eadd7ac90ae5727ae942ac59d53d3405b08dd

commit 729eadd7ac90ae5727ae942ac59d53d3405b08dd
Author: Keith Haddow <haddowk@chromium.org>
Date: Fri May 11 06:18:04 2018

lxc: Add use flag to the config/rootfs can be in /etc

The new default location for lxc is in /var, this does not work
on moblab so have a use flag that allows the path to be /etc

BUG= chromium:794730 
TEST=build and tested on fizz moblab.

Change-Id: Ib447a968639aed84e800dbac9bdc2306733ebbd3
Reviewed-on: https://chromium-review.googlesource.com/1054342
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Jason Clinton <jclinton@chromium.org>

[rename] https://crrev.com/729eadd7ac90ae5727ae942ac59d53d3405b08dd/app-emulation/lxc/lxc-2.1.1-r3.ebuild
[modify] https://crrev.com/729eadd7ac90ae5727ae942ac59d53d3405b08dd/app-emulation/lxc/lxc-2.1.1.ebuild

Project Member

Comment 10 by bugdroid1@chromium.org, May 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ae07226a28b1e7879f70d58dbb1e1068522ef072

commit ae07226a28b1e7879f70d58dbb1e1068522ef072
Author: Keith Haddow <haddowk@chromium.org>
Date: Sat May 12 06:22:07 2018

[autotest] Changes required for moblab to work with lxc 2.11

Remove some special case moblab code that allowed it to work
with older versions of lxc

Enable snapshotting.

A new container has been built and uploaded move to that
version of the container.

CQ-DEPEND=CL:1054184
BUG= chromium:794730 
TEST=build and tested on moblab

Change-Id: Ie6dc65ffdcce4056fa31dae4e4bbb8626e3a9aaa
Reviewed-on: https://chromium-review.googlesource.com/1054409
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[modify] https://crrev.com/ae07226a28b1e7879f70d58dbb1e1068522ef072/site_utils/lxc/constants.py
[modify] https://crrev.com/ae07226a28b1e7879f70d58dbb1e1068522ef072/site_utils/lxc/utils.py
[modify] https://crrev.com/ae07226a28b1e7879f70d58dbb1e1068522ef072/moblab_config.ini
[modify] https://crrev.com/ae07226a28b1e7879f70d58dbb1e1068522ef072/site_utils/lxc/lxc.py

Status: Fixed (was: Started)

Sign in to add a comment