No haptic feedback when "Articles aren't available right now" snackbar is displayed |
|||
Issue descriptionApp Version: 65.0.3293.0 canary iOS Version: 10.3.3, 11.2 Device: iPhone7 plus, iPhoneX URL: NA Steps to reproduce: 1. Launch Google Chrome 2. Make sure you see some content suggestions on NewTabPage 3. Turn off internet on the device 4. Scroll the articles list and tap on More button Observed results: Observe that "Articles aren't available right now" snackbar is seen but no haptic feedback Expected results: Present haptic feedback when the snackbar is displayed Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M63 Yes Bug reproducible on the current beta channel build (App Version, iOS Version): M64 Yes
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/809aae3c2f353cdc4615b9f8aabb117d0b9a0e62 commit 809aae3c2f353cdc4615b9f8aabb117d0b9a0e62 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Dec 14 10:57:04 2017 Add haptic feedback for NTP snackbar This CL adds an haptic feedback when presenting the "Articles aren't available right now" snackbar. Bug: 794726 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia96d7128bc85c0adfd09f4a2f8a3bb9d9fc76072 Reviewed-on: https://chromium-review.googlesource.com/826629 Reviewed-by: Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#524038} [modify] https://crrev.com/809aae3c2f353cdc4615b9f8aabb117d0b9a0e62/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
,
Dec 14 2017
,
Dec 19 2017
Verified on chrome canary version 65.0.3299.0 on iPhone 7 with iOS 10.3.3 and iPhone 8 with iOS 11.2. Haptic feedback present when toast message is displayed. |
|||
►
Sign in to add a comment |
|||
Comment 1 by gambard@chromium.org
, Dec 14 2017Status: Assigned (was: Untriaged)