New issue
Advanced search Search tips

Issue 794724 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Task

Blocking:
issue 767625


Show other hotlists

Hotlists containing this issue:
Launcher-Tech-Debt


Sign in to add a comment

Remove Drive app in launcher

Project Member Reported by xiy...@chromium.org, Dec 13 2017

Issue description

The feature is no longer desired. This issue tracks the work to remove the dead code.
 

Comment 1 by xiy...@chromium.org, Dec 13 2017

Blocking: 767625
Since some folks pinged me, this is about removing the Drive app API not the Drive app icon.

Comment 3 by vadimt@chromium.org, Dec 14 2017

Labels: Touch-Friendly-Launcher Touch-Friendly-Launcher-Triaged

Comment 4 by xiy...@chromium.org, Dec 14 2017

This is about removing the connected Drive apps of a user in the launcher, not changing search drive or the "Google Drive" app itself.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e81d6f1bbb48bc2bddb37d955662d34cd9de1823

commit e81d6f1bbb48bc2bddb37d955662d34cd9de1823
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Fri Dec 15 21:31:38 2017

app_list: Remove Drive app in launcher support

- Remove code that shows connected Drive apps in launcher;
- Update AppListSyncableService to remove sync data for those apps;

Bug:  794724 
Change-Id: I4e16df1d1e7dc216114174eae21cfac1b0eec189
Reviewed-on: https://chromium-review.googlesource.com/828026
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524468}
[delete] https://crrev.com/c4dd10518c291c20a9881e6720d8b9a9505c2010/chrome/browser/apps/drive/DEPS
[delete] https://crrev.com/c4dd10518c291c20a9881e6720d8b9a9505c2010/chrome/browser/apps/drive/OWNERS
[delete] https://crrev.com/c4dd10518c291c20a9881e6720d8b9a9505c2010/chrome/browser/apps/drive/drive_app_converter.cc
[delete] https://crrev.com/c4dd10518c291c20a9881e6720d8b9a9505c2010/chrome/browser/apps/drive/drive_app_converter.h
[delete] https://crrev.com/c4dd10518c291c20a9881e6720d8b9a9505c2010/chrome/browser/apps/drive/drive_app_converter_browsertest.cc
[delete] https://crrev.com/c4dd10518c291c20a9881e6720d8b9a9505c2010/chrome/browser/apps/drive/drive_app_mapping.cc
[delete] https://crrev.com/c4dd10518c291c20a9881e6720d8b9a9505c2010/chrome/browser/apps/drive/drive_app_mapping.h
[delete] https://crrev.com/c4dd10518c291c20a9881e6720d8b9a9505c2010/chrome/browser/apps/drive/drive_app_mapping_unittest.cc
[delete] https://crrev.com/c4dd10518c291c20a9881e6720d8b9a9505c2010/chrome/browser/apps/drive/drive_app_provider.cc
[delete] https://crrev.com/c4dd10518c291c20a9881e6720d8b9a9505c2010/chrome/browser/apps/drive/drive_app_provider.h
[delete] https://crrev.com/c4dd10518c291c20a9881e6720d8b9a9505c2010/chrome/browser/apps/drive/drive_app_provider_browsertest.cc
[delete] https://crrev.com/c4dd10518c291c20a9881e6720d8b9a9505c2010/chrome/browser/apps/drive/drive_app_uninstall_sync_service.h
[delete] https://crrev.com/c4dd10518c291c20a9881e6720d8b9a9505c2010/chrome/browser/apps/drive/drive_service_bridge.cc
[delete] https://crrev.com/c4dd10518c291c20a9881e6720d8b9a9505c2010/chrome/browser/apps/drive/drive_service_bridge.h
[modify] https://crrev.com/e81d6f1bbb48bc2bddb37d955662d34cd9de1823/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/e81d6f1bbb48bc2bddb37d955662d34cd9de1823/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/e81d6f1bbb48bc2bddb37d955662d34cd9de1823/chrome/browser/ui/app_list/app_list_syncable_service.cc
[modify] https://crrev.com/e81d6f1bbb48bc2bddb37d955662d34cd9de1823/chrome/browser/ui/app_list/app_list_syncable_service.h
[modify] https://crrev.com/e81d6f1bbb48bc2bddb37d955662d34cd9de1823/chrome/browser/ui/app_list/app_list_syncable_service_factory.cc
[modify] https://crrev.com/e81d6f1bbb48bc2bddb37d955662d34cd9de1823/chrome/browser/ui/app_list/app_list_syncable_service_unittest.cc
[modify] https://crrev.com/e81d6f1bbb48bc2bddb37d955662d34cd9de1823/chrome/test/BUILD.gn
[modify] https://crrev.com/e81d6f1bbb48bc2bddb37d955662d34cd9de1823/ui/app_list/app_list_switches.cc
[modify] https://crrev.com/e81d6f1bbb48bc2bddb37d955662d34cd9de1823/ui/app_list/app_list_switches.h

Comment 6 by xiy...@chromium.org, Dec 15 2017

Status: Fixed (was: Assigned)

Comment 7 by synrg@google.com, Mar 23 2018

Has this change rolled out? The Drive API is still seeing 40K Apps.List QPS coming from ChromeOS: http://shortn/_oT4Sisi6gb

Comment 8 by xiy...@chromium.org, Mar 23 2018

Cc: satorux@chromium.org
CL in #5 is included in 65.0.3296.0. Chrome M65 is pushed to stable 100% this week.

There seems to be another code path in DriveIntegrationService using Drive Apps API,
e.g.
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/drive/drive_integration_service.cc?rcl=2e4b433f9dac35b965e797247b8d15f287cad05c&l=409

Maybe we should also remove DriveAppRegistry from DriveIntegrationService too.

satorux@, what do you think?
DriveAppRegistry is used for Files app to open a file on Drive with a Drive app [1], so I think it should not be removed.

[1] https://cs.chromium.org/chromium/src/chrome/browser/chromeos/file_manager/file_tasks.h?type=cs

Comment 10 by synrg@google.com, Mar 26 2018

As part of fixing b/66499506, the Drive API no longer returns any Apps to ChromeOS for the Apps.List request (https://developers.google.com/drive/v2/reference/apps/list). The code that is calling Apps.List from ChromeOS should be removed since its not serving any purpose except generating empty load on Apiary and our server.
Ah ok. Filed a bug  issue 826090  for cleaning up the code

Sign in to add a comment