Re-enable HighlighterControllerTest.HighlighterGesturesScaled in mash. |
||||||
Issue description"ash_unittests-mash (with patch)" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKgsSBUZsYWtlIh9hc2hfdW5pdHRlc3RzLW1hc2ggKHdpdGggcGF0Y2gpDA. The chromium-try-flakes app is able to file bugs for individual tests when the test launcher is uploading results to the Test Results Server. If recent flakes above are caused by failing tests and you would like to have them filed as invidual bugs, please read more at https://goo.gl/QJKXV4.
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/03844521dc128dfd048d975c4835cf181ba2edbf commit 03844521dc128dfd048d975c4835cf181ba2edbf Author: Henrik Grunell <grunell@chromium.org> Date: Thu Dec 14 13:05:04 2017 Disable flaky HighlighterControllerTest.HighlighterGesturesScaled on ChromeOS. TBR= kaznacheev@chromium.org Bug: 794703 Change-Id: I0a8df88bc3b2e911cafdb05230336e2cc2aa04d3 Reviewed-on: https://chromium-review.googlesource.com/827011 Reviewed-by: Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524050} [modify] https://crrev.com/03844521dc128dfd048d975c4835cf181ba2edbf/ash/highlighter/highlighter_controller_unittest.cc
,
Dec 16 2017
Detected 3 new flakes for test/step "ash_unittests-mash (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKgsSBUZsYWtlIh9hc2hfdW5pdHRlc3RzLW1hc2ggKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
,
Dec 18 2017
Found the immediate cause of the failure. This test is generating touch events tracing a rectangle (PRESSED, MOVED x 4, RELEASE) with 4 different orientation of the default display. The intermittent failure happens after the change from upright rotation to "r" (==clockwise), and it is caused by the 4 MOVED events being lost (or at least failing to reach the handler that is usually getting them). msw@, kylechar@ please advise if this something you have seen happening before
,
Dec 19 2017
I don't know exactly what is wrong with the failure. Any display related code in mash is unfinished so I wouldn't expect it works correctly. The test should probably just be disabled in testing/buildbot/filters/ash_unittests_mash.filter though. The test isn't flaky in ash_unittests or ash_unittests-mus is it? We want coverage there.
,
Dec 19 2017
I sent out https://crrev.com/c/833421 to disable it only in ash_unittests-mash.
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6dd076bc1b9769b4c1a96bc09bccbd1d25e34fe commit d6dd076bc1b9769b4c1a96bc09bccbd1d25e34fe Author: kylechar <kylechar@chromium.org> Date: Tue Dec 19 16:30:21 2017 mash: Disable flaky test only in ash_unittests-mash. HighlighterControllerTest.HighlighterGesturesScaled was disabled everywhere because of flakes in ash_unittests-mash. Re-enable the test and add the test to the ash_unittests-mash filter file to disable it there. Bug: 794703 Change-Id: If0d5f14fd4196178cfc7f769d38548ba423c3f32 Reviewed-on: https://chromium-review.googlesource.com/833421 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#525053} [modify] https://crrev.com/d6dd076bc1b9769b4c1a96bc09bccbd1d25e34fe/ash/highlighter/highlighter_controller_unittest.cc [modify] https://crrev.com/d6dd076bc1b9769b4c1a96bc09bccbd1d25e34fe/testing/buildbot/filters/ash_unittests_mash.filter
,
Dec 19 2017
I'll try to follow up here, thanks.
,
Feb 7 2018
,
Mar 6 2018
Issue 817327 has been merged into this issue.
,
Apr 19 2018
,
Aug 21
This is obsolete |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by grunell@chromium.org
, Dec 14 2017Owner: kaznacheev@chromium.org
Status: Assigned (was: Untriaged)