Let's try to add jumbo build support to //services.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89979a702ff030c2a436b89fadb94d9ea83b3364 commit 89979a702ff030c2a436b89fadb94d9ea83b3364 Author: Mostyn Bramley-Moore <mostynb@vewd.com> Date: Wed Dec 13 23:57:48 2017 [jumbo] avoid kMaxBufferCount collision in //services/video_capture kMaxBufferCount is defined in the anonymous namespace in two places in //services/video_capture, which conflict in jumbo builds. But since each is only used in one location, they can be converted into function statics instead. BUG=794692 Change-Id: Ibf930a73d426ff7ef53fb921ec146952b84bc3de Reviewed-on: https://chromium-review.googlesource.com/825823 Reviewed-by: Christian Fremerey <chfremer@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#523937} [modify] https://crrev.com/89979a702ff030c2a436b89fadb94d9ea83b3364/services/video_capture/device_media_to_mojo_adapter.cc [modify] https://crrev.com/89979a702ff030c2a436b89fadb94d9ea83b3364/services/video_capture/virtual_device_mojo_adapter.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea77ec2bcc3806f86bca27ddac32b5d38a012821 commit ea77ec2bcc3806f86bca27ddac32b5d38a012821 Author: Mostyn Bramley-Moore <mostynb@vewd.com> Date: Thu Dec 14 08:55:08 2017 [jumbo] remove using statement from hid_report_descriptor_unittest.cc This top-level 'using namespace' statement gives -Wheader-hygiene warnings in jumbo builds. BUG=794692 Change-Id: Ifc2aea2f04ca580267f1a02892c13b04b27f7073 Reviewed-on: https://chromium-review.googlesource.com/826222 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524028} [modify] https://crrev.com/ea77ec2bcc3806f86bca27ddac32b5d38a012821/services/device/public/cpp/hid/hid_report_descriptor_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de8b9fb8f030c1227ccc76d07962daab196d32f5 commit de8b9fb8f030c1227ccc76d07962daab196d32f5 Author: Mostyn Bramley-Moore <mostynb@vewd.com> Date: Thu Dec 14 11:29:46 2017 [jumbo] avoid kEpsilon collisions in //services/device/generic_sensor There are several kEpsilon constants defined in //services/device/generic_sensor which conflict in jumbo builds. To avoid this, we can move the definition to generic_sensor_consts.h. BUG=794692 Change-Id: Ib31f20957fc8cccab59abb36779fccff9491239e Reviewed-on: https://chromium-review.googlesource.com/826062 Reviewed-by: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#524043} [modify] https://crrev.com/de8b9fb8f030c1227ccc76d07962daab196d32f5/services/device/generic_sensor/absolute_orientation_euler_angles_fusion_algorithm_using_accelerometer_and_magnetometer_unittest.cc [modify] https://crrev.com/de8b9fb8f030c1227ccc76d07962daab196d32f5/services/device/generic_sensor/generic_sensor_consts.h [modify] https://crrev.com/de8b9fb8f030c1227ccc76d07962daab196d32f5/services/device/generic_sensor/linear_acceleration_fusion_algorithm_using_accelerometer_unittest.cc [modify] https://crrev.com/de8b9fb8f030c1227ccc76d07962daab196d32f5/services/device/generic_sensor/orientation_euler_angles_fusion_algorithm_using_quaternion_unittest.cc [modify] https://crrev.com/de8b9fb8f030c1227ccc76d07962daab196d32f5/services/device/generic_sensor/orientation_quaternion_fusion_algorithm_using_euler_angles_unittest.cc [modify] https://crrev.com/de8b9fb8f030c1227ccc76d07962daab196d32f5/services/device/generic_sensor/orientation_util.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc58510e62a166b31472ec5a8508b1703cb74fe1 commit bc58510e62a166b31472ec5a8508b1703cb74fe1 Author: Mostyn Bramley-Moore <mostynb@vewd.com> Date: Thu Dec 14 14:15:56 2017 [jumbo] avoid GetFusedType/GetSourceType collision orientation_quaternion_fusion_algorithm_using_euler_angles.cc and orientation_euler_angles_fusion_algorithm_using_quaternion.cc both contain GetFusedType and GetSourceType constexpr's with the same argument type, which conflict in jumbo builds. Let's rename them both. BUG=794692 Change-Id: I707873b5e554dba9a98df27a2a5554e355a275c9 Reviewed-on: https://chromium-review.googlesource.com/825862 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Cr-Commit-Position: refs/heads/master@{#524061} [modify] https://crrev.com/bc58510e62a166b31472ec5a8508b1703cb74fe1/services/device/generic_sensor/orientation_euler_angles_fusion_algorithm_using_quaternion.cc [modify] https://crrev.com/bc58510e62a166b31472ec5a8508b1703cb74fe1/services/device/generic_sensor/orientation_quaternion_fusion_algorithm_using_euler_angles.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcf702a4718d6624535269729f990bdf9880a205 commit fcf702a4718d6624535269729f990bdf9880a205 Author: Mostyn Bramley-Moore <mostynb@vewd.com> Date: Thu Dec 14 21:52:59 2017 [jumbo] avoid MockPlatformSensorClient collision fake_platform_sensor_and_provider.h also contains a MockPlatformSensorClient class, which collides in jumbo builds. BUG=794692 Change-Id: Ib3769a25bb0927766757ba5b37ec99fc4f15768f Reviewed-on: https://chromium-review.googlesource.com/827766 Reviewed-by: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#524195} [modify] https://crrev.com/fcf702a4718d6624535269729f990bdf9880a205/services/device/generic_sensor/platform_sensor_and_provider_unittest_linux.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65e7ee161bf05bb3ef840c61d4d2c64d1d7e5433 commit 65e7ee161bf05bb3ef840c61d4d2c64d1d7e5433 Author: Mostyn Bramley-Moore <mostynb@vewd.com> Date: Mon Dec 18 13:38:24 2017 [jumbo] avoid FakeBatteryManager collision in //services/device battery_status_service_unittest.cc also has a FakeBatteryManager class, which collides with this one in jumbo builds. BUG=794692 Change-Id: I9a62f495470e1128dad931df3ea4a815d6c55cf9 Reviewed-on: https://chromium-review.googlesource.com/827765 Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#524695} [modify] https://crrev.com/65e7ee161bf05bb3ef840c61d4d2c64d1d7e5433/services/device/battery/battery_monitor_impl_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b72eeaeb7690cde6515602a713302b25e471593 commit 1b72eeaeb7690cde6515602a713302b25e471593 Author: Mostyn Bramley-Moore <mostynb@vewd.com> Date: Mon Jan 08 20:11:52 2018 [jumbo] avoid symbol clashes in //services/preferences BUG=794692 Change-Id: I0600e8cc2ab81bc80bcaad6026c8ef9a47fcd08c Reviewed-on: https://chromium-review.googlesource.com/842650 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#527728} [modify] https://crrev.com/1b72eeaeb7690cde6515602a713302b25e471593/services/preferences/BUILD.gn [modify] https://crrev.com/1b72eeaeb7690cde6515602a713302b25e471593/services/preferences/persistent_pref_store_impl_unittest.cc [modify] https://crrev.com/1b72eeaeb7690cde6515602a713302b25e471593/services/preferences/pref_service_factory_unittest.cc [modify] https://crrev.com/1b72eeaeb7690cde6515602a713302b25e471593/services/preferences/pref_store_consistency_unittest.cc [modify] https://crrev.com/1b72eeaeb7690cde6515602a713302b25e471593/services/preferences/pref_store_impl_unittest.cc [add] https://crrev.com/1b72eeaeb7690cde6515602a713302b25e471593/services/preferences/unittest_common.cc [add] https://crrev.com/1b72eeaeb7690cde6515602a713302b25e471593/services/preferences/unittest_common.h
Comment 1 by bugdroid1@chromium.org
, Dec 13 2017