New issue
Advanced search Search tips

Issue 794688 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Better NetLog support for connection migration V2

Project Member Reported by zhongyi@chromium.org, Dec 13 2017

Issue description

With connection migration v2, more migration related events are triggered. A better NetLog support is needed to correctly link the migration log and the session log. 

Also more granular NetLogEvents should be added so that we could confirm the migration status in NetLog
 
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79b5f1429095510ed4792a191e9acf0070a6c084

commit 79b5f1429095510ed4792a191e9acf0070a6c084
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Wed Dec 13 23:55:27 2017

Fix missing NetLog OnNetworkMadeDefault, add new NetLogs for migration status after probing.

Bug:  794688 
Change-Id: I2e57bc570e8a8dc249c5fb53f83b561997caab5a
Reviewed-on: https://chromium-review.googlesource.com/825628
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523932}
[modify] https://crrev.com/79b5f1429095510ed4792a191e9acf0070a6c084/net/log/net_log_event_type_list.h
[modify] https://crrev.com/79b5f1429095510ed4792a191e9acf0070a6c084/net/quic/chromium/quic_chromium_client_session.cc

Status: Fixed (was: Assigned)
Close the bug now as we don't have new NetLogEvent to add, we can reopen if there's more NetLogEvent to added. 
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a265a93b7660caa004c48b7bd718c0b905ae0fea

commit a265a93b7660caa004c48b7bd718c0b905ae0fea
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Mon Apr 30 06:40:13 2018

Associate network id in connection migration logs to help bug investigation.

Bug:  794688 
Change-Id: I051882193473490ecf1ea2cc61dbb1459a3f00ea
Reviewed-on: https://chromium-review.googlesource.com/981305
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554701}
[modify] https://crrev.com/a265a93b7660caa004c48b7bd718c0b905ae0fea/net/quic/chromium/quic_chromium_client_session.cc

Sign in to add a comment