[MD Bookmarks] "Show in Folder" doesn't scroll selected folder into view
Reported by
vorak...@gmail.com,
Dec 13 2017
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.84 Safari/537.36 Steps to reproduce the problem: 1. open bookmark manager 2. double click on a folder containing bookmarks and folders 3. right click on a bookmark/folder to try to find the feature What is the expected behavior? In the previous bookmark manager you could right click on a bookmark/folder and click on "show in folder". Then the folder tree would expand the folder, that contains the bookmark/folder, that was clicked on. What went wrong? Missing feature. Did this work before? Yes 62 (the version before the Material Design Bookmark Manager was introduced in 2017) Chrome version: 63.0.3239.84 Channel: stable OS Version: 10.0 Flash Version: 28.0.0.126 Please bring this feature back, it's very useful when searching for bookmark folders.
,
Dec 14 2017
Able to reproduce this issue on reported chrome version 63.0.3239.84 and latest Canary 65.0.3293.0 with steps mentioned in Comment#0 As this issue is seen from introduction of Material Design on Bookmarks from M62, Hence considering this issue as Non-Regression and marking it as Untriaged Could someone from UI>Browser>Bookmarks take a look at this isue Thanks!
,
Dec 14 2017
,
Dec 14 2017
I'm calling this a Regression, as it did work fine in the previous bookmark manager.
,
Dec 14 2017
,
Dec 15 2017
Thanks for the feedback. This feature is still available, and works almost the same in the new bookmark manager as it did in M62. Specifically, - If I right click a bookmark in the list, the 'Show in Folder' option is not available. In the old bookmark manager, the option was visible but disabled, now it's just not visible. - When a search is active, I can right click a bookmark in the search results and select 'Show in Folder'. Doing this opens the containing folder, expands the sidebar tree to show the containing folder, and selects the bookmark within the list. I can see one small behavioural difference between the two versions, which is that we don't scroll the sidebar to make sure that the selected folder is visible. We should fix that.
,
Dec 26 2017
@Comment 6 "When a search is active, I can right click a bookmark in the search results and select 'Show in Folder'. Doing this opens the containing folder, expands the sidebar tree to show the containing folder, and selects the bookmark within the list." - This doesn't work on my PC, but worked in the previous bookmark manager. See screencast.
,
Jan 2 2018
From that screencast, it looks like everything works the same as the old bookmarks manager except focusing the folder. The containing folder is opened, selected in the side and selects the bookmarks in the list. Patch to scroll to the opened folder is incoming.
,
Jan 2 2018
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e6ba8f1eec1a3c84c5580b27e8ed292718301bb commit 7e6ba8f1eec1a3c84c5580b27e8ed292718301bb Author: Christopher Lam <calamity@chromium.org> Date: Mon Jan 08 06:00:22 2018 [MD Bookmarks] Make sidebar scroll to folder node when folder selected. This CL makes the sidebar scroll the selected folder node into view whenever a folder is selected. It also adds a tooltip to folder nodes. Bug: 794684 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ia35556065da78d673974352f58c0deece598de2c Reviewed-on: https://chromium-review.googlesource.com/851395 Reviewed-by: Tim Sergeant <tsergeant@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#527579} [modify] https://crrev.com/7e6ba8f1eec1a3c84c5580b27e8ed292718301bb/chrome/browser/resources/md_bookmarks/folder_node.html [modify] https://crrev.com/7e6ba8f1eec1a3c84c5580b27e8ed292718301bb/chrome/browser/resources/md_bookmarks/folder_node.js
,
Jan 8 2018
,
Jan 23 2018
I don't think that it's fixed. As you can see in the screencast, sometimes "show in folder" doesn't scroll the sidebar. Then you have to doubleclick on the searched folder. I think, this behaviour is ambigious and should be fixed. Might be even a bug from the previous bookmark manager.
,
Jan 24 2018
Are you checking on the latest canary?
,
Jan 24 2018
,
Jan 25 2018
Works well in Canary 66.0.3331.0, also the last use case mentioned (searching for a folder name) works as well. When can we see this in Chrome Stable? Only v66?
,
Jan 29 2018
Should be in M65, which should release early March. Reaches beta in the next few days.
,
Jan 29 2018
@calamity Thank you! Works on latest canary.
,
Jan 30 2018
🍻 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by pbomm...@chromium.org
, Dec 13 2017Labels: Needs-Triage-M63 OS-Linux OS-Mac