Issue metadata
Sign in to add a comment
|
Touch stops working on shelf after using two-finger-touch on any app icon |
||||||||||||||||||||||
Issue descriptionGoogle Chrome 64.0.3282.24 (Official Build) dev (64-bit) Revision 0 Platform 10176.13.0 (Official Build) dev-channel eve What steps will reproduce the problem? 1. Use two-finger-touch on any app icon in shelf 2. Try to use any area of shelf (area having launcher and app icons) using touch What happens ? Touch doesn't work. Reproducible always with above repro step. Feedback report: http://feedback/#/Report/84787417107
,
Dec 14 2017
Is this a regression from M63? Can we identify if that's the case and/or where it derived?
,
Dec 14 2017
Moving this to block stable. Not clear if this is a regression or impact
,
Dec 14 2017
This is a regression. Issue not reproducible on M63 10032.71.1, 63.0.3239.86 beta.
,
Dec 14 2017
,
Dec 14 2017
,
Dec 15 2017
I have a fix for this. Should have it uploaded by tomorrow.
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6ccf92831784c2a3e06f5001ceb3c73c557f77b commit d6ccf92831784c2a3e06f5001ceb3c73c557f77b Author: Alex Newcomer <newcomer@chromium.org> Date: Fri Dec 15 22:55:16 2017 CrOS: Fix two-finger touch on shelf app icons The bug is that after two-finger tapping on an app icon in the shelf, the shelf sometimes becomes unresponsive. This was caused by logic that assumed we wanted to forward all gesture events when the context menu was created with a gesture event. This is fixed by adding a check to see if we are actually dragging an app icon before asking MenuRunner to send events to owner. TEST=manual Bug: 794681 Change-Id: Ib2b764126874f9fd58578a1610a70e2c7881ff78 Reviewed-on: https://chromium-review.googlesource.com/828293 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#524502} [modify] https://crrev.com/d6ccf92831784c2a3e06f5001ceb3c73c557f77b/ash/shelf/shelf_view.cc
,
Dec 15 2017
,
Dec 16 2017
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 18 2017
Approving merge to M64 Chrome OS.
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecfc2a7d28ba52d336a0feca8af28309e129ce5a commit ecfc2a7d28ba52d336a0feca8af28309e129ce5a Author: Alex Newcomer <newcomer@chromium.org> Date: Mon Dec 18 16:51:15 2017 CrOS: Fix two-finger touch on shelf app icons The bug is that after two-finger tapping on an app icon in the shelf, the shelf sometimes becomes unresponsive. This was caused by logic that assumed we wanted to forward all gesture events when the context menu was created with a gesture event. This is fixed by adding a check to see if we are actually dragging an app icon before asking MenuRunner to send events to owner. TEST=manual TBR=newcomer@chromium.org (cherry picked from commit d6ccf92831784c2a3e06f5001ceb3c73c557f77b) Bug: 794681 Change-Id: Ib2b764126874f9fd58578a1610a70e2c7881ff78 Reviewed-on: https://chromium-review.googlesource.com/828293 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#524502} Reviewed-on: https://chromium-review.googlesource.com/832373 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#264} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/ecfc2a7d28ba52d336a0feca8af28309e129ce5a/ash/shelf/shelf_view.cc
,
Dec 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d18bcc120fc9a71de955d4e0b902ee9773c07af8 commit d18bcc120fc9a71de955d4e0b902ee9773c07af8 Author: Alex Newcomer <newcomer@chromium.org> Date: Mon Dec 18 17:16:24 2017 Revert "CrOS: Fix two-finger touch on shelf app icons" This reverts commit ecfc2a7d28ba52d336a0feca8af28309e129ce5a. Reason for revert: Mismatching switch statement included in cherry-pick. Original change's description: > CrOS: Fix two-finger touch on shelf app icons > > The bug is that after two-finger tapping on an app icon in > the shelf, the shelf sometimes becomes unresponsive. > > This was caused by logic that assumed we wanted to forward all > gesture events when the context menu was created with a gesture event. > > This is fixed by adding a check to see if we are actually dragging > an app icon before asking MenuRunner to send events to owner. > > TEST=manual > TBR=newcomer@chromium.org > > (cherry picked from commit d6ccf92831784c2a3e06f5001ceb3c73c557f77b) > > Bug: 794681 > Change-Id: Ib2b764126874f9fd58578a1610a70e2c7881ff78 > Reviewed-on: https://chromium-review.googlesource.com/828293 > Commit-Queue: Alex Newcomer <newcomer@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#524502} > Reviewed-on: https://chromium-review.googlesource.com/832373 > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/branch-heads/3282@{#264} > Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} TBR=xiyuan@chromium.org,newcomer@chromium.org Change-Id: I8227bed9fe2cd7a5ba10065dab2303f582d6ac40 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 794681 Reviewed-on: https://chromium-review.googlesource.com/832946 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#265} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/d18bcc120fc9a71de955d4e0b902ee9773c07af8/ash/shelf/shelf_view.cc
,
Dec 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/792851867529574a68ddf736cf3fb5c5887d7cbb commit 792851867529574a68ddf736cf3fb5c5887d7cbb Author: Alex Newcomer <newcomer@chromium.org> Date: Tue Dec 19 01:35:33 2017 RELAND:CrOS:Fix two-finger touch on shelf app icons The bug is that after two-finger tapping on an app icon in the shelf, the shelf sometimes becomes unresponsive. This was caused by logic that assumed we wanted to forward all gesture events when the context menu was created with a gesture event. This is fixed by adding a check to see if we are actually dragging an app icon before asking MenuRunner to send events to owner. TEST=manual TBR=newcomer@chromium.org (cherry picked from commit d6ccf92831784c2a3e06f5001ceb3c73c557f77b) Bug: 794681 Change-Id: I520aa173d471eb15755eb8bf78309027399a4820 Reviewed-on: https://chromium-review.googlesource.com/828293 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#524502} Reviewed-on: https://chromium-review.googlesource.com/832373 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Original-Commit-Position: refs/branch-heads/3282@{#264} Cr-Original-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} Reviewed-on: https://chromium-review.googlesource.com/832908 Cr-Commit-Position: refs/branch-heads/3282@{#287} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/792851867529574a68ddf736cf3fb5c5887d7cbb/ash/shelf/shelf_view.cc
,
Dec 19 2017
,
Jan 16 2018
10176.52.0, 64.0.3282.97 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by abod...@chromium.org
, Dec 13 2017