New issue
Advanced search Search tips

Issue 794670 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Jan 10
Cc:
no...@chromium.org
vadimsh@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

luci-go doesn't actually pin web dependencies

Project Member Reported by iannucci@chromium.org, Dec 13 2017 
It uses semvers to "pin" them, which has resulted in the luci-go presubmit bot breaking for all tryjobs (e.g. https://ci.chromium.org/p/infra/builds/b8960292924270165664).

Going to remove the web checks from presubmit until this is resolved.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/a21b9ad9cd531004733d698c59b8d8677f411a0c

commit a21b9ad9cd531004733d698c59b8d8677f411a0c
Author: Robert Iannucci <iannucci@chromium.org>
Date: Wed Dec 13 20:39:12 2017

Disable WebChecks in presubmit.

This uses unpinned external dependencies, and so has started breaking
without any commits to this repo :(.

R=nodir@chromium.org, vadimsh@chromium.org

Bug:  794670 
Change-Id: I53ffd3cfd14c7d002e51844443e7ee4d9898e062
Reviewed-on: https://chromium-review.googlesource.com/825590
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/a21b9ad9cd531004733d698c59b8d8677f411a0c/PRESUBMIT.py

Comment 2 by benhenry@google.com, Jan 10

Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.
►

Sign in to add a comment