New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794649 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Migrate CBOR code to //components

Project Member Reported by hongjunchoi@chromium.org, Dec 13 2017

Issue description

Both //content/browser/webauth/cbor is used for //content/browser/webauth and //device/u2f. Migrate CBOR related source code to //components/cbor for code reuse. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f1446c07055c28cb33555c9cd5b53c5eab0b45d

commit 9f1446c07055c28cb33555c9cd5b53c5eab0b45d
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Fri Dec 22 01:04:15 2017

Migrate CBOR to components

Moved source code for CBORValue, CBORWriter, and CBORReader to //components
for that it can be reused for //device and //content/browser.

Bug:  794649 
Change-Id: Ic7ffc0158d5b28048bed810d742f0f385ed57b62
Reviewed-on: https://chromium-review.googlesource.com/825403
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525882}
[modify] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/BUILD.gn
[add] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/BUILD.gn
[add] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/OWNERS
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_binary.h
[add] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_export.h
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader.cc
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader.h
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer.cc
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor0
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor1
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor10
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor11
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor12
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor13
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor14
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor15
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor16
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor17
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor18
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor19
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor2
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor20
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor21
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor22
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor23
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor24
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor25
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor26
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor27
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor28
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor29
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor3
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor30
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor31
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor32
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor33
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor34
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor35
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor36
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor37
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor38
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor39
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor4
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor40
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor41
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor42
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor43
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor44
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor45
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor46
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor47
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor48
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor49
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor5
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor50
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor51
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor52
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor53
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor54
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor55
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor56
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor57
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor58
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor59
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor6
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor60
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor61
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor62
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor63
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor64
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor65
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor66
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor67
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor68
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor69
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor7
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor70
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor71
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor72
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor73
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor74
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor75
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor76
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor77
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor78
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor79
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor8
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor80
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor81
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_fuzzer_corpus/cbor9
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_reader_unittest.cc
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_values.cc
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_values.h
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_values_unittest.cc
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_writer.cc
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_writer.h
[rename] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/components/cbor/cbor_writer_unittest.cc
[modify] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/content/browser/BUILD.gn
[modify] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/content/browser/DEPS
[modify] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/content/browser/webauth/attestation_object.cc
[modify] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/content/browser/webauth/attestation_statement.h
[modify] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/content/browser/webauth/ec_public_key.cc
[modify] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/content/browser/webauth/fido_attestation_statement.cc
[modify] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/content/browser/webauth/fido_attestation_statement.h
[modify] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/content/test/BUILD.gn
[modify] https://crrev.com/9f1446c07055c28cb33555c9cd5b53c5eab0b45d/content/test/fuzzer/BUILD.gn

Status: Fixed (was: Untriaged)

Sign in to add a comment