Autofill constructors should move std::unique_ptrs around instead of passing raw pointers |
||||||
Issue descriptionSee request from Mathieu for more information: https://chromium-review.googlesource.com/c/chromium/src/+/823580/1/components/autofill/core/browser/credit_card_save_manager_unittest.cc#510
,
Dec 22 2017
Is this only for this file?
,
Dec 22 2017
everywhere! :)
,
Dec 22 2017
Everywhere in autofill I suppose!
,
Dec 22 2017
Exactly :)
,
Jan 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/993344ce8d82f5186832b46f3548b6f9e5229fac commit 993344ce8d82f5186832b46f3548b6f9e5229fac Author: Parastoo Geranmayeh <parastoog@google.com> Date: Wed Jan 03 21:11:16 2018 [Autofill] Raw pointers -> Smart pointers. Change some of the autofill constructors to use std::unique_ptrs instead of the raw pointers. Bug: 794647 Change-Id: I364b59e867952dc48a66baf605a4dc23f33e7110 Reviewed-on: https://chromium-review.googlesource.com/843130 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#526813} [modify] https://crrev.com/993344ce8d82f5186832b46f3548b6f9e5229fac/components/autofill/core/browser/credit_card_save_manager_unittest.cc [modify] https://crrev.com/993344ce8d82f5186832b46f3548b6f9e5229fac/components/autofill/core/browser/form_data_importer.h [modify] https://crrev.com/993344ce8d82f5186832b46f3548b6f9e5229fac/components/autofill/core/browser/test_autofill_manager.cc [modify] https://crrev.com/993344ce8d82f5186832b46f3548b6f9e5229fac/components/autofill/core/browser/test_autofill_manager.h [modify] https://crrev.com/993344ce8d82f5186832b46f3548b6f9e5229fac/components/autofill/core/browser/test_form_data_importer.cc [modify] https://crrev.com/993344ce8d82f5186832b46f3548b6f9e5229fac/components/autofill/core/browser/test_form_data_importer.h
,
Jan 3 2018
,
May 1 2018
,
Jul 17
,
Dec 17
,
Dec 18
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by parastoog@chromium.org
, Dec 22 2017Status: Started (was: Available)