"SpeechRecognitionBrowserTest.OneShotRecognition" is flaky |
||||||
Issue description"SpeechRecognitionBrowserTest.OneShotRecognition" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOgsSBUZsYWtlIi9TcGVlY2hSZWNvZ25pdGlvbkJyb3dzZXJUZXN0Lk9uZVNob3RSZWNvZ25pdGlvbgw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Dec 21 2017
Reporting to stale-flakes-reports@google.com to investigate why this issue is not being processed despite being in an appropriate queue for 7 days or more.
,
Dec 21 2017
I'll disable the test for the time being. olka@ could you please triage?
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/419048f6083444f87845c30c78ea1545e8a1abc6 commit 419048f6083444f87845c30c78ea1545e8a1abc6 Author: Mitsuru Oshima <oshima@chromium.org> Date: Thu Dec 21 19:37:21 2017 [Sheriff] Disable flaky SpeechRecognitionBrowserTest.OneShotRecognition test on mac BUG=794645 TEST=None TBR=olka@chromium.org, rogerm@chromium.org Change-Id: I88ec23c4841b4079f747e525a8e60ab20b725c92 Reviewed-on: https://chromium-review.googlesource.com/840605 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#525770} [modify] https://crrev.com/419048f6083444f87845c30c78ea1545e8a1abc6/content/browser/speech/speech_recognition_browsertest.cc
,
Dec 22 2017
Removing from sheriff queue as test is disabled and bug assigned.
,
Jan 4 2018
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fmac_chromium_rel_ng%2F471382%2F%2B%2Frecipes%2Fsteps%2Fcontent_browsertests__with_patch_%2F0%2Flogs%2FSpeechRecognitionBrowserTest.OneShotRecognition%2F0: [ RUN ] SpeechRecognitionBrowserTest.OneShotRecognition [63200:771:0515/154045.710364:14470751281802:WARNING:audio_manager.cc(260)] Multiple instances of AudioManager detected [63200:771:0515/154045.710526:14470751431015:WARNING:audio_system.cc(22)] Multiple instances of AudioSystem detected [63201:771:0515/154045.712091:14470753001976:WARNING:vt_video_decode_accelerator_mac.cc(178)] Failed to create VTDecompressionSession: Error Domain=NSOSStatusErrorDomain Code=-8973 "The operation couldn?t be completed. (OSStatus error -8973.)" (codecOpenErr) (-8973) [63201:771:0515/154045.713568:14470754477761:WARNING:vt_video_decode_accelerator_mac.cc(200)] Failed to create hardware VideoToolbox session [63201:771:0515/154045.797776:14470838687477:ERROR:vt_video_encode_accelerator_mac.cc(495)] VTCompressionSessionCreate failed: -12908 [63200:771:0515/154046.329752:14471370663274:FATAL:speech_recognizer_impl.cc(272)] Check failed: ::content::BrowserThread::CurrentlyOn(BrowserThread::IO). Must be called on Chrome_IOThread; actually called on CrBrowserMain. 0 content_browsertests 0x000000010c75ba5c base::debug::StackTrace::StackTrace(unsigned long) + 28 1 content_browsertests 0x000000010c784b10 logging::LogMessage::~LogMessage() + 224 2 content_browsertests 0x000000010b39675d content::SpeechRecognizerImpl::~SpeechRecognizerImpl() + 241 3 content_browsertests 0x000000010b3968e8 content::SpeechRecognizerImpl::~SpeechRecognizerImpl() + 14 4 content_browsertests 0x000000010b399948 base::internal::BindState<void (content::SpeechRecognizerImpl::*)(media::AudioInputController*), scoped_refptr<content::SpeechRecognizerImpl>, base::internal::RetainedRefWrapper<media::AudioInputController> >::Destroy(base::internal::BindStateBase const*) + 32 5 content_browsertests 0x000000010c75c3ce base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 318 6 content_browsertests 0x000000010c79c679 base::MessageLoop::RunTask(base::PendingTask*) + 441 7 content_browsertests 0x000000010c79ca2f base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 31 8 content_browsertests 0x000000010c79cce3 base::MessageLoop::DoWork() + 371 9 content_browsertests 0x000000010c7a1970 base::MessagePumpCFRunLoopBase::RunWork() + 48 10 content_browsertests 0x000000010c78660a base::mac::CallWithEHFrame(void () block_pointer) + 10 11 content_browsertests 0x000000010c7a11ef base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 63 12 CoreFoundation 0x00007fff9311a5b1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 13 CoreFoundation 0x00007fff9310bc62 __CFRunLoopDoSources0 + 242 14 CoreFoundation 0x00007fff9310b3ef __CFRunLoopRun + 831 15 CoreFoundation 0x00007fff9310ae75 CFRunLoopRunSpecific + 309 16 HIToolbox 0x00007fff8ace8a0d RunCurrentEventLoopInMode + 226 17 HIToolbox 0x00007fff8ace87b7 ReceiveNextEventCommon + 479 18 HIToolbox 0x00007fff8ace85bc _BlockUntilNextEventMatchingListInModeWithFilter + 65 19 AppKit 0x00007fff8ec7d24e _DPSNextEvent + 1434 20 AppKit 0x00007fff8ec7c89b -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 122 21 AppKit 0x00007fff8ec7099c -[NSApplication run] + 553 22 content_browsertests 0x000000010c7a23d7 base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 359 23 content_browsertests 0x000000010c7a1767 base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 119 24 content_browsertests 0x000000010c79c3b2 base::MessageLoop::RunHandler() + 290 25 content_browsertests 0x000000010c7d24c7 base::RunLoop::Run() + 151 26 content_browsertests 0x000000010c33e6a5 content::RunThisRunLoop(base::RunLoop*) + 53 27 content_browsertests 0x000000010c33f195 content::MessageLoopRunner::Run() + 119 28 content_browsertests 0x000000010c30aff8 content::NavigateToURLBlockUntilNavigationsComplete(content::Shell*, GURL const&, int) + 79 29 content_browsertests 0x000000010a8a0a62 content::SpeechRecognitionBrowserTest_OneShotRecognition_Test::RunTestOnMainThread() + 104 30 content_browsertests 0x000000010c318c11 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 399 31 content_browsertests 0x000000010c3a70e7 content::ShellBrowserMainParts::PreMainMessageLoopRun() + 217 32 content_browsertests 0x000000010af01cdf content::BrowserMainLoop::PreMainMessageLoopRun() + 69 33 content_browsertests 0x000000010b2e8fed content::StartupTaskRunner::RunAllTasksNow() + 29 34 content_browsertests 0x000000010af00486 content::BrowserMainLoop::CreateStartupTasks() + 624 35 content_browsertests 0x000000010af0486a content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 652 36 content_browsertests 0x000000010c3a6c5a ShellBrowserMain(content::MainFunctionParams const&, std::__1::unique_ptr<content::BrowserMainRunner, std::__1::default_delete<content::BrowserMainRunner> > const&) + 32 37 content_browsertests 0x000000010c376457 content::ShellMainDelegate::RunProcess(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&) + 169 38 content_browsertests 0x000000010ae0630b content::RunNamedProcessTypeMain(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, content::MainFunctionParams const&, content::ContentMainDelegate*) + 229 39 content_browsertests 0x000000010ae06d97 content::ContentMainRunnerImpl::Run() + 1049 40 content_browsertests 0x000000010dbbf3b9 service_manager::Main(service_manager::MainParams const&) + 1781 41 content_browsertests 0x000000010ae06206 content::ContentMain(content::ContentMainParams const&) + 69 42 content_browsertests 0x000000010c318961 content::BrowserTestBase::SetUp() + 1765 43 content_browsertests 0x000000010c30a962 content::ContentBrowserTest::SetUp() + 726 44 content_browsertests 0x000000010c28aa99 testing::Test::Run() + 97 45 content_browsertests 0x000000010c28b4a9 testing::TestInfo::Run() + 219 46 content_browsertests 0x000000010c28ba56 testing::TestCase::Run() + 258 47 content_browsertests 0x000000010c2907d0 testing::internal::UnitTestImpl::RunAllTests() + 694 48 content_browsertests 0x000000010c2904f8 testing::UnitTest::Run() + 108 49 content_browsertests 0x000000010c355826 base::TestSuite::Run() + 138 50 content_browsertests 0x000000010c30e3f5 content::ContentTestLauncherDelegate::RunTestSuite(int, char**) + 41 51 content_browsertests 0x000000010c33a89f content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) + 391 52 content_browsertests 0x000000010c30e3a8 main + 74 53 libdyld.dylib 0x00007fff877835fd start + 1 54 ??? 0x0000000000000009 0x0 + 9
,
Jan 4 2018
the first known flake is 2017-05-15 16:57:42 UTC
,
Mar 30 2018
It looks like all we need to do to fix this is make SpeechRecognizer a base::RefCountedThreadSafe<SpeechRecognizer, BrowserThread::DeleteOnIOThread> instead of just a base::RefCountedThreadSafe<SpeechRecognizer>. Do we really care so little about speech recognition integration tests that no one has looked into this apparently fairly simple fix for the last four months?
,
Mar 30 2018
Sorry - that should have been phrased a bit more politely, just a bit surprised to see of the only two browser_tests for speech recognition, one is disabled everywhere (And was apparently never looked into), and the other is disabled on OSX, and no one looked into that, either.
,
Apr 3 2018
mmenke@ - if you could upload a patch for review, that would be a huge help for us. Thanks!
,
Aug 3
This bug has an owner, thus, it's been triaged. Changing status to "assigned". |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by brat...@opera.com
, Dec 14 2017