Copying Peter who worked on this last to comment. 

In CFM/HMH product, we intend to enable this for Fizz.

+posciak@ for VEA wiring state of the world, I think it's present if not already enabled for VP8 through VEA. Not sure what the state of the world is for VP9 but we I believe VAAPI VP9 single-stream quality was better than WebRTC-configured  (realtime + quality levels) libvpx VP9.

After working with Intel we got VP8 over VAAPI at decent quality (comparable to software/Kepler), it didn't have per-temporal-layer bitrate controls at the time, but that's never been wired up to Kepler which has been running for years.

No tests were done for screencast content, so YMMV.

pbos@:
> I think it's present if not already enabled for VP8 through VEA. 

Neither VP8 nor VP9 are wired or enabled in VaVEA. Like I said in
the description, VaVEA seems on a first pass that would support 
formats beyond h264, but it has many h264-specific vaapi structures
and function calls.

pbos@ showed me a cool video, linking here for completion (internal
url, sorry!) 
https://pbos.users.x20web.corp.google.com/www/vaapi-vp8-before-after/index.html

This is marked Mac but it sounds like it's about ChromeOS? -Mac +ChromeOS

Can this be Assigned or Available, instead of Untriaged? Assigning to mcasas to decide what the state should be.

#6: correct CrOs, not Mac. Don't know how that happened :-P

My crrev.com/2768783002 is the first stage of the redesign that makes VaapiVEA codec-agnostic and addresses the above comments.

I also have a follow up CL that I planned to publish subsequently, which adds VPx encoding classes.

Given the above, I agree it should be useful to revisit this work. Taking over. Thank you!

WIP CLs are now published at:

https://chromium-review.googlesource.com/c/chromium/src/+/918701
https://chromium-review.googlesource.com/c/chromium/src/+/918702

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/225f8a53bf7c21ab23f274e1741870609b6c01aa

commit 225f8a53bf7c21ab23f274e1741870609b6c01aa
Author: Erik Språng <sprang@chromium.org>
Date: Thu Apr 19 15:14:57 2018

Add feature flag for enabling vaapi vp8 encoding

Currently, chromeos builds with vp8 encoding disabled in vaapi.
We would like to change this to always be built, but have control over
when to enable it, using a feature flag, until we have verified
performance and quality is up to speed.

Bug:  chromium:794608 
Change-Id: I2bc41dd7d34b3156e7b37f4d84272261da895e62
Reviewed-on: https://chromium-review.googlesource.com/1016905
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Språng <sprang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552022}
[modify] https://crrev.com/225f8a53bf7c21ab23f274e1741870609b6c01aa/content/public/common/content_features.cc
[modify] https://crrev.com/225f8a53bf7c21ab23f274e1741870609b6c01aa/content/public/common/content_features.h

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/566124a6df20995484868fdaef524c85e3faa7c5

commit 566124a6df20995484868fdaef524c85e3faa7c5
Author: Erik Språng <sprang@webrtc.org>
Date: Mon Apr 23 15:31:27 2018

Move BitrateAllocation to api/ and rename it VideoBitrateAllocation

Since the webrtc_common build target does not have visibility set, we
cannot easily use BitrateAllocation in other parts of Chromium.
This is currently blocking parts of chromium:794608, and I know of other
usage outside webrtc already, so moving it to api/ should be warranted.

Also, since there's some naming confusion and this class is video
specific rename it VideoBitrateAllocation. This also fits with the
standard interface for producing these: VideoBitrateAllocator.

Bug:  chromium:794608 
Change-Id: I4c0fae40f9365e860c605a76a4f67ecc9b9cf9fe
Reviewed-on: https://webrtc-review.googlesource.com/70783
Reviewed-by: Karl Wiberg <kwiberg@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22986}
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/BUILD.gn
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/api/BUILD.gn
[add] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/api/video/video_bitrate_allocation.cc
[add] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/api/video/video_bitrate_allocation.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/api/video_codecs/video_encoder.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/api/video_codecs/video_encoder.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/call/call_perf_tests.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/common_types.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/common_types.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/common_video/include/video_bitrate_allocator.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/media/engine/fakewebrtcvideoengine.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/media/engine/scopedvideoencoder.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/media/engine/simulcast_encoder_adapter.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/media/engine/simulcast_encoder_adapter.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/media/engine/simulcast_encoder_adapter_unittest.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/media/engine/videoencodersoftwarefallbackwrapper.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/media/engine/videoencodersoftwarefallbackwrapper.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/media/engine/videoencodersoftwarefallbackwrapper_unittest.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/media/engine/vp8_encoder_simulcast_proxy.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/media/engine/vp8_encoder_simulcast_proxy.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/rtp_rtcp/include/rtp_rtcp.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/rtp_rtcp/source/rtcp_receiver.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/rtp_rtcp/source/rtcp_sender.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/rtp_rtcp/source/rtcp_sender.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/rtp_rtcp/source/rtcp_sender_unittest.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/rtp_rtcp/source/rtcp_transceiver_config.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/rtp_rtcp/source/rtcp_transceiver_impl.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/rtp_rtcp/source/rtcp_transceiver_impl_unittest.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/rtp_rtcp/source/rtp_rtcp_impl.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/rtp_rtcp/source/rtp_rtcp_impl.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/h264/h264_encoder_impl.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/h264/h264_encoder_impl.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/multiplex/include/multiplex_encoder_adapter.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/multiplex/multiplex_encoder_adapter.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/test/videoprocessor.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/test/videoprocessor_unittest.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/vp8/libvpx_vp8_encoder.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/vp8/libvpx_vp8_encoder.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/vp8/simulcast_rate_allocator.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/vp8/simulcast_rate_allocator.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/vp9/svc_rate_allocator.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/vp9/svc_rate_allocator.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/vp9/svc_rate_allocator_unittest.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/vp9/test/vp9_impl_unittest.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/vp9/vp9_impl.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/codecs/vp9/vp9_impl.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/generic_encoder.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/generic_encoder.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/include/mock/mock_video_codec_interface.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/utility/default_video_bitrate_allocator.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/utility/default_video_bitrate_allocator.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/utility/default_video_bitrate_allocator_unittest.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/utility/simulcast_rate_allocator_unittest.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/video_codec_initializer_unittest.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/video_sender.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/modules/video_coding/video_sender_unittest.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/sdk/android/src/jni/androidmediaencoder.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/sdk/android/src/jni/videoencoderwrapper.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/sdk/android/src/jni/videoencoderwrapper.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/test/configurable_frame_size_encoder.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/test/configurable_frame_size_encoder.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/test/encoder_proxy_factory.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/test/fake_encoder.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/test/fake_encoder.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/video/end_to_end_tests/bandwidth_tests.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/video/payload_router.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/video/payload_router.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/video/payload_router_unittest.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/video/video_send_stream_impl.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/video/video_send_stream_impl.h
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/video/video_send_stream_tests.cc
[modify] https://crrev.com/566124a6df20995484868fdaef524c85e3faa7c5/video/video_stream_encoder_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e12dcaa75c4081e0e2794c82d519f4c3d391bde

commit 3e12dcaa75c4081e0e2794c82d519f4c3d391bde
Author: webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Apr 23 22:30:24 2018

Roll src/third_party/webrtc/ 25acef756..9b20677c4 (11 commits)

https://webrtc.googlesource.com/src.git/+log/25acef756b46..9b20677c4e71

$ git log 25acef756..9b20677c4 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None,chromium:794608,chromium:None,chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I22b580b563ed372ef59f62ef133432c79920d755
Reviewed-on: https://chromium-review.googlesource.com/1024397
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#552864}
[modify] https://crrev.com/3e12dcaa75c4081e0e2794c82d519f4c3d391bde/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/607c8bc07346ec2faa6d10be6057ba630ec23ba9

commit 607c8bc07346ec2faa6d10be6057ba630ec23ba9
Author: Ilya Nikolaevskiy <ilnik@chromium.org>
Date: Tue May 08 11:14:37 2018

Add experimental support for HW vaapi vp8 encoding

This CL adds origin trial implementation and forwards it to
RtcPeerConnectionHander. The flag should be forwarded further down to
actual video codec selection in the later CL.

Intention to experiment:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/vp8/blink-dev/vbYCDv5ve5w/pq-uV_QRAwAJ

Bug:  794608 
Change-Id: I5c50a2b402bea720b57e8ebb2a36a261fb512743
Reviewed-on: https://chromium-review.googlesource.com/1030173
Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556753}
[modify] https://crrev.com/607c8bc07346ec2faa6d10be6057ba630ec23ba9/content/renderer/media/webrtc/mock_web_rtc_peer_connection_handler_client.h
[modify] https://crrev.com/607c8bc07346ec2faa6d10be6057ba630ec23ba9/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/607c8bc07346ec2faa6d10be6057ba630ec23ba9/third_party/blink/public/platform/web_rtc_peer_connection_handler_client.h
[modify] https://crrev.com/607c8bc07346ec2faa6d10be6057ba630ec23ba9/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
[modify] https://crrev.com/607c8bc07346ec2faa6d10be6057ba630ec23ba9/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.h
[modify] https://crrev.com/607c8bc07346ec2faa6d10be6057ba630ec23ba9/third_party/blink/renderer/platform/runtime_enabled_features.json5
[modify] https://crrev.com/607c8bc07346ec2faa6d10be6057ba630ec23ba9/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e08e8bdfa1754c8c5e13feaa3608b348f8750f05

commit e08e8bdfa1754c8c5e13feaa3608b348f8750f05
Author: Pawel Osciak <posciak@chromium.org>
Date: Mon May 21 00:42:17 2018

Add AcceleratedVideoEncoder API, H264Encoder impl, and a VA-API accelerator.

An AcceleratedVideoEncoder (AVE) is a video encoder that performs high-level,
platform-independent encoding process steps, such as managing codec state,
reference frames, etc., but requires support from an external Accelerator
(typically a hardware accelerator) to offload the actual image encoding
process, using the parameters that AVE prepares beforehand.

Clients of AVEs are expected to provide an Accelerator class instance
appropriate for current platform and/or scenario. Each video codec-specific
AVE specifies its own Accelerator interface (e.g. a H264Encoder AVE defines
an H264-specific Accelerator).

This CL adds the AVE API, a platform-independent implementation of AVE for
H264 - H264Encoder, as well as a VA-API implementation of
H264Encoder::Accelerator to provide an accelerator for it.

BUG= 703988 , 794608 
TEST=veaunittest,apprtc,vdaunittest

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iaf50f3a83df4ed51c81bb8a4c0e1152af82515e1
Reviewed-on: https://chromium-review.googlesource.com/918701
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560213}
[modify] https://crrev.com/e08e8bdfa1754c8c5e13feaa3608b348f8750f05/content/renderer/media/webrtc/rtc_video_encoder.cc
[modify] https://crrev.com/e08e8bdfa1754c8c5e13feaa3608b348f8750f05/media/filters/h264_bitstream_buffer.cc
[modify] https://crrev.com/e08e8bdfa1754c8c5e13feaa3608b348f8750f05/media/filters/h264_bitstream_buffer.h
[modify] https://crrev.com/e08e8bdfa1754c8c5e13feaa3608b348f8750f05/media/filters/h264_bitstream_buffer_unittest.cc
[modify] https://crrev.com/e08e8bdfa1754c8c5e13feaa3608b348f8750f05/media/gpu/v4l2/v4l2_video_encode_accelerator.cc
[modify] https://crrev.com/e08e8bdfa1754c8c5e13feaa3608b348f8750f05/media/gpu/vaapi/BUILD.gn
[add] https://crrev.com/e08e8bdfa1754c8c5e13feaa3608b348f8750f05/media/gpu/vaapi/accelerated_video_encoder.cc
[add] https://crrev.com/e08e8bdfa1754c8c5e13feaa3608b348f8750f05/media/gpu/vaapi/accelerated_video_encoder.h
[add] https://crrev.com/e08e8bdfa1754c8c5e13feaa3608b348f8750f05/media/gpu/vaapi/h264_encoder.cc
[add] https://crrev.com/e08e8bdfa1754c8c5e13feaa3608b348f8750f05/media/gpu/vaapi/h264_encoder.h
[modify] https://crrev.com/e08e8bdfa1754c8c5e13feaa3608b348f8750f05/media/gpu/vaapi/vaapi_video_encode_accelerator.cc
[modify] https://crrev.com/e08e8bdfa1754c8c5e13feaa3608b348f8750f05/media/gpu/vaapi/vaapi_video_encode_accelerator.h
[modify] https://crrev.com/e08e8bdfa1754c8c5e13feaa3608b348f8750f05/media/gpu/vaapi/vaapi_wrapper.cc
[modify] https://crrev.com/e08e8bdfa1754c8c5e13feaa3608b348f8750f05/media/gpu/vaapi/vaapi_wrapper.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13de15aef0201ceae4ea203aceb0e0986ab5a8bf

commit 13de15aef0201ceae4ea203aceb0e0986ab5a8bf
Author: Pawel Osciak <posciak@chromium.org>
Date: Mon May 21 05:48:25 2018

Add an AcceleratedVideoEncoder for VP8 and a VA-API accelerator for it.

Add VP8Encoder, an implementation of AcceleratedVideoEncoder interface
for VP8, and a VA-API implementation of VP8Encoder::Accelerator.

Also introduce Vp8ReferenceFrameVector, to share reference frame
management code between encoder and decoder classes.

BUG= 703988 , 794608 
TEST=veaunittest,apprtc,vdaunittest

Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7aa9bd9c110bf936728c2a5dab85649ca3328ed6
Reviewed-on: https://chromium-review.googlesource.com/918702
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560234}
[modify] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/filters/vp8_parser.cc
[modify] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/filters/vp8_parser.h
[modify] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/gpu/BUILD.gn
[modify] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/gpu/v4l2/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/gpu/vaapi/BUILD.gn
[modify] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/gpu/vaapi/vaapi_video_encode_accelerator.cc
[modify] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/gpu/vaapi/vaapi_video_encode_accelerator.h
[modify] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/gpu/vaapi/vaapi_vp8_accelerator.cc
[modify] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/gpu/vaapi/vaapi_vp8_accelerator.h
[add] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/gpu/vaapi/vp8_encoder.cc
[add] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/gpu/vaapi/vp8_encoder.h
[modify] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/gpu/vp8_decoder.cc
[modify] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/gpu/vp8_decoder.h
[modify] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/gpu/vp8_picture.cc
[add] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/gpu/vp8_reference_frame_vector.cc
[add] https://crrev.com/13de15aef0201ceae4ea203aceb0e0986ab5a8bf/media/gpu/vp8_reference_frame_vector.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f2ea7d95ecf85209ffb2d7a1712614dfdc1cf2f

commit 7f2ea7d95ecf85209ffb2d7a1712614dfdc1cf2f
Author: Erik Språng <sprang@chromium.org>
Date: Mon May 21 09:46:41 2018

Wire up webrtc::RateAllocation to RtcVideoEncoder.

This will be necessary in order to properly use temporal and spatial
scalability in hardware accelerated video codecs.

Bug:  chromium:794608 
Change-Id: I029e044a33c95eb4bcc9db04b028d04a3cb7f922
Reviewed-on: https://chromium-review.googlesource.com/1016900
Commit-Queue: Erik Språng <sprang@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560254}
[modify] https://crrev.com/7f2ea7d95ecf85209ffb2d7a1712614dfdc1cf2f/content/renderer/BUILD.gn
[modify] https://crrev.com/7f2ea7d95ecf85209ffb2d7a1712614dfdc1cf2f/content/renderer/media/webrtc/rtc_video_encoder.cc
[modify] https://crrev.com/7f2ea7d95ecf85209ffb2d7a1712614dfdc1cf2f/content/renderer/media/webrtc/rtc_video_encoder.h
[modify] https://crrev.com/7f2ea7d95ecf85209ffb2d7a1712614dfdc1cf2f/media/base/BUILD.gn
[add] https://crrev.com/7f2ea7d95ecf85209ffb2d7a1712614dfdc1cf2f/media/base/video_bitrate_allocation.cc
[add] https://crrev.com/7f2ea7d95ecf85209ffb2d7a1712614dfdc1cf2f/media/base/video_bitrate_allocation.h
[add] https://crrev.com/7f2ea7d95ecf85209ffb2d7a1712614dfdc1cf2f/media/base/video_bitrate_allocation_unittest.cc
[modify] https://crrev.com/7f2ea7d95ecf85209ffb2d7a1712614dfdc1cf2f/media/video/video_encode_accelerator.cc
[modify] https://crrev.com/7f2ea7d95ecf85209ffb2d7a1712614dfdc1cf2f/media/video/video_encode_accelerator.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/267ef3465088d4d1bd324c0cc85cfb40819e4ff8

commit 267ef3465088d4d1bd324c0cc85cfb40819e4ff8
Author: Miguel Casas <mcasas@chromium.org>
Date: Wed May 23 17:54:36 2018

VP8Decoder: simplify logic

This Cl follows up on a discussion on [1] by simplifying the logic of
a conditional.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/918702/10/media/gpu/vp8_decoder.cc#137

Bug:  703988 , 794608 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I890ab7fa742ff63e6b8ccf57221e2b90648a1fd7
Reviewed-on: https://chromium-review.googlesource.com/1069189
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561151}
[modify] https://crrev.com/267ef3465088d4d1bd324c0cc85cfb40819e4ff8/media/gpu/vp8_decoder.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a5765c2454032415a64cb8c7fd6a900278a5d9a

commit 4a5765c2454032415a64cb8c7fd6a900278a5d9a
Author: Pawel Osciak <posciak@chromium.org>
Date: Wed May 23 23:20:47 2018

Add a feature flag for VA-API VP8 video encoder.

Add a feature flag to enable VA-API-based VP8 hardware video encode
acceleration.

BUG= 794608 
TEST=run Chrome with feature disabled/enabled, verify availability

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5866d7b158a071ea94b06d49453af1ec85ba3e2e
Reviewed-on: https://chromium-review.googlesource.com/1068905
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561303}
[modify] https://crrev.com/4a5765c2454032415a64cb8c7fd6a900278a5d9a/media/base/media_switches.cc
[modify] https://crrev.com/4a5765c2454032415a64cb8c7fd6a900278a5d9a/media/base/media_switches.h
[modify] https://crrev.com/4a5765c2454032415a64cb8c7fd6a900278a5d9a/media/gpu/vaapi/vaapi_wrapper.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eed0f1819ec478854385e6f7649a031af09c60c9

commit eed0f1819ec478854385e6f7649a031af09c60c9
Author: Erik Språng <sprang@chromium.org>
Date: Fri May 25 13:51:49 2018

Initial wireup of VideoBitrateAllocation in VaapiVideoEncodeAccelerator.

This is a first step just to get the allocation signal down into the
VP8 encoder. Temporal layer handling will follow upcoming CLs.

Bug:  chromium:794608 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie0a120a7b906dc5218834e355d3acf8c4f24ac36
Reviewed-on: https://chromium-review.googlesource.com/1065898
Commit-Queue: Erik Språng <sprang@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561853}
[modify] https://crrev.com/eed0f1819ec478854385e6f7649a031af09c60c9/media/base/video_bitrate_allocation.cc
[modify] https://crrev.com/eed0f1819ec478854385e6f7649a031af09c60c9/media/base/video_bitrate_allocation.h
[modify] https://crrev.com/eed0f1819ec478854385e6f7649a031af09c60c9/media/base/video_bitrate_allocation_unittest.cc
[modify] https://crrev.com/eed0f1819ec478854385e6f7649a031af09c60c9/media/gpu/vaapi/accelerated_video_encoder.h
[modify] https://crrev.com/eed0f1819ec478854385e6f7649a031af09c60c9/media/gpu/vaapi/h264_encoder.cc
[modify] https://crrev.com/eed0f1819ec478854385e6f7649a031af09c60c9/media/gpu/vaapi/h264_encoder.h
[modify] https://crrev.com/eed0f1819ec478854385e6f7649a031af09c60c9/media/gpu/vaapi/vaapi_video_encode_accelerator.cc
[modify] https://crrev.com/eed0f1819ec478854385e6f7649a031af09c60c9/media/gpu/vaapi/vaapi_video_encode_accelerator.h
[modify] https://crrev.com/eed0f1819ec478854385e6f7649a031af09c60c9/media/gpu/vaapi/vp8_encoder.cc
[modify] https://crrev.com/eed0f1819ec478854385e6f7649a031af09c60c9/media/gpu/vaapi/vp8_encoder.h
[modify] https://crrev.com/eed0f1819ec478854385e6f7649a031af09c60c9/media/video/video_encode_accelerator.cc

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68

commit 97b4ee5b4c311bcb28ad941e7b50c4668d8aea68
Author: Ilya Nikolaevskiy <ilnik@webrtc.org>
Date: Mon May 28 12:30:19 2018

Wire up VAAPI VP8 experimental support in WebRTC.

Experiment flag added to PeerConnectionInterface::RtcConfiguration and
propagated down to VideoStreamEncoder.

Artificial Sdp parameter is added to the sdp format if the flag is set.

Additionally, sdp format is propagated in vp8 simulcast adapters.

Bug:  chromium:794608 
Change-Id: I2dec54d19ae7bfbd5f2777ec682da5a84194da94
Reviewed-on: https://webrtc-review.googlesource.com/78500
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Reviewed-by: Fredrik Solenberg <solenberg@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23412}
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/api/peerconnectioninterface.h
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/api/video_codecs/builtin_video_encoder_factory.cc
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/call/video_send_stream.h
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/media/base/mediaconfig.h
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/media/engine/convert_legacy_video_factory.cc
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/media/engine/fakewebrtcvideoengine.cc
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/media/engine/simulcast_encoder_adapter.cc
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/media/engine/simulcast_encoder_adapter.h
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/media/engine/simulcast_encoder_adapter_unittest.cc
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/media/engine/vp8_encoder_simulcast_proxy.cc
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/media/engine/vp8_encoder_simulcast_proxy.h
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/media/engine/vp8_encoder_simulcast_proxy_unittest.cc
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/media/engine/webrtcvideoengine.cc
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/modules/video_coding/codecs/test/videocodec_test_fixture_impl.cc
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/pc/peerconnectioninterface_unittest.cc
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/video/picture_id_tests.cc
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/video/video_quality_test.cc
[modify] https://crrev.com/97b4ee5b4c311bcb28ad941e7b50c4668d8aea68/video/video_stream_encoder.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/316df9add71ee84385b702f002fef1bda7ceda7b

commit 316df9add71ee84385b702f002fef1bda7ceda7b
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue May 29 13:04:26 2018

Roll src/third_party/webrtc/ b3085b288..2aae2733a (23 commits)

https://webrtc.googlesource.com/src.git/+log/b3085b288b17..2aae2733a70c

$ git log b3085b288..2aae2733a --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None,chromium:None,chromium:844647,chromium:845158,chromium:794608,chromium:None,chromium:None,chromium:None,chromium:845158


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I8a13060bf81727a06eb046ff9c6ef9b18b4a9876
Reviewed-on: https://chromium-review.googlesource.com/1075864
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#562399}
[modify] https://crrev.com/316df9add71ee84385b702f002fef1bda7ceda7b/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7528f61826297790f35cf7886a9909865de23baf

commit 7528f61826297790f35cf7886a9909865de23baf
Author: Pawel Osciak <posciak@chromium.org>
Date: Mon Jun 04 06:29:06 2018

Enable VA-API-based HW VP8 encoding by default.

Flip the VaapiVP8Encoder flag to enable VA-API based HW VP8 encoder by
default.

BUG= 794608 
TEST=veatest, apprtc

Change-Id: If99f825788786dc4cc2be8c4f7a3908d04023368
Reviewed-on: https://chromium-review.googlesource.com/1080436
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564004}
[modify] https://crrev.com/7528f61826297790f35cf7886a9909865de23baf/media/base/media_switches.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/bde75f5bfeb01a6478bbeb5649ce8b72768fa291

commit bde75f5bfeb01a6478bbeb5649ce8b72768fa291
Author: Hirokazu Honda <hiroh@chromium.org>
Date: Thu Jun 07 23:52:25 2018

autotest-capability: Add VP8 HW encoding capability to BSW/SKL/APL/KBL

BSW/SKL/APL/KBL have VP8 HW encoding capability in hardware level.
However, since chrome user-space doesn't have the functionality for VP8 HW
encdoing, their VP8 HW encdoing capabilities are disabled by
https://crosreview.com/384195.
As of now, thanks to https://crrev.com/c/918702, VP8 HW encdoing would be
enabled on them.

BUG= chromium:794608 
TEST=video_VideoEncodeAccelerator
CQ-DEPEND=CL:1072215

Change-Id: I937c089b2d1c9d8b604c2f1aa2dd871382fe76f5
Reviewed-on: https://chromium-review.googlesource.com/1065717
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>

[modify] https://crrev.com/bde75f5bfeb01a6478bbeb5649ce8b72768fa291/chipset-skl/chromeos-base/autotest-capability-chipset-skl/files/15-chipset-skl-capabilities.yaml
[rename] https://crrev.com/bde75f5bfeb01a6478bbeb5649ce8b72768fa291/chipset-apl/chromeos-base/autotest-capability-chipset-apl/autotest-capability-chipset-apl-1.0.2.ebuild
[rename] https://crrev.com/bde75f5bfeb01a6478bbeb5649ce8b72768fa291/chipset-kbl/chromeos-base/autotest-capability-chipset-kbl/autotest-capability-chipset-kbl-1.0.2.ebuild
[modify] https://crrev.com/bde75f5bfeb01a6478bbeb5649ce8b72768fa291/chipset-bsw/chromeos-base/autotest-capability-chipset-bsw/files/15-chipset-bsw-capabilities.yaml
[rename] https://crrev.com/bde75f5bfeb01a6478bbeb5649ce8b72768fa291/chipset-skl/chromeos-base/autotest-capability-chipset-skl/autotest-capability-chipset-skl-1.0.2.ebuild
[modify] https://crrev.com/bde75f5bfeb01a6478bbeb5649ce8b72768fa291/chipset-apl/chromeos-base/autotest-capability-chipset-apl/files/15-chipset-apl-capabilities.yaml
[rename] https://crrev.com/bde75f5bfeb01a6478bbeb5649ce8b72768fa291/chipset-bsw/chromeos-base/autotest-capability-chipset-bsw/autotest-capability-chipset-bsw-1.0.2.ebuild
[modify] https://crrev.com/bde75f5bfeb01a6478bbeb5649ce8b72768fa291/chipset-kbl/chromeos-base/autotest-capability-chipset-kbl/files/15-chipset-kbl-capabilities.yaml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/297233b7f0711237c58395584284146a1420815a

commit 297233b7f0711237c58395584284146a1420815a
Author: Pawel Osciak <posciak@chromium.org>
Date: Thu Jun 07 23:52:25 2018

libva-intel-driver: reenable VA-API VP8 encoder

As support for VA-API VP8 encoder landed in Chrome
(https://chromium-review.googlesource.com/c/chromium/src/+/918702)
this is now controlled by a Chrome feature flag "VaapiVP8Encoder".

TEST=veatest
BUG= chromium:794608 
CQ-DEPEND=CL:1065717

Change-Id: Iebedce790b5f9876d8b03fc18697d95fd43d2e6b
Reviewed-on: https://chromium-review.googlesource.com/1072215
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>

[delete] https://crrev.com/42171bf685a553f328965982cb2437660bd51c75/x11-libs/libva-intel-driver/files/disable_vp8_encoding.patch
[rename] https://crrev.com/297233b7f0711237c58395584284146a1420815a/x11-libs/libva-intel-driver/libva-intel-driver-2.1.0-r5.ebuild
[modify] https://crrev.com/297233b7f0711237c58395584284146a1420815a/x11-libs/libva-intel-driver/libva-intel-driver-2.1.0.ebuild

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1e30ed8c7503fc61852e3f46f225cfea75271d2

commit e1e30ed8c7503fc61852e3f46f225cfea75271d2
Author: Ilya Nikolaevskiy <ilnik@chromium.org>
Date: Tue Jun 12 07:34:28 2018

Remove obsolete kWebRtcVaapiHWVP8Encoding feature flag and origin trial

It ended up not used anywhere (a separate media switch is used instead).

Bug:  chromium:794608 
Change-Id: I84c502dabb1e1e59b541983643ea3c09bffd1b30
Reviewed-on: https://chromium-review.googlesource.com/1092574
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566351}
[modify] https://crrev.com/e1e30ed8c7503fc61852e3f46f225cfea75271d2/content/public/common/content_features.cc
[modify] https://crrev.com/e1e30ed8c7503fc61852e3f46f225cfea75271d2/content/public/common/content_features.h
[modify] https://crrev.com/e1e30ed8c7503fc61852e3f46f225cfea75271d2/content/renderer/media/webrtc/mock_web_rtc_peer_connection_handler_client.h
[modify] https://crrev.com/e1e30ed8c7503fc61852e3f46f225cfea75271d2/third_party/blink/public/platform/web_feature.mojom
[modify] https://crrev.com/e1e30ed8c7503fc61852e3f46f225cfea75271d2/third_party/blink/public/platform/web_rtc_peer_connection_handler_client.h
[modify] https://crrev.com/e1e30ed8c7503fc61852e3f46f225cfea75271d2/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
[modify] https://crrev.com/e1e30ed8c7503fc61852e3f46f225cfea75271d2/third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.h
[modify] https://crrev.com/e1e30ed8c7503fc61852e3f46f225cfea75271d2/third_party/blink/renderer/platform/runtime_enabled_features.json5

I would like to request merge for https://chromium-review.googlesource.com/1072215 to M68 please.

This would not change functionality in default builds as this is disabled via a feature flag.

Thank you!

We can merge this though it seems like the idea is that it does not do anything, I am not clear on why we would need to merge it.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1feb3c9c8644afd0e20b7f93e0ffaa1658845c60

commit 1feb3c9c8644afd0e20b7f93e0ffaa1658845c60
Author: Pawel Osciak <posciak@chromium.org>
Date: Wed Jun 13 00:42:58 2018

libva-intel-driver: reenable VA-API VP8 encoder

As support for VA-API VP8 encoder landed in Chrome
(https://chromium-review.googlesource.com/c/chromium/src/+/918702)
this is now controlled by a Chrome feature flag "VaapiVP8Encoder".

TEST=veatest
BUG= chromium:794608 
CQ-DEPEND=CL:1065717

Change-Id: Iebedce790b5f9876d8b03fc18697d95fd43d2e6b
Reviewed-on: https://chromium-review.googlesource.com/1072215
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
(cherry picked from commit 297233b7f0711237c58395584284146a1420815a)
Reviewed-on: https://chromium-review.googlesource.com/1098355
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Tested-by: Pawel Osciak <posciak@chromium.org>
Trybot-Ready: Pawel Osciak <posciak@chromium.org>

[delete] https://crrev.com/332f89bd68f01c957c21643cc72e32a3296beef1/x11-libs/libva-intel-driver/files/disable_vp8_encoding.patch
[modify] https://crrev.com/1feb3c9c8644afd0e20b7f93e0ffaa1658845c60/x11-libs/libva-intel-driver/libva-intel-driver-2.1.0.ebuild
[rename] https://crrev.com/1feb3c9c8644afd0e20b7f93e0ffaa1658845c60/x11-libs/libva-intel-driver/libva-intel-driver-2.1.0-r4.ebuild

Thank you! This should allow testing by manually overriding the flag.

The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/fc9dcb6a00a9dd390c24745371356eab4fe2ad92

commit fc9dcb6a00a9dd390c24745371356eab4fe2ad92
Author: Ilya Nikolaevskiy <ilnik@webrtc.org>
Date: Fri Jun 15 10:04:07 2018

Remove wire-up for cancelled experement on VAAPI VP8 encoding

This experiment is now wired up inside of chrome using field trial and
this passthrough is now obsolete.

Bug:  chromium:794608 
Change-Id: I1407e391d39c7e8696add9f656f059e7d8a27a08
Reviewed-on: https://webrtc-review.googlesource.com/82780
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Reviewed-by: Erik Språng <sprang@webrtc.org>
Reviewed-by: Niels Moller <nisse@webrtc.org>
Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23625}
[modify] https://crrev.com/fc9dcb6a00a9dd390c24745371356eab4fe2ad92/api/peerconnectioninterface.h
[modify] https://crrev.com/fc9dcb6a00a9dd390c24745371356eab4fe2ad92/call/video_send_stream.h
[modify] https://crrev.com/fc9dcb6a00a9dd390c24745371356eab4fe2ad92/media/base/mediaconfig.h
[modify] https://crrev.com/fc9dcb6a00a9dd390c24745371356eab4fe2ad92/media/engine/webrtcvideoengine.cc
[modify] https://crrev.com/fc9dcb6a00a9dd390c24745371356eab4fe2ad92/pc/peerconnectioninterface_unittest.cc
[modify] https://crrev.com/fc9dcb6a00a9dd390c24745371356eab4fe2ad92/video/video_stream_encoder.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45ed56cd257e74356285318956d3fdf0437324d0

commit 45ed56cd257e74356285318956d3fdf0437324d0
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jun 15 15:49:09 2018

Roll src/third_party/webrtc 8643b78750bb..e61d72b37c64 (6 commits)

https://webrtc.googlesource.com/src.git/+log/8643b78750bb..e61d72b37c64


git log 8643b78750bb..e61d72b37c64 --date=short --no-merges --format='%ad %ae %s'
2018-06-15 yinwa@webrtc.org Disables congestion window in pacer when CongestionWindowPushback is enabled.
2018-06-15 nisse@webrtc.org Delete an unneeded include of pathutils.h.
2018-06-15 ilnik@webrtc.org Remove wire-up for cancelled experement on VAAPI VP8 encoding
2018-06-15 danilchap@webrtc.org Replace rtc::Optional with absl::optional in modules/rtp_rtcp
2018-06-15 nisse@webrtc.org Delete unused methods on rtc::Pathname.
2018-06-15 magjed@webrtc.org Android: Add helper class for generating OpenGL shaders


Created with:
  gclient setdep -r src/third_party/webrtc@e61d72b37c64

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

// Everything green except for purple bot (unrelated failure).
NOTRY=True

BUG=chromium:None,chromium:794608
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia01ef0d0f498f78587fc27878cf7da12596641ea
Reviewed-on: https://chromium-review.googlesource.com/1102402
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567658}
[modify] https://crrev.com/45ed56cd257e74356285318956d3fdf0437324d0/DEPS

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b6bda3c362eb47961aa18db0fa78363f5c65d75

commit 7b6bda3c362eb47961aa18db0fa78363f5c65d75
Author: Pawel Osciak <posciak@chromium.org>
Date: Fri Aug 03 01:15:37 2018

Revert "Enable VA-API-based HW VP8 encoding by default."

This reverts commit 7528f61826297790f35cf7886a9909865de23baf.

Reason for revert: disable the feature by default while related issues are being investigated (b/111781384).

Original change's description:
> Enable VA-API-based HW VP8 encoding by default.
>
> Flip the VaapiVP8Encoder flag to enable VA-API based HW VP8 encoder by
> default.
>
> BUG= 794608 
> TEST=veatest, apprtc
>
> Change-Id: If99f825788786dc4cc2be8c4f7a3908d04023368
> Reviewed-on: https://chromium-review.googlesource.com/1080436
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Pawel Osciak <posciak@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564004}

TBR=posciak@chromium.org,xhwang@chromium.org,sandersd@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  794608 ,b:111781384
Change-Id: I35232863ca5b96285994cb03553548b0b72ff169
Reviewed-on: https://chromium-review.googlesource.com/1160181
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580402}
[modify] https://crrev.com/7b6bda3c362eb47961aa18db0fa78363f5c65d75/media/base/media_switches.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cde93ca43f6b10bf65f5b315ce78da8f7f4cc72e

commit cde93ca43f6b10bf65f5b315ce78da8f7f4cc72e
Author: Pawel Osciak <posciak@chromium.org>
Date: Tue Aug 07 23:36:15 2018

Revert "Enable VA-API-based HW VP8 encoding by default."

This reverts commit 7528f61826297790f35cf7886a9909865de23baf.

Reason for revert: disable the feature by default while related issues are being investigated (b/111781384).

Original change's description:
> Enable VA-API-based HW VP8 encoding by default.
>
> Flip the VaapiVP8Encoder flag to enable VA-API based HW VP8 encoder by
> default.
>
> BUG= 794608 
> TEST=veatest, apprtc
>
> Change-Id: If99f825788786dc4cc2be8c4f7a3908d04023368
> Reviewed-on: https://chromium-review.googlesource.com/1080436
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Pawel Osciak <posciak@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564004}

TBR=posciak@chromium.org,xhwang@chromium.org,sandersd@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  794608 ,b:111781384
Change-Id: I35232863ca5b96285994cb03553548b0b72ff169
Reviewed-on: https://chromium-review.googlesource.com/1160181
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580402}(cherry picked from commit 7b6bda3c362eb47961aa18db0fa78363f5c65d75)
Reviewed-on: https://chromium-review.googlesource.com/1166302
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#479}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/cde93ca43f6b10bf65f5b315ce78da8f7f4cc72e/media/base/media_switches.cc

cde93ca43f6b10bf65f5b315ce78da8f7f4cc72e was merged to refs/branch-heads/3497 branch with no merge approval from a TPM! 

Please explain why this change was merged to the branch!

I can see merge approval for M68 but not M69. Thanks!
 

Merge approval for revert in M69 of the original CL, which was approved here for M68, was given in b/111781384.

I'm sorry for any confusion, should I have requested separately here? Thanks!

Please explicit request merge approval for all branches on the "crbug" issue the CL is associated with. Since the merge for M69 was approved, we are all good here.

FYI: crbug.com/811912 is the issue tracker for HW VP9 encoder on Chrome OS intel platform.