Issue metadata
Sign in to add a comment
|
New RC.exe in v64 have problems with BMP resources having incorrect size alignment |
||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.97 Safari/537.36 Vivaldi/1.94.1008.36 Steps to reproduce the problem: 1. Add a BMP with a bad alignment (it is supposed to be 4 byte alignment for the data) as a background resource for setup.rc (or other resource file). In this case this is a background for the Vivaldi Browser installer. 2. try to build (customized) setup.exe using new rc.py tool 3. What is the expected behavior? 1) The chromium rc.exe and Visual Studio rc.exe outputs should match 2) (when ignoring toolwrapper assert) The resulting executable should link What went wrong? 1) There is a 2 byte mismatch between the two rc.exe version' output, triggering an assert in the toolwrapper and build failure 2) Linking the executable results in Link error about corrupt files and "CVTRES : fatal error CVT1110: resource type or name string exceeds limit of 65535" Did this work before? Yes 63.0.3202.84 Chrome version: 64.0.3282.22 Channel: dev OS Version: 10.0 Flash Version: Nico Weber have already analyzed and fixed the issue in https://github.com/nico/hack/commit/76cb2fde80f9bab0bfb4e4e57bdabb26577c6aab According to my information the tool used to create and/or convert the file to BMP was Photoshop on Mac. For reference, our git history shows that the image file increased by two bytes in an update in 2015, don't know the reason for this increase, this size was kept when updated earlier in 2017. At present I have hardcoded an override to use the Visual Studio rc.exe output instead for this rc file.
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e611f8193870af6243afe04c8845c2dda01b752 commit 8e611f8193870af6243afe04c8845c2dda01b752 Author: Nico Weber <thakis@chromium.org> Date: Wed Dec 13 22:16:15 2017 Update prebuilt rc binary. CL created by running build/toolchain/win/rc/upload_rc_binaries.sh Picks up https://github.com/nico/hack/commit/76cb2fde80f9bab0bfb4e4e57bdabb26577c6aab Bug: 794598 Change-Id: I1a735b761f2cb14cb8f2f44276af373f9e2acf5e Reviewed-on: https://chromium-review.googlesource.com/825003 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#523905} [modify] https://crrev.com/8e611f8193870af6243afe04c8845c2dda01b752/build/toolchain/win/rc/linux64/rc.sha1 [modify] https://crrev.com/8e611f8193870af6243afe04c8845c2dda01b752/build/toolchain/win/rc/mac/rc.sha1 [modify] https://crrev.com/8e611f8193870af6243afe04c8845c2dda01b752/build/toolchain/win/rc/win/rc.exe.sha1
,
Dec 14 2017
,
Dec 14 2017
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 15 2017
Approving merge to M64. Branch:3282
,
Dec 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f60ecddbdee912b5e0e333d5fea8dff489947c5 commit 4f60ecddbdee912b5e0e333d5fea8dff489947c5 Author: Nico Weber <thakis@chromium.org> Date: Sun Dec 17 21:41:16 2017 Update prebuilt rc binary. CL created by running build/toolchain/win/rc/upload_rc_binaries.sh Picks up https://github.com/nico/hack/commit/76cb2fde80f9bab0bfb4e4e57bdabb26577c6aab Bug: 794598 Change-Id: I1a735b761f2cb14cb8f2f44276af373f9e2acf5e Reviewed-on: https://chromium-review.googlesource.com/825003 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#523905}(cherry picked from commit 8e611f8193870af6243afe04c8845c2dda01b752) Reviewed-on: https://chromium-review.googlesource.com/830728 Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#256} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/4f60ecddbdee912b5e0e333d5fea8dff489947c5/build/toolchain/win/rc/linux64/rc.sha1 [modify] https://crrev.com/4f60ecddbdee912b5e0e333d5fea8dff489947c5/build/toolchain/win/rc/mac/rc.sha1 [modify] https://crrev.com/4f60ecddbdee912b5e0e333d5fea8dff489947c5/build/toolchain/win/rc/win/rc.exe.sha1
,
Dec 17 2017
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by thakis@chromium.org
, Dec 13 2017Status: Started (was: Unconfirmed)