Single tap should show controls instead
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de3407c6445d640e385c80f7a7190197e262f6b1 commit de3407c6445d640e385c80f7a7190197e262f6b1 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Dec 19 11:18:52 2017 Media Controls: Single tap on controls Single tap on controls to toggle the UI instead of play/pause. BUG= 794592 Change-Id: I887a706b62911ff396b109e678ea82badafb712a Reviewed-on: https://chromium-review.googlesource.com/824842 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#524997} [modify] https://crrev.com/de3407c6445d640e385c80f7a7190197e262f6b1/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-outside.html [modify] https://crrev.com/de3407c6445d640e385c80f7a7190197e262f6b1/third_party/WebKit/LayoutTests/media/controls/modern/slow-doubletap.html [add] https://crrev.com/de3407c6445d640e385c80f7a7190197e262f6b1/third_party/WebKit/LayoutTests/media/controls/modern/tap-to-hide-controls.html [modify] https://crrev.com/de3407c6445d640e385c80f7a7190197e262f6b1/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/de3407c6445d640e385c80f7a7190197e262f6b1/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [modify] https://crrev.com/de3407c6445d640e385c80f7a7190197e262f6b1/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h [modify] https://crrev.com/de3407c6445d640e385c80f7a7190197e262f6b1/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp [modify] https://crrev.com/de3407c6445d640e385c80f7a7190197e262f6b1/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cc0d5f531c963b56b9fbe5c8b4d976cd3ecf137 commit 7cc0d5f531c963b56b9fbe5c8b4d976cd3ecf137 Author: Christian Dullweber <dullweber@chromium.org> Date: Tue Dec 19 12:53:26 2017 Revert "Media Controls: Single tap on controls" This reverts commit de3407c6445d640e385c80f7a7190197e262f6b1. Reason for revert: slow-doubletap.html is broken on Linux Trusty Leak https://crbug.com/796146 Original change's description: > Media Controls: Single tap on controls > > Single tap on controls to toggle the UI instead of play/pause. > > BUG= 794592 > > Change-Id: I887a706b62911ff396b109e678ea82badafb712a > Reviewed-on: https://chromium-review.googlesource.com/824842 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524997} TBR=mlamouri@chromium.org,beccahughes@chromium.org Change-Id: Ib473978163a570048841b7385386d6cc13d47588 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 794592 , 796146 Reviewed-on: https://chromium-review.googlesource.com/832688 Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#525007} [modify] https://crrev.com/7cc0d5f531c963b56b9fbe5c8b4d976cd3ecf137/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-outside.html [modify] https://crrev.com/7cc0d5f531c963b56b9fbe5c8b4d976cd3ecf137/third_party/WebKit/LayoutTests/media/controls/modern/slow-doubletap.html [delete] https://crrev.com/6e55908f30a0c20f61f51de0581cd97f859243a5/third_party/WebKit/LayoutTests/media/controls/modern/tap-to-hide-controls.html [modify] https://crrev.com/7cc0d5f531c963b56b9fbe5c8b4d976cd3ecf137/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/7cc0d5f531c963b56b9fbe5c8b4d976cd3ecf137/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [modify] https://crrev.com/7cc0d5f531c963b56b9fbe5c8b4d976cd3ecf137/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h [modify] https://crrev.com/7cc0d5f531c963b56b9fbe5c8b4d976cd3ecf137/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp [modify] https://crrev.com/7cc0d5f531c963b56b9fbe5c8b4d976cd3ecf137/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2da3918ec370e7f6c5c0ca75482be514b02b1203 commit 2da3918ec370e7f6c5c0ca75482be514b02b1203 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Jan 02 11:47:03 2018 Reland: Media Controls: Single tap on controls Single tap on controls to toggle the UI instead of play/pause. BUG= 794592 Change-Id: Idfc6ea6eb1ade43344955a48512385db083a06ba Reviewed-on: https://chromium-review.googlesource.com/833915 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#526462} [modify] https://crrev.com/2da3918ec370e7f6c5c0ca75482be514b02b1203/third_party/WebKit/LayoutTests/media/controls/modern/singletap-on-outside.html [modify] https://crrev.com/2da3918ec370e7f6c5c0ca75482be514b02b1203/third_party/WebKit/LayoutTests/media/controls/modern/slow-doubletap.html [add] https://crrev.com/2da3918ec370e7f6c5c0ca75482be514b02b1203/third_party/WebKit/LayoutTests/media/controls/modern/tap-to-hide-controls.html [modify] https://crrev.com/2da3918ec370e7f6c5c0ca75482be514b02b1203/third_party/WebKit/LayoutTests/media/media-controls.js [modify] https://crrev.com/2da3918ec370e7f6c5c0ca75482be514b02b1203/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp [modify] https://crrev.com/2da3918ec370e7f6c5c0ca75482be514b02b1203/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h [modify] https://crrev.com/2da3918ec370e7f6c5c0ca75482be514b02b1203/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.cpp [modify] https://crrev.com/2da3918ec370e7f6c5c0ca75482be514b02b1203/third_party/WebKit/Source/modules/media_controls/elements/MediaControlOverlayPlayButtonElement.h
Comment 1 by beccahughes@chromium.org
, Dec 13 2017