Add monochrome sanity check test for monochrome_public_apk |
||
Issue descriptionA similar check already exists downstream. We should add this check upstream. Specifically: * Call it //chrome/android/monochrome/monochrome_apk_checker.py * Invoke it via: chrome/android/monochrome/monochrome_apk_checker.py --chrome-apk out/Release/apks/ChromePublicModern.apk --system-webview-apk out/Release/apks/SystemWebview.apk --monochrome-apk out/Release/apks/MonochromePublic.apk * Add it to an android release bot by following instructions here: https://chromium.googlesource.com/chromium/src/+/ecd1b5af57c7ed18e1f351976ee7ef513ba75a6b/testing/buildbot/README.md
,
Dec 13 2017
I have a fix in progress for fixing the incremental flakiness of pak files (bug 785576). Good point about not enabling this until that's resolved. AFAICT, should be safe once that's fixed (were there other non-determinisms other than .pak?)
,
Dec 13 2017
We shouldn't change the comparison rules, we should just wait to enable this until we've fixed the known issues and then treat any newly found issues as bugs - incremental builds should produce identical output to clean builds.
,
Dec 21 2017
Which android release bot is appropriate for this?
,
Dec 21 2017
I'd go for linux_android_rel_ng.
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3813fab1752ac76f43bc35eb38bda21538793b8 commit f3813fab1752ac76f43bc35eb38bda21538793b8 Author: Mohamed Heikal <mheikal@google.com> Date: Wed Mar 07 14:00:45 2018 Trybots: Adds monochrome_apk_checker sanity check to upstream trybots Upstreamed monochrome_apk_checker.py script and set it up so that it is now run by linux_android_rel_ng Bug: 794585 Change-Id: Ie8e4d7c60c4907122e3fa200e3765e7aa733a1ad Reviewed-on: https://chromium-review.googlesource.com/938282 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#541420} [modify] https://crrev.com/f3813fab1752ac76f43bc35eb38bda21538793b8/chrome/android/monochrome/BUILD.gn [add] https://crrev.com/f3813fab1752ac76f43bc35eb38bda21538793b8/chrome/android/monochrome/scripts/monochrome_apk_checker.py [add] https://crrev.com/f3813fab1752ac76f43bc35eb38bda21538793b8/chrome/android/monochrome/scripts/monochrome_apk_checker_wrapper.py [modify] https://crrev.com/f3813fab1752ac76f43bc35eb38bda21538793b8/testing/buildbot/chromium.android.json [modify] https://crrev.com/f3813fab1752ac76f43bc35eb38bda21538793b8/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/f3813fab1752ac76f43bc35eb38bda21538793b8/testing/buildbot/test_suites.pyl [modify] https://crrev.com/f3813fab1752ac76f43bc35eb38bda21538793b8/testing/buildbot/waterfalls.pyl
,
Mar 7 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/clank/internal/apps/+/2e665ccac29d7d7b72fee380bfcd24b298743de1 commit 2e665ccac29d7d7b72fee380bfcd24b298743de1 Author: Mohamed Heikal <mheikal@google.com> Date: Wed Mar 07 16:37:57 2018
,
Mar 8 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by michaelbai@chromium.org
, Dec 13 2017