Unable to add Telemetry failure artifact |
||||||
Issue description
Link to log:
Traceback (most recent call last):
RunBenchmark at c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\story_runner.py:366
max_num_values=benchmark.MAX_NUM_VALUES)
Run at c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\story_runner.py:231
_RunStoryAndProcessErrorIfNeeded(story, results, state, test)
_RunStoryAndProcessErrorIfNeeded at c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\story_runner.py:141
ProcessError(exc)
ProcessError at c:\b\s\w\ir\third_party\catapult\telemetry\telemetry\internal\story_runner.py:115
results.AddArtifactFromPageRun(page, 'minidump', minidump_path)
AttributeError: 'PageTestResults' object has no attribute 'AddArtifactFromPageRun'
Reverting the responsible CL (https://chromium-review.googlesource.com/c/catapult/+/772831) now.
,
Dec 13 2017
Kicking down to P2 now that the revert is in progress
,
Dec 13 2017
I will work on fixing this instead.
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/a51f10541a1cd8f6bc96b0f7e9366ef651680769 commit a51f10541a1cd8f6bc96b0f7e9366ef651680769 Author: Nghia Nguyen <nednguyen@google.com> Date: Wed Dec 13 18:34:10 2017 Fix wrong method call in handling app crash error Bug: chromium:794577 Change-Id: I24f62714a6c744360341f3748823ada8a61a4b20 Reviewed-on: https://chromium-review.googlesource.com/824910 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/a51f10541a1cd8f6bc96b0f7e9366ef651680769/telemetry/telemetry/internal/story_runner.py [modify] https://crrev.com/a51f10541a1cd8f6bc96b0f7e9366ef651680769/telemetry/telemetry/testing/fakes/__init__.py [modify] https://crrev.com/a51f10541a1cd8f6bc96b0f7e9366ef651680769/telemetry/telemetry/internal/story_runner_unittest.py
,
Dec 13 2017
Should be fixed. Feel free to reopen
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by charliea@chromium.org
, Dec 13 2017