Turning on ‘Article suggestions’ will not display content suggestions in NTP |
|||||
Issue descriptionApp Version: 64.0.3282.26 Beta iOS Version: 10.3.3, 11.2 Device: iOS and iPad Steps to reproduce: 1. Fresh install and launch chrome 2. Once content suggestions are displayed go to privacy and clear browsing data 3. Open NTP and Tap on more button 4. Once content suggestions are displayed, go to settings 4. Turn off Article suggestions 5. Turn on Article suggestions 6. Open NTP Observed results: Notice content suggestions are not displayed by itself. Note 1: On Force quit content suggestions load automatically Note 2: Switching on Article suggestion usually displays content suggestions without tapping more button Expected results: Turning Article suggestions to on should display content suggestions by itself Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): Not on M63(Feature is available from M64) Bug reproducible on the current beta channel build (App Version, iOS Version): Yes on M64 Beta Link to video/image: Content suggestions doesn’t load: https://drive.google.com/file/d/1FmhvM3urEbwTwcmy1w9p-n2XO_B8LDCf/view?usp=sharing Article suggestions usual behavior: https://drive.google.com/file/d/1picUtpRBJbH1llvjeyl9p33YaM7xEPGv/view?usp=sharing
,
Dec 14 2017
jkrcal@: If think this is WAI? My guess would be that we don't fetch new suggestions for 30min after clearing the history.
,
Dec 14 2017
Hmm, this is a known issue. The reason is that we never cache the results of the "More" fetch. The problem above is avoided on Android by the following trick: When there are no suggestions available, the "More" button actually triggers ContentSuggestionsService::ReloadSuggestions(). Can you implement this on iOS as well, please?
,
Dec 14 2017
,
Dec 14 2017
I see. Then it WAI, I think. rakurati@: - does the problem happen if you skip steps 2-3? - what happens if you additionally: 6. Open NTP and Tap on more button 7. Close the NTP and open another NTP. Do you after step 7 see the suggestions? I could change the code so that clearing suggestions at step 4 clears the "30 minute no-fetch guard" that is added in step 2. Still, it does not make much sense to me.
,
Dec 14 2017
-does the problem happen if you skip steps 2-3? No, there is no problem on skipping steps 2-3 - what happens if you additionally: On adding your steps to comment#0 steps, I see content suggestions after step7.
,
Dec 14 2017
,
Dec 19 2017
Assigning to jkrcal@ so you can close it if it is indeed WAI. Please reassign if you think something is needed.
,
Dec 22 2017
This behavior is a result of complex product requirements. Although not ideal, there is no simple fix that would still honor the requirements. A complicated fix does not seem worth the effort, given the repro steps seem rare. Please re-open if you think the opposite. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sczs@chromium.org
, Dec 13 2017Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)