Issue metadata
Sign in to add a comment
|
3.3% regression in loading.desktop at 522550:522657 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Dec 13 2017
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14b60f52040000
,
Dec 13 2017
๐ Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14b60f52040000 cc: Alter duration used in prioritizing impl latency in Scheduler. By khushalsagar@chromium.org ยท Thu Dec 07 22:46:18 2017 chromium @ ee432e360c202a47eaf132b33d7c88155f52b6d6 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jan 22 2018
khushalsagar: Any progress on this bug? It looks like your CL regressed page load time for one page on Win 8. +kouhei, owner of the loading benchmarks: is this worth pursuing?
,
Jan 22 2018
Hmmm, looking at the traces before and after the change, it looks like we used to skip a main frame *before* the change landed and we don't anymore. So there's 3 main frames before a long running task from "StreamingCompleteOnBackgroundThread". The change in #3 alters the heuristics for deciding whether we skip frames for latency recovery, but I don't think this is one of the cases where we intended to do this. Brian, anything I might be missing here?
,
Jan 23 2018
Kushal's patch likely bought some improvements to first meaningful paint and latency on other pages: https://chromeperf.appspot.com/group_report?rev=522582 The extra main frame could have improved this case if that main frame were to result in the first meaningful paint. Unfortunately there's a race with something that kicks off the ScriptStreamerThread that looks like it eventually results in the "StreamingCompleteOnBackgroundThread". Detecting one case from the other isn't possible from the compositor thread where Kushal's logic lives. I wonder if we could increase the priority of ScriptStreamerThread instead? +skyostil Otherwise, I think we should close as WontFix.
,
Jan 24 2018
Closing this. skyostil@, feel free to file a bug if there is something we could improve in main thread scheduling from this case. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Dec 13 2017