Regression: Unable to paste text on multiple cells on google sheets.
Reported by
aiman.an...@etouch.net,
Dec 13 2017
|
|||||||||||||
Issue descriptionChrome Version: 65.0.3293.0 (Official Build) (cohort: Clang-64)5d03c84689520e76673121751641d53314db60a7-refs/heads/master@{#523641} (32/64-bit) OS: Win(7,8,10), Mac(10.12.6, 10.13.1, 10.13.2), Linux(14.04 LTS). Steps to reproduce: 1.Launch Chrome, Login to Google sheets and open a blank spreadsheet. 2.Select multiple cells, paste any text and observe. Actual Result: Unable to paste text on multiple cells on google sheets. Expected Result: Should be able to paste text on multiple cells. This is regression issue broken in ‘M-65’ and below per-revision bisect result Using the per-revision bisect providing the bisect results, Good Build: 65.0.3292.0(Revision:523291). Bad Build: 65.0.3293.0(Revision:523641). You are probably looking for a change made after 523465 (known good),but no later than 523466 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perfbuilds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/209e1a6cd617341da941589d9357e6f3498b4d2e..9ede1cb83532b5bb6a5bafdc44af302e5bca6c8a Suspect: https://chromium.googlesource.com/chromium/src/+/9ede1cb83532b5bb6a5bafdc44af302e5bca6c8a @hidehiko:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
,
Dec 13 2017
Adding RB Label as this is a recent Regression. Please remove if not required. Thank You.
,
Dec 13 2017
Unassigned myself. Re #0: The culprit CL is just removing unused gmock class only for chromeos. I'm sure it is unrelated, because that should not affect to the production nor other platforms.
,
Dec 13 2017
Bisect info: You are probably looking for a change made after 523639 (known good), but no later than 523640 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/4ee0fd38b4d6979c8642251da3079473f67b25dd..fdd23baca689698b9f209d20a420be712c197ef4 suspect CL: https://chromium.googlesource.com/chromium/src/+/fdd23baca689698b9f209d20a420be712c197ef4 slangley@, Could you please check whether this is caused with respect to your change.
,
Dec 14 2017
,
Dec 14 2017
Hi, Above issue is also seen for following scenario. 1.Launch Chrome, Login to Google Docs and open a blank Doc. 2.Write some text on document, copy the text and try to paste it in Omnibox. (Kindly refer the attached screen-cast). 3.Observe.
,
Dec 14 2017
slangley@, Copy/Paste feature of 'Google Docs' is not working, should be resolved ASAP.
,
Dec 15 2017
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c25dd7618547a97dbf75460eecbb36fa48c0d9f commit 8c25dd7618547a97dbf75460eecbb36fa48c0d9f Author: Stuart Langley <slangley@chromium.org> Date: Fri Dec 15 04:36:13 2017 Fix the constant used to detect text/plain string types. In ui/base/Clipboard kMimeTypeText = "text/plain" In platform/clipboard/ClipboardMimeTypes kMimeTypeText = "text" When I onion souped the code I did not realize that these two constants with the same name had different values. The fix is to use platform/clipboard/ClipboardMimeTypes kMimeTypeTextPlain so we have the same value on both sides. A future cleanup might be to amalgamate these constants. Bug: 794517 Change-Id: I9631430bc6c232afc38f12dcfad6b78f683add0b Reviewed-on: https://chromium-review.googlesource.com/828320 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#524324} [modify] https://crrev.com/8c25dd7618547a97dbf75460eecbb36fa48c0d9f/third_party/WebKit/Source/platform/exported/WebClipboardImpl.cpp
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/140d287aeb1ddc8bd56e9713ee01506fb14afcbe commit 140d287aeb1ddc8bd56e9713ee01506fb14afcbe Author: Stuart Langley <slangley@chromium.org> Date: Fri Dec 15 04:59:24 2017 Fix the constant used to detect text/plain string types. In ui/base/Clipboard kMimeTypeText = "text/plain" In platform/clipboard/ClipboardMimeTypes kMimeTypeText = "text" When I onion souped the code I did not realize that these two constants with the same name had different values. The fix is to use platform/clipboard/ClipboardMimeTypes kMimeTypeTextPlain so we have the same value on both sides. A future cleanup might be to amalgamate these constants. Bug: 794517 Change-Id: I9631430bc6c232afc38f12dcfad6b78f683add0b Reviewed-on: https://chromium-review.googlesource.com/828320 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#524324}(cherry picked from commit 8c25dd7618547a97dbf75460eecbb36fa48c0d9f) Reviewed-on: https://chromium-review.googlesource.com/828242 Reviewed-by: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/branch-heads/3294@{#6} Cr-Branched-From: 1e4786a323e8eca4d5a66474bf23aa7fa80fe7ae-refs/heads/master@{#523976} [modify] https://crrev.com/140d287aeb1ddc8bd56e9713ee01506fb14afcbe/third_party/WebKit/Source/platform/exported/WebClipboardImpl.cpp
,
Dec 15 2017
,
Dec 15 2017
Thank you Stuart for quick fix and merge to branch 3294. I've triggered new Dev RC build from branch 3294.
,
Dec 15 2017
Should this be covered by a browsertest to prevent future regressions?
,
Dec 18 2017
Issue 795212 has been merged into this issue. |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by aiman.an...@etouch.net
, Dec 13 2017