Hide "Oncalls" section when no oncalls are specified |
|||||||
Issue descriptionMilo currently shows oncalls section even if corresponding luci-milo.cfg file has no oncall header: https://luci-milo.appspot.com/p/v8/g/main/console. IMHO it should not be shown when empty.
,
Dec 13 2017
Seems very simple to do for someone familiar with MILO codebase.
,
Dec 22 2017
,
Jan 30 2018
,
Jan 30 2018
,
May 22 2018
,
May 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-go.git/+/c62c600cde6d0cc44830a3996dcfaa951068e069 commit c62c600cde6d0cc44830a3996dcfaa951068e069 Author: Sergiy Byelozyorov <sergiyb@chromium.org> Date: Tue May 22 17:39:46 2018 Hide Oncalls section when no oncalls are defined R=hinoka@chromium.org Bug: 794502 Change-Id: I2182c520d2949b6261330bd1db659a28fcf287c7 Reviewed-on: https://chromium-review.googlesource.com/1069256 Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> [modify] https://crrev.com/c62c600cde6d0cc44830a3996dcfaa951068e069/milo/frontend/appengine/templates/pages/console.html [modify] https://crrev.com/c62c600cde6d0cc44830a3996dcfaa951068e069/milo/frontend/expectations/console-Full_console_with_Header.html
,
May 23 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by serg...@chromium.org
, Dec 13 2017