Getting audio input channels fails on Mac - always falls back on stereo |
||||
Issue descriptionChrome Version: M63, has likely been around for some time. OS: Mac What steps will reproduce the problem? (1) Use a mono mic, for example Jabra 410. (1) Open a page that does getUserMedia, for example https://webrtc.github.io/samples/src/content/getusermedia/audio/ (2) Open a new tab, go to chrome://webrtc-internals, expand "Create dump", select "Enable diagnostic audio recordings". (3) Talk a little, close tabs. What is the expected result? The produced file *.source_input.1.wav or *.input.1.wav (number may vary) should be in mono. What happens instead? File is in stereo, with audio only in left channel. One problem with this is that when the channels are mixed to mono in WebRTC's audio processing module, the resulting volume is lower.
,
Dec 13 2017
Dale: can you have a look since you wrote the change in how we get the number of channels? Would you say my conclusion in #1 is correct?
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ccfcbbac6f7055e92d9da39be10c656617468fb commit 3ccfcbbac6f7055e92d9da39be10c656617468fb Author: Henrik Grunell <grunell@chromium.org> Date: Wed Dec 20 12:52:13 2017 Fix for getting number of audio input channels on Mac. Don't get channel layout for input element since that's not supported on AUHAL[1], instead get the channel count from the stream layout. Plus fixes in ScopedAudioUnit: * Enable IO before setting current device which is a requirement. * Use element 0 with global scope, which is the element to use with that scope. (This didn't cause a failure.) [1] Follow-up on this to confirm: https://crbug.com/796163 Bug: 794501 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3879989e30449000dc9d75f756c69738ac54615a Reviewed-on: https://chromium-review.googlesource.com/823972 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#525314} [modify] https://crrev.com/3ccfcbbac6f7055e92d9da39be10c656617468fb/media/audio/mac/audio_auhal_mac.cc [modify] https://crrev.com/3ccfcbbac6f7055e92d9da39be10c656617468fb/media/audio/mac/audio_manager_mac.cc [modify] https://crrev.com/3ccfcbbac6f7055e92d9da39be10c656617468fb/media/audio/mac/scoped_audio_unit.cc
,
Dec 20 2017
,
Dec 28 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by grunell@chromium.org
, Dec 13 2017