New issue
Advanced search Search tips

Issue 794490 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

AppViewTests/AppViewTest.TestAppViewMultipleConnects/0 timesout on multiple platforms

Project Member Reported by cfroussios@chromium.org, Dec 13 2017

Issue description

Cc: lazyboy@chromium.org lfg@chromium.org
Components: Platform>Apps>BrowserTag
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc686cbe40ae4e7ca7df093745b2c274e1a5e8d6

commit bc686cbe40ae4e7ca7df093745b2c274e1a5e8d6
Author: Christos Froussios <cfroussios@chromium.org>
Date: Wed Dec 13 11:17:02 2017

Disable AppViewTests/AppViewTest.TestAppViewMultipleConnects/0 on Linux asan

It frequently times out

TBR=lazyboy@chromium.org

Bug:  794490 
No-Try: True
Change-Id: Ia3644653da9ab12eee61a440d05e363569a5c156
Reviewed-on: https://chromium-review.googlesource.com/823970
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523740}
[modify] https://crrev.com/bc686cbe40ae4e7ca7df093745b2c274e1a5e8d6/chrome/browser/apps/guest_view/app_view_browsertest.cc

I disabled the test on the platform that is most affected for now.

Please help find an owner for the issue
Labels: -Sheriff-Chromium

Comment 5 by kbr@chromium.org, Dec 15 2017

Labels: -Pri-3 Pri-2
Also failed on the linux-chromeos-rel trybot, wasting machine cycles:
https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/24821

Log:

[ RUN      ] AppViewTests/AppViewTest.TestAppViewMultipleConnects/0
[28380:28380:1215/105608.808829:WARNING:statistics_provider.cc(285)] Statistics loaded after waiting 37ms.
[28618:28618:1215/105608.872708:WARNING:gpu_info.cc(104)] No active GPU found, returning primary GPU.
[28380:28581:1215/105608.981261:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin

GMOCK WARNING:
Uninteresting mock function call - returning directly.
    Function call: RegisterMediaRoutesObserver(0x259f3cad0dc0)
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.

GMOCK WARNING:
Uninteresting mock function call - taking default action specified at:
../../chrome/browser/apps/app_browsertest_util.cc:68:
    Function call: RegisterMediaSinksObserver(0x259f3cad0de8)
          Returns: true
NOTE: You can safely ignore the above warning unless this call should not happen.  Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call.  See https://github.com/google/googletest/blob/master/googlemock/docs/CookBook.md#knowing-when-to-expect for details.
[28380:28581:1215/105609.260056:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin
[28380:28581:1215/105609.397564:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin
[28380:28581:1215/105609.574377:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin
[28380:28380:1215/105609.856389:INFO:CONSOLE(37)] "appToEmbed  kokfgimdhgfhmjimgobogpefmnbkmepm", source: chrome-extension://pafllcoibaghfkfjhpgopgihgjblfdfd/main.js (37)
[28380:28380:1215/105609.889028:INFO:CONSOLE(37)] "CONNECTED. (1 / 10)", source: chrome-extension://pafllcoibaghfkfjhpgopgihgjblfdfd/main.js (37)
[28380:28380:1215/105609.903679:ERROR:frame_sink_provider_impl.cc(34)] No RenderWidgetHost exists with id 3 in process 5
[28380:28380:1215/105609.922340:INFO:CONSOLE(37)] "CONNECTED. (2 / 10)", source: chrome-extension://pafllcoibaghfkfjhpgopgihgjblfdfd/main.js (37)
[28380:28380:1215/105609.925500:ERROR:frame_sink_provider_impl.cc(34)] No RenderWidgetHost exists with id 5 in process 5
[28380:28380:1215/105609.941159:INFO:CONSOLE(37)] "CONNECTED. (3 / 10)", source: chrome-extension://pafllcoibaghfkfjhpgopgihgjblfdfd/main.js (37)
[28380:28380:1215/105609.980376:INFO:CONSOLE(37)] "CONNECTED. (4 / 10)", source: chrome-extension://pafllcoibaghfkfjhpgopgihgjblfdfd/main.js (37)
[28380:28380:1215/105610.003669:INFO:CONSOLE(37)] "CONNECTED. (5 / 10)", source: chrome-extension://pafllcoibaghfkfjhpgopgihgjblfdfd/main.js (37)
[28380:28380:1215/105610.006446:ERROR:frame_sink_provider_impl.cc(34)] No RenderWidgetHost exists with id 11 in process 5
[28380:28380:1215/105618.965825:ERROR:tab_manager_delegate_chromeos.cc(82)] Set OOM score error: 
BrowserTestBase received signal: Terminated. Backtrace:
#0 0x000003dfec7c base::debug::StackTrace::StackTrace()
#1 0x000004435622 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f5690748cb0 <unknown>
#3 0x7f5690810693 epoll_wait
#4 0x000004d7260d epoll_dispatch
#5 0x000004d700ed event_base_loop
#6 0x000003e21ba4 base::MessagePumpLibevent::Run()
#7 0x000003e1edf9 base::MessageLoop::Run()
#8 0x000003e48769 base::RunLoop::Run()
#9 0x000004472993 content::RunMessageLoop()
#10 0x000008ceef8e ExtensionTestMessageListener::WaitUntilSatisfied()
#11 0x0000005d98e5 AppViewTest::TestHelper()
#12 0x0000005da043 AppViewTest_TestAppViewMultipleConnects_Test::RunTestOnMainThread()
#13 0x000004435383 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#14 0x000003f2fe4c ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#15 0x000003f2ec4d ChromeBrowserMainParts::PreMainMessageLoopRun()
#16 0x0000018ad90a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#17 0x000002648111 content::BrowserMainLoop::PreMainMessageLoopRun()
#18 0x000002a87f55 content::StartupTaskRunner::RunAllTasksNow()
#19 0x00000264661f content::BrowserMainLoop::CreateStartupTasks()
#20 0x00000264b198 content::BrowserMainRunnerImpl::Initialize()
#21 0x0000026442e2 content::BrowserMain()
#22 0x000003dde781 content::ContentMainRunnerImpl::Run()
#23 0x000005ea204b service_manager::Main()
#24 0x000003ddd164 content::ContentMain()
#25 0x000004434fec content::BrowserTestBase::SetUp()
#26 0x000003ee9669 InProcessBrowserTest::SetUp()
#27 0x000001c21411 testing::Test::Run()
#28 0x000001c21f40 testing::TestInfo::Run()
#29 0x000001c22427 testing::TestCase::Run()
#30 0x000001c28a47 testing::internal::UnitTestImpl::RunAllTests()
#31 0x000001c28697 testing::UnitTest::Run()
#32 0x000003eff1b2 base::TestSuite::Run()
#33 0x000003df1699 ChromeTestSuiteRunner::RunTestSuite()
#34 0x00000446cdc4 content::LaunchTests()
#35 0x000003df1ac5 LaunchChromeTests()
#36 0x000003df12bd main
#37 0x7f5690733f45 __libc_start_main
#38 0x0000005bccaa _start
[1250/1655] AppViewTests/AppViewTest.TestAppViewMultipleConnects/0 (TIMED OUT)


I'm disabling this test everywhere.

Is it just the /0 version that times out? If so we should be careful to not disable the /1 version.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36369fb9e4c1a2bfe1798babb5c42f6a3936fa7f

commit 36369fb9e4c1a2bfe1798babb5c42f6a3936fa7f
Author: Kenneth Russell <kbr@chromium.org>
Date: Fri Dec 15 20:34:36 2017

Disable AppViewTest.TestAppViewMultipleConnects on all platforms.

It's seen to time out on the linux-chromeos-rel tryserver which is
affecting the CQ. Until someone is found to investigate the timeouts,
turn off the test.

BUG= 794490 
TBR=lazyboy@chromium.org

Change-Id: Idbf5f975df1e9b9e49f10c68bef0112e7545b541
Reviewed-on: https://chromium-review.googlesource.com/829892
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524451}
[modify] https://crrev.com/36369fb9e4c1a2bfe1798babb5c42f6a3936fa7f/chrome/browser/apps/guest_view/app_view_browsertest.cc

Owner: wjmaclean@chromium.org
I'm going to re-enable this test for the /1 configuration as it doesn't seem to fail. Feel free to revert the re-enabling if I'm wrong.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2126b752c09ed7a5715ffb50d87377be0bb57b4a

commit 2126b752c09ed7a5715ffb50d87377be0bb57b4a
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Fri Dec 15 22:38:30 2017

Reenable AppViewTest.TestAppViewMultipleConnects for the /1 case.

Since (i) this test seems to run fine for the /1 parameter case, and
(ii) the /1 parameter case represents the default configuration for
chrome as of M63, let's only disable the test for the failing
configuration, /0.

TBR=kbr@chromium.org

Bug:  794490 
Change-Id: Id1ab8dcfdafecafca138d42a9b3d3401f5d7d203
Reviewed-on: https://chromium-review.googlesource.com/830709
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524495}
[modify] https://crrev.com/2126b752c09ed7a5715ffb50d87377be0bb57b4a/chrome/browser/apps/guest_view/app_view_browsertest.cc

Cc: wjmaclean@chromium.org
Owner: hajimehoshi@chromium.org
According to Findit, https://chromium-review.googlesource.com/c/chromium/src/+/799656 caused the flakiness (see last comment on the CL).
Cc: altimin@chromium.org
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ae562c46b262f3c68dbb067299ac2d9e6be96ce

commit 0ae562c46b262f3c68dbb067299ac2d9e6be96ce
Author: Kevin McNee <mcnee@chromium.org>
Date: Mon Feb 12 21:57:06 2018

Remove BrowserPlugin parameterization of AppViewTests.

AppViewTests now only run for the GuestViewCrossProcessFrames
enabled case.

Tests that were disabled for flaking in the BrowserPlugin case are
reenabled.

Bug: 533069,  810935 ,  794490 ,  668304 
Change-Id: Ied54ca2fdafec1c15b7b68f3e8da1617c9d63a73
Reviewed-on: https://chromium-review.googlesource.com/913715
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536203}
[modify] https://crrev.com/0ae562c46b262f3c68dbb067299ac2d9e6be96ce/chrome/browser/apps/guest_view/app_view_browsertest.cc
[modify] https://crrev.com/0ae562c46b262f3c68dbb067299ac2d9e6be96ce/testing/buildbot/filters/mojo.fyi.mash.browser_tests.filter

Comment 14 by mcnee@chromium.org, Feb 12 2018

Status: Fixed (was: Untriaged)
AppViewTests now only test the OOPIF implementation.

Sign in to add a comment