Regression:Content get overlap on checkbox of 'OurStickys' extension .
Reported by
shruti.j...@etouch.net,
Dec 13 2017
|
|||
Issue descriptionChrome Version:65.0.3293.0 5d03c84689520e76673121751641d53314db60a7-refs/heads/master@{#523641} OS: Win(7,8,10), Mac(10.12.6,10.13.2) and Linux(14.04 LTS). Test URL:https://chrome.google.com/webstore/detail/ourstickys-sticky-notes-o/oficbemndigeiiennldcdfcklocpkggd/related?utm_source=chrome-ntp-icon Steps to reproduce: 1.Launch chrome and Navigate to above URL and download the extension. 2.Click on extension in omnibox and click on settings and observe. Actual Result: 'Enable advance feature' option gets overlap on check box. Expected Result: 'Enable advance feature' option should not get overlap on check box. This is regression issue broken in ‘M-64’ and below per-revision bisect result Using the per-revision bisect providing the bisect results, Good Build: 64.0.3276.0(Revision: 518819) Bad Build: 64.0.3277.0(Revision:519018) You are probably looking for a change made after 518954 (known good), but no lat er than 518955 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/9a2d008058dcc0d2e7e754932f662983243fc82e..f610be969095d0af8569924e7d7780b5a6a890cd Suspect: https://chromium.googlesource.com/chromium/src/+/f610be969095d0af8569924e7d7780b5a6a890cd @adithyas: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f07513de6aa01d1c456e031581da183435fd4fa commit 1f07513de6aa01d1c456e031581da183435fd4fa Author: Adithya Srinivasan <adithyas@chromium.org> Date: Fri Dec 15 15:17:41 2017 Create shadow root after children appended to HTMLInputElement While some input types (like checkboxes) don't need a shadow subtree for their implementation, they do need a shadow root to hide any children that may be appended by script. This CL makes input elements lazily create a shadow root when children are appended. Bug: 794484 Change-Id: I4dfeecd33b7ff39c9cfe94192b3f9ac8aa5a779d Reviewed-on: https://chromium-review.googlesource.com/826426 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#524384} [add] https://crrev.com/1f07513de6aa01d1c456e031581da183435fd4fa/third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-child-hidden-expected.html [add] https://crrev.com/1f07513de6aa01d1c456e031581da183435fd4fa/third_party/WebKit/LayoutTests/fast/forms/checkbox/checkbox-child-hidden.html [modify] https://crrev.com/1f07513de6aa01d1c456e031581da183435fd4fa/third_party/WebKit/Source/core/html/forms/HTMLInputElement.cpp [modify] https://crrev.com/1f07513de6aa01d1c456e031581da183435fd4fa/third_party/WebKit/Source/core/html/forms/HTMLInputElement.h
,
Jan 3 2018
Update : Retested above issue on Mac(10.12.6, 10.13.2), Windows(7,8,10) and Linux(14.04 LTS) OS using latest Canary #65.0.3309.0 and issue is fixed.Checkbox and 'enable advance feature does not get overlap'. Thank you!
,
Jan 3 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by msrchandra@chromium.org
, Dec 13 2017