New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 794472 link

Starred by 1 user
Status: Fixed
Owner:
█ catmulli...@chromium.org
Last visit > 30 days ago
Closed: Jan 2018
Cc:
rdevlin....@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: 2018-01-09
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Browser closes after clicking on 'Restore Settings' button for Toby Extension.

Reported by aiman.an...@etouch.net, Dec 13 2017 
Chrome Version: 65.0.3293.0 (Official Build) (cohort: 63_win_84)5d03c84689520e76673121751641d53314db60a7-refs/heads/master@{#523641} (32/64-bit) 

OS: Win(7,8,10).

Test URL: https://chrome.google.com/webstore/detail/toby-for-chrome/hddnkoipeenegfoeaoibdmnaalmgkpip?utm_source=chrome-ntp-icon

Steps to reproduce:
1. Launch chrome go to the above URL and install extension.
2. Click on extension icon in omni-box and select 'Save Session' from extension overlay.
3. Click on 'Restore Settings' on the bubble and observe. 

Actual Result: Browser closes after clicking on restore setting button.
Expected Result: Browser should not close down.

This is regression issue broken in ‘M-56’ and and below is the bisect info

Using the per-revision bisect providing the bisect results,
Good build:56.0.2905.0(Revision:428612)
Bad build:56.0.2906.0(Revision:428890)

You are probably looking for a change made after 428746 (known good), but no later than 428747 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/37af9ea6080ce52e001189255512bd5bfa1c6c45..f9bc386d7f73366b45cb85848d27b4343facf45d

Suspect: https://chromium.googlesource.com/chromium/src/+/f9bc386d7f73366b45cb85848d27b4343facf45d

@rdevlin.cronin:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is not seen on Linux(14.04 LTS) and Mac(10.12.6,10.13.1,10.13.2) OS

Thank You!
Actual Result.mp4
1.2 MB View Download
Expected Result.mp4
1.2 MB View Download

Comment 1 by rdevlin....@chromium.org, Dec 14 2017 

This is unrelated to revision f9bc386d7f73366b45cb85848d27b4343facf45d.

What's happening here:
- When you click "save session" in the Toby extension, it closes all tabs except the NTP (which it overrides).
- When you click "restore settings", it unloads the extension.
- When an extension is unloaded, we close tabs that are for that extension.
- This results in the last tab for the browser closing, and chrome exiting.

This all kind-of makes sense, but the end result is a pretty bad user experience (and I think would replicate with a simpler extension that just overrode the NTP, if that was just the only tab open).  I think we should probably go to the default NTP and unload the extension, so that a) the "restore settings" effect is visible, and b) the browser doesn't close.

Comment 2 by rdevlin....@chromium.org, Dec 14 2017

Cc: rdevlin....@chromium.org
NextAction: 2018-01-09
Owner: catmulli...@chromium.org
Assigning this to catmullings@ for now, though there are a few other things in the queue before this.  Let's try to make this in M65.

I'll set an alarm for January to see how we're looking and if we need to adjust.

Comment 3 by monor...@bugs.chromium.org, Jan 9 2018 

The NextAction date has arrived: 2018-01-09

Comment 4 by catmulli...@chromium.org, Jan 11 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d546d6ecc0e621a0d08f804a9e25c4427055740

commit 4d546d6ecc0e621a0d08f804a9e25c4427055740
Author: Catherine Mullings <catmullings@chromium.org>
Date: Thu Jan 18 02:16:04 2018

Extensions: Navigate to default chrome page on extension unload

Currently, when an extension is unloaded, Chrome closes all tabs
associated with the extensions content. If the extension overrode a
Chrome page (namely NTP, bookmarks, history), Chrome would not close
that tab and instead refresh/navigate to the default Chrome page.

However, when there is only one tab in the browser; the tab contains
extension related content; and the tab is not a Chrome page override,
Chrome would close the tab, which thereby closes the browser window.

In such case, Chrome should not close the tab, but instead navigate to
the default NTP chrome page.

Bug:  794472 
Change-Id: I5a3438817ad7f442fdd534efe481e35dd7b36a4a
Reviewed-on: https://chromium-review.googlesource.com/862183
Commit-Queue: catmullings <catmullings@chromium.org>
Reviewed-by: catmullings <catmullings@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530015}
[modify] https://crrev.com/4d546d6ecc0e621a0d08f804a9e25c4427055740/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc
[add] https://crrev.com/4d546d6ecc0e621a0d08f804a9e25c4427055740/chrome/browser/extensions/extension_web_ui_browsertest.cc
[modify] https://crrev.com/4d546d6ecc0e621a0d08f804a9e25c4427055740/chrome/browser/ui/browser.cc
[modify] https://crrev.com/4d546d6ecc0e621a0d08f804a9e25c4427055740/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/4d546d6ecc0e621a0d08f804a9e25c4427055740/chrome/test/BUILD.gn

Comment 6 by catmulli...@chromium.org, Jan 19 2018

Status: Fixed (was: Started)
►

Sign in to add a comment