New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 794442 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ARC IME: Do not consume enter/backspace keyup events in Chrome side.

Project Member Reported by kinaba@chromium.org, Dec 13 2017

Issue description

Chrome Version: M65 ToT
Context(internal): b/33295713

When text input to ARC++ app is active, the current implementation 
https://cs.chromium.org/chromium/src/components/exo/keyboard.cc?type=cs&q=consumedByime&sq=package:chromium&l=56
stops sending enter and backspace key events via exo/wayland.
(To avoid double-handling by the Chrome OS Input Methods and the app.)

This causes a problem when keydown is fired while text input is inactive,
and the corresponding keyup is fired when text input is made active.
Since no keyup is received by the ARC++ inputflinger, it starts generating infinite key repeats.



The bad situation can be simply avoided by not consuming keyup events at all.
This behavior has been already there for normal character keys and didn't cause issues.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8c0bf3537e5492cb287907cd68a671fe8c73b7a

commit e8c0bf3537e5492cb287907cd68a671fe8c73b7a
Author: Kazuhiro Inaba <kinaba@chromium.org>
Date: Thu Dec 14 00:16:24 2017

exo: Never discard key-up event even if IME is active.

Otherwise it results in a situation that keydown is delivered to the
client but keyup is not. The consequence is never-ending key repeat
in the client side.

BUG= 794442 
TEST=manually on Google Sheets app.

Change-Id: I573b75ad62c37603dc0074de6ceffa7a773b5f8b
Reviewed-on: https://chromium-review.googlesource.com/823372
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523945}
[modify] https://crrev.com/e8c0bf3537e5492cb287907cd68a671fe8c73b7a/components/exo/keyboard.cc

Comment 2 by kinaba@chromium.org, Dec 14 2017

Status: Fixed (was: Started)

Sign in to add a comment