[MD Extensions] Details page missing bottom margins |
||||
Issue descriptionI can't recall if this is a duplicate bug or not but the details pages of Extensions are missing the expected bottom padding below 'Remove Extension.' Expected: Go to chrome://settings/fonts and note the ~60px of padding
,
Dec 21 2017
,
Dec 22 2017
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6afebb399ed68da125de48025d5476b3baa2638e commit 6afebb399ed68da125de48025d5476b3baa2638e Author: dpapad <dpapad@chromium.org> Date: Fri Dec 22 01:53:04 2017 MD Extensions polish: Add bottom padding in details page. Bug: 794421 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I24771cfe31a229e5cf490a2610a7e4d12aea07a7 Reviewed-on: https://chromium-review.googlesource.com/841533 Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#525896} [modify] https://crrev.com/6afebb399ed68da125de48025d5476b3baa2638e/chrome/browser/resources/md_extensions/detail_view.html
,
Dec 22 2017
,
Apr 29 2018
r525896 above has introduced an unneeded scrollbar when the window height is sufficient to display the details container without scrolling. This happens because the padding added in this CL is summed with "min-height: 100%;" so the resultant height is "100% + 64px". The bug can be fixed by adding "box-sizing: border-box;" Should I open a new issue?
,
Apr 30 2018
@woxxom: Yes, please open a new issue.
,
Apr 30 2018
Done: bug 838290 . |
||||
►
Sign in to add a comment |
||||
Comment 1 by dpa...@chromium.org
, Dec 13 2017